Update of patch #1203 (project freeciv):
Status:None = Done
Open/Closed:Open = Closed
___
Reply to this item at:
Follow-up Comment #6, patch #1203 (project freeciv):
1) I plan to commit original move illness into its own section patch.
I will attach a diff against the current trunk to this ticket
2) Sorting values in game.ruleset and adding default values to default
ruleset is good (as it is often
Follow-up Comment #5, patch #1203 (project freeciv):
Please submit independent changes as separate tickets in the future. This
ticket has currently strange mixture of good things and things I'm against.
1) I plan to commit original move illness into its own section patch.
2) Sorting values in
Follow-up Comment #3, patch #1203 (project freeciv):
as mentioned in the last comment I did
* insert the function secfile_lookup_int_default_min_max()
* added all ruleset options as constants (default/min/max)
* use the function to load them
* cleanup of the game.ruleset files
* move illness to
Follow-up Comment #4, patch #1203 (project freeciv):
update version
* delete GAME_DEFAULT_SLOW_INVASIONS from game.c
as it is initialised by the ruleset
(file #6302)
___
Additional Item Attachment:
File name:
Follow-up Comment #2, patch #1203 (project freeciv):
Should the hard coded numbers in ruleset.c be
changed to constants defined in game.h? At the
moment it is a mix out of numbers and constants.
Furthermore, perhaps a function
secfile_lookup_int_default_min_max() is needed? It
would be equal
URL:
http://gna.org/patch/?1203
Summary: move ruleset option illness into its own section
Project: Freeciv
Submitted by: syntron
Submitted on: Montag 27.07.2009 um 20:26
Category: general
Priority: 3 -
Update of patch #1203 (project freeciv):
Assigned to:None = cazfi
___
Reply to this item at:
http://gna.org/patch/?1203
___
Message sent
Follow-up Comment #1, patch #1203 (project freeciv):
I did a complete cleanup of the game.ruleset files. The
content is not changed, only sorted and missing default
entries are added.
(file #6276)
___
Additional Item Attachment:
File