[Freeciv-Dev] [patch #1296] restructure basic notify functions

Update of patch #1296 (project freeciv): Status:None => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #1296] restructure basic notify functions

Follow-up Comment #9, patch #1296 (project freeciv): > One remark: if the packet should be used for another function, > it should not be changed at all. Does this mean a 'const' > keyword would be needed? This would again require to make a copy > of the packet to change the coordinates. Ok, I to

[Freeciv-Dev] [patch #1296] restructure basic notify functions

Follow-up Comment #8, patch #1296 (project freeciv): >> I think the reset of the coordinates (x,y) within the packet >> is needed, as the same packet struct could also be used for >> offline events. One remark: if the packet should be used for another function, it should not be changed at all.

[Freeciv-Dev] [patch #1296] restructure basic notify functions

Follow-up Comment #7, patch #1296 (project freeciv): >> if (ptile) { >> /* Is it useful? */ >> packet->x = ptile->x; >> packet->y = ptile->y; >> } > > > I think the reset of the coordinates (x,y) within the packet is > needed, as the same packet struct could also be used for offline > events. Ch

[Freeciv-Dev] [patch #1296] restructure basic notify functions

Follow-up Comment #6, patch #1296 (project freeciv): > if (ptile) { >/* Is it useful? */ >packet->x = ptile->x; >packet->y = ptile->y; > } I think the reset of the coordinates (x,y) within the packet is needed, as the same packet struct could also be used for offline events. > Wh

[Freeciv-Dev] [patch #1296] restructure basic notify functions

Follow-up Comment #5, patch #1296 (project freeciv): Using only 1 packet structure in notify_conn_packet(). (file #6823) ___ Additional Item Attachment: File name: trunk_S2_2_restructure_notify_conn.diff Size:7 KB _

[Freeciv-Dev] [patch #1296] restructure basic notify functions

Update of patch #1296 (project freeciv): Assigned to:None => pepeto ___ Reply to this item at: ___ Message po

[Freeciv-Dev] [patch #1296] restructure basic notify functions

Follow-up Comment #4, patch #1296 (project freeciv): >> + my_snprintf(packet_send.message, sizeof(packet_send.message), "%s", >> + packet->message); > > > Why is this not simple strncpy()? Or sz_strlcpy(packet_send.message, packet->message)? _

[Freeciv-Dev] [patch #1296] restructure basic notify functions

Update of patch #1296 (project freeciv): Planned Release: 2.3.0 => 2.2.0 ___ Follow-up Comment #3: > + my_snprintf(packet_send.message, sizeof(packet_send.message), "%s", > + pack

[Freeciv-Dev] [patch #1296] restructure basic notify functions

Follow-up Comment #2, patch #1296 (project freeciv): updated patch; I included the proposed changes: * create a new struct packet_chat_msg and set the coordinates for each connection * code cleanup (file #6680) ___ Additional Item Attachm

[Freeciv-Dev] [patch #1296] restructure basic notify functions

Follow-up Comment #1, patch #1296 (project freeciv): It looks a good patch. But I noticed an error in notify_conn_packet(): if one connection is not allowed to receive the tile coordinates, then the coordinates in the packets are set to -1 (which is right), but then, if the next connection of th

[Freeciv-Dev] [patch #1296] restructure basic notify functions

URL: Summary: restructure basic notify functions Project: Freeciv Submitted by: syntron Submitted on: Sonntag 13.09.2009 um 18:09 Category: general Priority: 5 - Normal