[Freeciv-Dev] [patch #3105] Road type as pillage target

2012-02-07 Thread Marko Lindqvist
Update of patch #3105 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?3105

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3105] Road type as pillage target

2012-02-07 Thread Marko Lindqvist
Follow-up Comment #5, patch #3105 (project freeciv):

 I'm not sure what the local policy is on those; give in and add
 a default case or initialiser?

When absolutely necessary I go for initializers. Adding default case to enum
switch in which all the values should be covered would mean that compiler will
be happy (=not give necessary warning) if new value to enum is later added
without adding case for it to switch.

___

Reply to this item at:

  http://gna.org/patch/?3105

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3105] Road type as pillage target

2012-02-04 Thread Marko Lindqvist
Follow-up Comment #2, patch #3105 (project freeciv):

- Fixed qui-qt compilation
- Updated network protocol capability. While no fields in network packets have
changed, client expects server to behave differently upon receiving certain
packets - old version and new one are incompatible.

(file #15008)
___

Additional Item Attachment:

File name: PillageRoad_3105-3.diff.bz2Size:6 KB


___

Reply to this item at:

  http://gna.org/patch/?3105

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3105] Road type as pillage target

2012-02-03 Thread Marko Lindqvist
Follow-up Comment #1, patch #3105 (project freeciv):

- Fixed gui-stub compilation

(file #15002)
___

Additional Item Attachment:

File name: PillageRoad_3105-2.diff.bz2Size:6 KB


___

Reply to this item at:

  http://gna.org/patch/?3105

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3105] Road type as pillage target

2012-02-02 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?3105

 Summary: Road type as pillage target
 Project: Freeciv
Submitted by: cazfi
Submitted on: Fri 03 Feb 2012 02:49:22 AM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0

___

Details:

This patch adds most of the support for having ATT_ROAD as target type for
pillage. Since savegame format does not yet allow saving such pillage actions,
this is not yet used. Roads are still pillaged as specials. Magic to switch
between pillaging roads as specials and road types is in
get_preferred_pillage(). Now it returns roads as specials.



___

File Attachments:


---
Date: Fri 03 Feb 2012 02:49:22 AM EET  Name: PillageRoad.diff.bz2  Size: 7kB  
By: cazfi

http://gna.org/patch/download.php?file_id=14975

___

Reply to this item at:

  http://gna.org/patch/?3105

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev