[Freeciv-Dev] [patch #5937] Arrays support to json-protocol
Update of patch #5937 (project freeciv): Status: In Progress = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Follow-up Comment #7: Patch #5955 opened about using json arrays. Meanwhile I'm not for reverting this from freeciv proper, as complete removal of arrays support for be regression for work toi get mainline server and client to communicate over json protocol. It can be reverted in freeciv-web side. ___ Reply to this item at: http://gna.org/patch/?5937 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5937] Arrays support to json-protocol
Follow-up Comment #6, patch #5937 (project freeciv): Here is a patch reverting this change. (file #24122) ___ Additional Item Attachment: File name: JsonArrays_revert.patchSize:8 KB ___ Reply to this item at: http://gna.org/patch/?5937 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5937] Arrays support to json-protocol
Follow-up Comment #5, patch #5937 (project freeciv): I suggest we revert this patch, as it doesn't implement json arrays correctly according to the json spec, and because it breaks Freeciv-web. This will give us time to implement arrays correctly when we have it ready, and it will fix Freeciv-web. ___ Reply to this item at: http://gna.org/patch/?5937 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5937] Arrays support to json-protocol
Update of patch #5937 (project freeciv): Assigned to: cazfi = None ___ Reply to this item at: http://gna.org/patch/?5937 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5937] Arrays support to json-protocol
Follow-up Comment #3, patch #5937 (project freeciv): cazfi, what do you think about this? ___ Reply to this item at: http://gna.org/patch/?5937 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5937] Arrays support to json-protocol
Follow-up Comment #4, patch #5937 (project freeciv): cazfi, what do you think about this? I have too many other things to do at the moment. This is something you could submit a patch about? ___ Reply to this item at: http://gna.org/patch/?5937 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5937] Arrays support to json-protocol
Update of patch #5937 (project freeciv):
Status:Done = In Progress
Open/Closed: Closed = Open
___
Follow-up Comment #2:
Sorry for not reviewing this patch in detail before now, but after thinking
about this I feel the need to discuss the array support in the JSON protocol.
As a start, please take a look at the array definition in JSON at
http://json.org/ - the definition of a JSON array is: An array is an ordered
collection of values. An array begins with [ (left bracket) and ends with ]
(right bracket). Values are separated by , (comma).
In this array implementation, arrays are implemented as separate key-value
pairs. So each array element is a separate key-value pair. For example, part
of the tech object will look like this in the new array implementation:
{name:Robotics, req_0:52, req_1:17}
I think that arrays in the json protocol should be implemented in the
json-way as described on json.org. The tech object will then look like
this:
{name:Robotics, reqs:[52,17]}
The native json array format is significantly more compact, and much easier to
iterate.
At the moment most of the dialogs in Freeciv-web are not working, since they
rely on json arrays the native way.
So let's work some more on improving the arrays support in the json-protocol
and Freeciv-web.
___
Reply to this item at:
http://gna.org/patch/?5937
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5937] Arrays support to json-protocol
Update of patch #5937 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?5937 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5937] Arrays support to json-protocol
URL: http://gna.org/patch/?5937 Summary: Arrays support to json-protocol Project: Freeciv Submitted by: cazfi Submitted on: Mon 16 Mar 2015 09:47:46 PM EET Category: freeciv-web Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 3.0.0 ___ Details: Add handling of arrays to json-protocol. This adds no support for new base types - if it was not possible to transfer something as single item, it's not possible to transfer as an array element. I haven't looked freeciv-web part yet. ___ File Attachments: --- Date: Mon 16 Mar 2015 09:47:46 PM EET Name: JsonArrays.patch Size: 9kB By: cazfi http://gna.org/patch/download.php?file_id=24085 ___ Reply to this item at: http://gna.org/patch/?5937 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
