[Freeciv-Dev] (PR#40299) fix buffer overflow in send_chat_printf

2008-06-22 Thread Jason Dorje Short
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40299 Because of a thinko there's a guaranteed buffer overflow every time this function was called. This would most likely lead to random errors further down the line. Detected by gcc 4. I'll commit this one very shortly. - Also

Re: [Freeciv-Dev] (PR#40300) can't compile S2_2

2008-06-22 Thread Jason Dorje Short
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40300 Jason Dorje Short wrote: It seems to me that this is a missing dependency for api_gen.c however; it should depend on the toluaxx program itself so if that program changes it gets regenerated. Like this. -jason Index:

Re: [Freeciv-Dev] (PR#40300) can't compile S2_2

2008-06-22 Thread Jason Dorje Short
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40300 Marko Lindqvist wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=40300 2008/6/22 Jason Dorje Short [EMAIL PROTECTED]: URL: http://bugs.freeciv.org/Ticket/Display.html?id=40300 api_gen.c:11:19: error: tolua.h: No such

Re: [Freeciv-Dev] (PR#40300) can't compile S2_2

2008-06-22 Thread Jason Dorje Short
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40300 Marko Lindqvist wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=40300 2008/6/22 Jason Dorje Short [EMAIL PROTECTED]: URL: http://bugs.freeciv.org/Ticket/Display.html?id=40300 api_gen.c:11:19: error: tolua.h: No such

Re: [Freeciv-Dev] (PR#39938) paratroopers disappear

2008-06-22 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39938 2008/4/15 Marko Lindqvist: For S2_2 and TRUNK we should probably add new event category for unit deaths other than normal battle. Patch - ML diff -Nurd -X.diff_ignore freeciv/common/events.c freeciv/common/events.c ---

Re: [Freeciv-Dev] (PR#40300) can't compile S2_2

2008-06-22 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40300 2008/6/22 Jason Dorje Short [EMAIL PROTECTED]: URL: http://bugs.freeciv.org/Ticket/Display.html?id=40300 api_gen.c:11:19: error: tolua.h: No such file or directory I'm fairly sure this is after a fresh compilation. It seems that

Re: [Freeciv-Dev] (PR#40255) [PATCH] Only draw output sprites in citymode.

2008-06-22 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40255 2008/6/6 Madeline Book: Alright, I'll check if I haven't missed something in the view-menu and see if some existing patches could do the job. I were referring to ticket #40213. There's no other patches than yours. - ML

Re: [Freeciv-Dev] (PR#40300) can't compile S2_2

2008-06-22 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40300 2008/6/22 Jason Dorje Short: It seems to me that this is a missing dependency for api_gen.c however; it should depend on the toluaxx program itself so if that program changes it gets regenerated. Like this. This will break

Re: [Freeciv-Dev] (PR#40299) fix buffer overflow in send_chat_printf

2008-06-22 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40299 2008/6/22 Jason Dorje Short: Also with utf-8 truncating things like this is not at all safe. This can send incorrect utf-8 to the server which when sent back to the client becomes very hard to handle. GTK will crash (yes, crash) if

Re: [Freeciv-Dev] (PR#40299) fix buffer overflow in send_chat_printf

2008-06-22 Thread Jason Dorje Short
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40299 Marko Lindqvist wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=40299 2008/6/22 Jason Dorje Short: Also with utf-8 truncating things like this is not at all safe. This can send incorrect utf-8 to the server which when

[Freeciv-Dev] (PR#40303) [Patch] Fix Global Observer crash in connectdlg

2008-06-22 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40303 $subject To be committed soon. - ML diff -Nurd -X.diff_ignore freeciv/client/gui-gtk-2.0/gui_main.c freeciv/client/gui-gtk-2.0/gui_main.c --- freeciv/client/gui-gtk-2.0/gui_main.c 2008-05-16 01:50:17.0 +0300 +++

Re: [Freeciv-Dev] (PR#40303) [Patch] Fix Global Observer crash in connectdlg

2008-06-22 Thread Jason Dorje Short
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40303 Marko Lindqvist wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=40303 $subject To be committed soon. if (game.player_ptr) { char *text; -if (game.player_ptr-is_ready) { +if (game.player_ptr ==

[Freeciv-Dev] (PR#40303) [Patch] Fix Global Observer crash in connectdlg

2008-06-22 Thread Jason Short
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40303 [EMAIL PROTECTED] - Sun Jun 22 07:01:15 2008]: Marko Lindqvist wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=40303 $subject To be committed soon. if (game.player_ptr) { char *text; -if

Re: [Freeciv-Dev] Should we release 2.0.10?

2008-06-22 Thread Daniel Markstedt
On Sun, 22 Jun 2008 11:15:47 +0900, Jason Dorje Short [EMAIL PROTECTED] wrote: Daniel Markstedt wrote: On 6/19/08, Marko Lindqvist [EMAIL PROTECTED] wrote: Many distributions are still not released version (of the distribution) which uses Freeciv 2.1 (Ubuntu Dapper Gutsy are both

[Freeciv-Dev] (PR#40267) [editor] icons

2008-06-22 Thread Daniel Markstedt
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40267 [book - Wed Jun 11 21:10:32 2008]: First version of editor icons that where suggested to be added to svn in PR#40184 so as remove the need for binary patches. Most images are from tileset images already in the repository. As

Re: [Freeciv-Dev] (PR#40303) [Patch] Fix Global Observer crash in connectdlg

2008-06-22 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40303 Maybe this patch makes more sense. Crash was caused by adjusting player_idx, and setting bogus player_ptr, for global observer in game_renumber_players. S2_1 version: - Fixes the bug - Adds sanity check for player number received

Re: [Freeciv-Dev] (PR#40303) [Patch] Fix Global Observer crash in connectdlg

2008-06-22 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40303 2008/6/22 Marko Lindqvist: There is no game.player_ptr or packet_remove_player in S2_2 and TRUNK. This patch only - Revert my earlier patch, but uses proper accessor functions instead of old implementation ...and one more mistake

Re: [Freeciv-Dev] (PR#40272) Meta-ticket for 2.2 release

2008-06-22 Thread Daniel Markstedt
On Fri, 13 Jun 2008 06:51:24 +0900, Marko Lindqvist [EMAIL PROTECTED] wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=40272 This is a pre-emptive meta-ticket for the 2.2 release. Any tickets which the new release should depend on should be linked here. Thanks Marko for the

Re: [Freeciv-Dev] (PR#40272) Meta-ticket for 2.2 release

2008-06-22 Thread Daniel Markstedt
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40272 On Fri, 13 Jun 2008 06:51:24 +0900, Marko Lindqvist [EMAIL PROTECTED] wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=40272 This is a pre-emptive meta-ticket for the 2.2 release. Any tickets which the new release

Re: [Freeciv-Dev] Should we release 2.0.10?

2008-06-22 Thread Christian Prochaska
Is somebody able to fix the 2.0.9 crashes reported in #39472 and #39582? I can still reproduce the crashes with current S2_0. Another reported 2.0 problem is #39757, which has a patch that hasn't been committed yet. ___ Freeciv-dev mailing list

[Freeciv-Dev] (PR#39472) Bug in v2.08 2.09 - Crash

2008-06-22 Thread Christian Prochaska
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39472 this is reported by valgrind with current S2_0 on Linux: ==10725== Invalid read of size 1 ==10725==at 0x8093E09: improvement_redundant (improvement.c:317) ==10725==by 0x8093F38: improvements_update_redundant (improvement.c:592)

Re: [Freeciv-Dev] (PR#39982) Wonder Report does not mark obsolete Wonders

2008-06-22 Thread [EMAIL PROTECTED]
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39982 I'd quite like to get this patch committed on S2_1 for the next 2.1.x release. It fixes a fairly obvious bug, and I've been running with it since 2.1.3 and haven't spotted any problems. ___

Re: [Freeciv-Dev] (PR#40272) Meta-ticket for 2.2 release

2008-06-22 Thread Per I. Mathisen
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40272 On Sun, Jun 22, 2008 at 12:14 PM, Daniel Markstedt [EMAIL PROTECTED] wrote: IMHO another must-fix for 2.2 first beta is some kind of update to the default tilesets. William's new terrain rules have outdated all 2.1 tilesets. Wooded

[Freeciv-Dev] (PR#40304) Cannot start civclient 2.0 from prefix directory

2008-06-22 Thread Daniel Markstedt
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40304 S2_0 r14840: If Freeciv is installed to a prefix defined directory (configured with --prefix=/foo/bar), starting civclient gives me: 1: Did not read help texts 1: Trying isotrident tileset. 0: No usable default tileset found,

[Freeciv-Dev] (PR#40305) G++ not tested in autogen.sh

2008-06-22 Thread Joan Creus
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40305 I can't build version 2.2, because g++ is not installed. The error message is: ../../../../bootstrap/depcomp: line 470: exec: g++: not found make[5]: *** [toluaxx.bind.o] Error 127 I can install g++, sure, but perhaps autogen.sh should

Re: [Freeciv-Dev] (PR#40272) Meta-ticket for 2.2 release

2008-06-22 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40272 2008/6/22 Per I. Mathisen: On Sun, Jun 22, 2008 at 12:14 PM, Daniel Markstedt [EMAIL PROTECTED] wrote: IMHO another must-fix for 2.2 first beta is some kind of update to the default tilesets. William's new terrain rules have outdated

Re: [Freeciv-Dev] (PR#40303) [Patch] Fix Global Observer crash in connectdlg

2008-06-22 Thread Jason Dorje Short
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40303 How do you trigger this crash? -jason ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] (PR#40272) Meta-ticket for 2.2 release

2008-06-22 Thread Jason Dorje Short
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40272 Per I. Mathisen wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=40272 On Sun, Jun 22, 2008 at 12:14 PM, Daniel Markstedt [EMAIL PROTECTED] wrote: IMHO another must-fix for 2.2 first beta is some kind of update to the

Re: [Freeciv-Dev] (PR#39582) 2.0.9: crash at end of turn

2008-06-22 Thread Jason Dorje Short
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39582 Christian Prochaska wrote: The 2.0.9 uninstaller deletes only files installed by itself, so the savegames should still be where they were stored (by default in the game directory - C:\Program Files\Freeciv-2.0.9-gtk2 or C:\Program

Re: [Freeciv-Dev] (PR#40303) [Patch] Fix Global Observer crash in connectdlg

2008-06-22 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40303 2008/6/22 Jason Dorje Short [EMAIL PROTECTED]: URL: http://bugs.freeciv.org/Ticket/Display.html?id=40303 How do you trigger this crash? In theory: 1) Start New Game 2) Observe (become global observer) 3) Pick Nation ( /take - )

Re: [Freeciv-Dev] (PR#40303) [Patch] Fix Global Observer crash in connectdlg

2008-06-22 Thread Jason Dorje Short
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40303 Marko Lindqvist wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=40303 2008/6/22 Jason Dorje Short [EMAIL PROTECTED]: URL: http://bugs.freeciv.org/Ticket/Display.html?id=40303 How do you trigger this crash? In

[Freeciv-Dev] (PR#40267) [editor] icons

2008-06-22 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40267 [dmarks - Sun Jun 22 08:27:57 2008]: Did you sort out the licensing of these gfx? I see it has been added to svn but is still lacking an accompanying .spec so I cannot see how attribution has been worked out. The spec file is in

Re: [Freeciv-Dev] (PR#40267) [editor] icons

2008-06-22 Thread Jason Dorje Short
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40267 Madeline Book wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=40267 [dmarks - Sun Jun 22 08:27:57 2008]: Did you sort out the licensing of these gfx? I see it has been added to svn but is still lacking an accompanying

Re: [Freeciv-Dev] (PR#39582) 2.0.9: crash at end of turn

2008-06-22 Thread Jason Dorje Short
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39582 I can't reproduce the crash here with S2_0. On loading the game and ending turn a time or two, the game ends. What client is used to get the crash and what is necessary to do other than just end turn? -jason

[Freeciv-Dev] (PR#39472) Bug in v2.08 2.09 - Crash

2008-06-22 Thread Jason Short
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39472 map.num_continents is never actually sent to the client - the client just deduces it from the continent numbers of each tile. So when new terrain is revealed, which can happen mid-turn, the num_continents can rise (packhand.c:2039 in

Re: [Freeciv-Dev] (PR#39472) Bug in v2.08 2.09 - Crash

2008-06-22 Thread Jason Dorje Short
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39472 A closer look at the backtrace reveals a rather severe bug in packhand.c. /* update continents */ if (ptile-continent != packet-continent ptile-continent != 0 packet-continent 0) { /* We're renumbering continents,

Re: [Freeciv-Dev] Should we release 2.0.10?

2008-06-22 Thread Daniel Markstedt
On Sun, 22 Jun 2008 20:05:19 +0900, Christian Prochaska [EMAIL PROTECTED] wrote: Is somebody able to fix the 2.0.9 crashes reported in #39472 and #39582? I can still reproduce the crashes with current S2_0. Another reported 2.0 problem is #39757, which has a patch that hasn't been committed

[Freeciv-Dev] (PR#40306) hourglass mouse pointer never goes away

2008-06-22 Thread Jason Dorje Short
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40306 Only tested in S2_1 gtk client so far. At turn end the mouse pointer is changed to the hourglass. This is changed back to a regular mouse pointer at the start of the next turn. If you have the research dialog tab open when you press

Re: [Freeciv-Dev] Should we release 2.0.10?

2008-06-22 Thread Jason Dorje Short
Daniel Markstedt wrote: On Sun, 22 Jun 2008 20:05:19 +0900, Christian Prochaska [EMAIL PROTECTED] wrote: Is somebody able to fix the 2.0.9 crashes reported in #39472 and #39582? I can still reproduce the crashes with current S2_0. Another reported 2.0 problem is #39757, which has a patch

[Freeciv-Dev] (PR#40184) [editor] Toolbar GUI front-end preliminary work

2008-06-22 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40184 Hopefully committed correctly to S2_2 (r14846) and trunk (r14847). There were some files added/moved and lots of changes to makefiles, so be sure to re-run autogen.sh.