[Freeciv-Dev] [bug #17570] SDL-client segfaults immediately when launched on color_free()

2011-01-25 Thread Matthias Pfafferodt
due to the function color_free(). It did not check if the color struct is NULL. Please test the attached patch. It is working for me. (file #12089) ___ Additional Item Attachment: File name: 20110125-fix-crash-of-sdl-client.patch Size:0 KB

[Freeciv-Dev] [patch #2408] Tile labels

2011-01-25 Thread Marko Lindqvist
Follow-up Comment #1, patch #2408 (project freeciv): - Free label memory on tile_free() (file #12090) ___ Additional Item Attachment: File name: TileLabels_2408-2.diff Size:14 KB

[Freeciv-Dev] [bug #17552] error: ls_sqlite3.h: No such file or directory

2011-01-25 Thread Matthias Pfafferodt
___ Follow-up Comment #2: the error is do to a missing '3'. 'fcdb_sqlite' is tested but the variable is named 'fcdb_sqlite3'. Fix attached. (file #12091) ___ Additional Item Attachment: File name: 20110125-fix

[Freeciv-Dev] [bug #17517] set default for fcdb (freeciv databases) to 'no'

2011-01-25 Thread Matthias Pfafferodt
Update of bug #17517 (project freeciv): Status:None = Fixed Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #17556] Palatinate nation has Monarchy as init_government

2011-01-25 Thread J.M. Maalderink
Update of bug #17556 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Follow-up Comment #4: That's a pretty

[Freeciv-Dev] [patch #2345] Ai type specific data to player

2011-01-25 Thread Marko Lindqvist
Update of patch #2345 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed

[Freeciv-Dev] [patch #2061] [mapimg04] define player colors in the ruleset

2011-01-25 Thread Matthias Pfafferodt
) ___ Additional Item Attachment: File name: 20110125-mapimg02-define-player-colors-in-the-ruleset.patch Size:62 KB ___ Reply to this item at: http://gna.org/patch/?2061

[Freeciv-Dev] [patch #2219] [autosettler] use aiplayer framework

2011-01-25 Thread Matthias Pfafferodt
Update of patch #2219 (project freeciv): Depends on: = patch #2350 ___ Reply to this item at: http://gna.org/patch/?2219 ___ Nachricht

[Freeciv-Dev] [patch #2061] [mapimg04] define player colors in the ruleset

2011-01-25 Thread Vijay Kiran Kamuju
Follow-up Comment #35, patch #2061 (project freeciv): go ahead with the commit, I will look into it if there are any breaks. currently busy with the office work :( ___ Reply to this item at: http://gna.org/patch/?2061

[Freeciv-Dev] [bug #17495] Configure printing no twice for mysql_config

2011-01-25 Thread Vijay Kiran Kamuju
Follow-up Comment #4, bug #17495 (project freeciv): generally, we dont put the empty else loop. hence its better not to include the else loop ___ Reply to this item at: http://gna.org/bugs/?17495

[Freeciv-Dev] [patch #2226] Lippe nation

2011-01-25 Thread J.M. Maalderink
Update of patch #2226 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Follow-up Comment #5: 400 nations! Keep

[Freeciv-Dev] [patch #2061] [mapimg04] define player colors in the ruleset

2011-01-25 Thread Matthias Pfafferodt
Follow-up Comment #36, patch #2061 (project freeciv): add dummy create_sprite() function to qt client go ahead with the commit, I will look into it if there are any breaks. currently busy with the office work :( Thanks for the heads up - I tested it quit carefully. It should work but

[Freeciv-Dev] [patch #2061] [mapimg04] define player colors in the ruleset

2011-01-25 Thread Marko Lindqvist
Follow-up Comment #37, patch #2061 (project freeciv): add dummy create_sprite() function to qt client As this is expected to be non-mangled symbol it should be added to qtg_cside.c, not to C++ code in sprite.cpp. FYI I'm going to commit Qt sprite implementation patch #2388 in a couple of

[Freeciv-Dev] [patch #2246] Some revisions to Viking nation

2011-01-25 Thread J.M. Maalderink
Update of patch #2246 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #17495] Configure printing no twice for mysql_config

2011-01-25 Thread Matthias Pfafferodt
Follow-up Comment #5, bug #17495 (project freeciv): generally, we dont put the empty else loop. hence its better not to include the else loop as it does not change the result I'm OK with it; feel free to steel this ticket if you commit the patch

[Freeciv-Dev] [bug #17495] Configure printing no twice for mysql_config

2011-01-25 Thread Vijay Kiran Kamuju
Follow-up Comment #6, bug #17495 (project freeciv): ok I am gonna steal it now :P and going to commit the fix ___ Reply to this item at: http://gna.org/bugs/?17495 ___ Message sent via/by

[Freeciv-Dev] [patch #2376] Fetching general files with curl

2011-01-25 Thread Marko Lindqvist
Follow-up Comment #2, patch #2376 (project freeciv): - Removed couple of now obsolete macros (file #12094) ___ Additional Item Attachment: File name: CurlGeneralFile_2376-3.diffSize:9 KB

[Freeciv-Dev] [patch #2378] Server - metaserver post with curl

2011-01-25 Thread Marko Lindqvist
Follow-up Comment #1, patch #2378 (project freeciv): - Do not remove server_close_meta() call. This change was accidentally left over from earlier approach I tried to use. (file #12095) ___ Additional Item Attachment: File name:

[Freeciv-Dev] [bug #17495] Configure printing no twice for mysql_config

2011-01-25 Thread Vijay Kiran Kamuju
Update of bug #17495 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #2380] Client - metaserver communication with curl

2011-01-25 Thread Marko Lindqvist
Follow-up Comment #1, patch #2380 (project freeciv): We don't want block client when it's waiting reply from metaserver. That would be regression to current situation. Single libcurl call to send http post and getting reply would block. I think we have to move metaserver handling to separate

[Freeciv-Dev] [patch #2061] [mapimg04] define player colors in the ruleset

2011-01-25 Thread Matthias Pfafferodt
Follow-up Comment #38, patch #2061 (project freeciv): As this is expected to be non-mangled symbol it should be added to qtg_cside.c, not to C++ code in sprite.cpp. Done (file #12096) ___ Additional Item Attachment: File name:

[Freeciv-Dev] [patch #2412] Support to write reply to file to netfile_send_post()

2011-01-25 Thread Marko Lindqvist
URL: http://gna.org/patch/?2412 Summary: Support to write reply to file to netfile_send_post() Project: Freeciv Submitted by: cazfi Submitted on: Tue 25 Jan 2011 07:26:10 PM EET Category: general

[Freeciv-Dev] [patch #2412] Support to write reply to file to netfile_send_post()

2011-01-25 Thread Marko Lindqvist
Update of patch #2412 (project freeciv): Depends on: = patch #2378 ___ Reply to this item at: http://gna.org/patch/?2412 ___ Message sent

[Freeciv-Dev] [patch #2298] Metaserver update thread

2011-01-25 Thread Marko Lindqvist
Update of patch #2298 (project freeciv): Depends on: = patch #2378 ___ Follow-up Comment #1: - Updated so that applies on top of patch #2378

[Freeciv-Dev] [patch #2298] Metaserver update thread

2011-01-25 Thread Marko Lindqvist
Additional Item Attachment, patch #2298 (project freeciv): File name: MetaSrvThread_2298-2.diff Size:2 KB ___ Reply to this item at: http://gna.org/patch/?2298 ___ Message sent

[Freeciv-Dev] [patch #2269] Kashubian nation

2011-01-25 Thread J.M. Maalderink
Update of patch #2269 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at:

Re: [Freeciv-Dev] Freeciv and Call to Power II

2011-01-25 Thread Marko Lindqvist
2011/1/25 Andrzej Owsiejczuk andre.owsiejc...@wp.pl: I've made some changes in the code of freeciv to allow some mechanics from Call to Power to work in it (in better or worse form). I would like to see them in the next version of Freeciv. If you will be interested, I'll send you the files

[Freeciv-Dev] [patch #2388] Sprite implementation for Qt-client

2011-01-25 Thread Marko Lindqvist
Update of patch #2388 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed

[Freeciv-Dev] [patch #2394] Check that configure is sane with --enable-aimodules

2011-01-25 Thread Marko Lindqvist
Update of patch #2394 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed

[Freeciv-Dev] [bug #15090] Replace BC and AD by CE and BCE

2011-01-25 Thread Marko Lindqvist
Follow-up Comment #8, bug #15090 (project freeciv): If no answer from Sam, or objections from others, within 24h, I'll commit this. ___ Reply to this item at: http://gna.org/bugs/?15090 ___

[Freeciv-Dev] [bug #17555] Stack overflow when clicking Show all in research report with multiplayer ruleset

2011-01-25 Thread Jacob Nevins
Update of bug #17555 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #17522] Fortifying a unit on a disputed square does not gain the production of that square

2011-01-25 Thread Jacob Nevins
Follow-up Comment #3, bug #17522 (project freeciv): Even denying the owner of the square the resources would be good. That should happen already (without requiring fortification), for military units (cf bug #17378). ___ Reply to this

[Freeciv-Dev] [bug #17445] solar plant is available despite hoover dam

2011-01-25 Thread Jacob Nevins
Update of bug #17445 (project freeciv): Status:None = Invalid Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #2413] test_player_sell_building_now()

2011-01-25 Thread Marko Lindqvist
URL: http://gna.org/patch/?2413 Summary: test_player_sell_building_now() Project: Freeciv Submitted by: cazfi Submitted on: Tue 25 Jan 2011 11:53:41 PM EET Category: general Priority: 5 - Normal

[Freeciv-Dev] [patch #2408] Tile labels

2011-01-25 Thread Marko Lindqvist
Follow-up Comment #2, patch #2408 (project freeciv): - Save tile labels also to format 1 savegames (file #12100) ___ Additional Item Attachment: File name: TileLabels_2408-3.diff Size:16 KB

[Freeciv-Dev] [patch #2414] Consider Qt-client output window input utf-8

2011-01-25 Thread Marko Lindqvist
URL: http://gna.org/patch/?2414 Summary: Consider Qt-client output window input utf-8 Project: Freeciv Submitted by: cazfi Submitted on: Wed 26 Jan 2011 01:09:45 AM EET Category: client-qt Priority: 5 -

Re: [Freeciv-Dev] [bug #17445] solar plant is available despite hoover dam

2011-01-25 Thread David Lowe
On 9 Jan, 2011, at 10:12 AM, Jacob Nevins wrote: However, the Solar Plant can have a better effect than the Hoover Dam, since it can completely eliminate pollution (rather than just reducing it); therefore, it's not marked in strike-through. I have no quibble with the Solar Plant

[Freeciv-Dev] [bug #16354] Amplio2 - old specials

2011-01-25 Thread Marko Lindqvist
Follow-up Comment #4, bug #16354 (project freeciv): Should also ruins gfx be replaced? What is status of this ticket? When these gfx are expected to be ready? Should it be considered blocker for 2.3.0 release? ___ Reply to this item at:

[Freeciv-Dev] [bug #17575] Windows version of netfile.c requires rand.h include

2011-01-25 Thread Marko Lindqvist
URL: http://gna.org/bugs/?17575 Summary: Windows version of netfile.c requires rand.h include Project: Freeciv Submitted by: cazfi Submitted on: Wed 26 Jan 2011 02:29:46 AM EET Category: general Severity:

[Freeciv-Dev] [bug #17575] Windows version of netfile.c requires rand.h include

2011-01-25 Thread Marko Lindqvist
Update of bug #17575 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #2378] Server - metaserver post with curl

2011-01-25 Thread Marko Lindqvist
Follow-up Comment #2, patch #2378 (project freeciv): - Updated against current svn (file #12103) ___ Additional Item Attachment: File name: CurlMeta_2378-3.diff Size:13 KB

[Freeciv-Dev] [bug #16922] Freeciv manpage lists old email address

2011-01-25 Thread Marko Lindqvist
Update of bug #16922 (project freeciv): Status: In Progress = Ready For Test ___ Follow-up Comment #2: Patches: - S2_2: Just update man pages - S2_3 TRUNK: Dynamically build man pages from

[Freeciv-Dev] [bug #16922] Freeciv manpage lists old email address

2011-01-25 Thread Marko Lindqvist
Follow-up Comment #3, bug #16922 (project freeciv): Dynamic version requires that you rename doc/man/freeciv-server.6 as freeciv-server.6.in and freeciv-client.6 as freeciv-client.6.in before applying patch. ___ Reply to this item at:

[Freeciv-Dev] [bug #16922] Freeciv manpage lists old email address

2011-01-25 Thread Marko Lindqvist
Follow-up Comment #4, bug #16922 (project freeciv): - Do not distribute generated man pages in tarball. (file #12106) ___ Additional Item Attachment: File name: DynamicMan_16922-2.diffSize:3 KB

[Freeciv-Dev] [bug #14705] Window dimensions should be restored at the main menu

2011-01-25 Thread Marko Lindqvist
Follow-up Comment #1, bug #14705 (project freeciv): OTOH if window size has been increased on purpose, people may think it annoying if it gets automatically shrunk when they visit main menu. ___ Reply to this item at:

[Freeciv-Dev] [bug #17576] connectmsg command does not work

2011-01-25 Thread Marko Lindqvist
URL: http://gna.org/bugs/?17576 Summary: connectmsg command does not work Project: Freeciv Submitted by: cazfi Submitted on: Wed 26 Jan 2011 03:30:53 AM EET Category: client Severity: 3 - Normal

[Freeciv-Dev] [bug #16557] Disallow attempts to change to same treaty level in GUI

2011-01-25 Thread Marko Lindqvist
Update of bug #16557 (project freeciv): Status:None = Ready For Test Planned Release: 2.3.0 = 2.3.0, 2.4.0 ___ Follow-up Comment #1: Patch (file

[Freeciv-Dev] [bug #16566] Duplicate base building actions on combat menu for workers

2011-01-25 Thread Marko Lindqvist
Follow-up Comment #5, bug #16566 (project freeciv): For the record, there is two bases with gui type Fortress in default, multiplayer and experimental rulesets: Fortress and Buoy. They have one gui type Airbase base: Airbase ___ Reply to

[Freeciv-Dev] [bug #17461] Document FREECIV_PATH, FREECIV_DATA_PATH etc.

2011-01-25 Thread Marko Lindqvist
Update of bug #17461 (project freeciv): Planned Release: 2.3.0 = 2.3.0, 2.4.0 Summary: Ruleset directory ancients/data not found = Document FREECIV_PATH, FREECIV_DATA_PATH etc. ___

[Freeciv-Dev] [bug #17576] connectmsg command does not work

2011-01-25 Thread Marko Lindqvist
Update of bug #17576 (project freeciv): Planned Release: = 2.3.0, 2.4.0 ___ Follow-up Comment #1: S2_3 and TRUNK affected, S2_2 not. ___

[Freeciv-Dev] [bug #15518] Valgrind warning from openload_ruleset_file()

2011-01-25 Thread Marko Lindqvist
Follow-up Comment #6, bug #15518 (project freeciv): Suppression file is for suppressing valgrind warnings that we know to be harmless (or not in our own code). So real problems are not lost among false alarms. We have suppression file to be used when valgrinding freeciv as scripts/freeciv.supp.

[Freeciv-Dev] [bug #16710] Units can steal base ownership when loading the game

2011-01-25 Thread Marko Lindqvist
Follow-up Comment #6, bug #16710 (project freeciv): I still don't see in which situation current code would lead to error. In usual case base ownership is loaded from savegame, and it is used. Only if savegame is illegal (for the current code, it may have been legal situation when game was saved