[Freeciv-Dev] [patch #3753] Remove river road types when removing tiny isles

2013-02-26 Thread Marko Lindqvist
URL: http://gna.org/patch/?3753 Summary: Remove river road types when removing tiny isles Project: Freeciv Submitted by: cazfi Submitted on: Tue 26 Feb 2013 11:23:39 AM EET Category: general Priority: 5 -

[Freeciv-Dev] [patch #3754] Extend road rivers when ocean transformed to land

2013-02-26 Thread Marko Lindqvist
URL: http://gna.org/patch/?3754 Summary: Extend road rivers when ocean transformed to land Project: Freeciv Submitted by: cazfi Submitted on: Tue 26 Feb 2013 11:40:21 AM EET Category: general Priority: 5 -

[Freeciv-Dev] Comment changes (was: [bug #20494] Uninitialized PACKET_UNIT_ORDERS)

2013-02-26 Thread Jacob Nevins
Marko Lindqvist writes: [...] Should have added comment at least to remind why exactly so. [...] Where I work, we have a policy that every commit is accounted to a bug like here, but we have an exception for comment-only changes, on the grounds of having the barrier to improving comments be as

[Freeciv-Dev] [bug #20561] Move translations from freeciv-server to the clients.

2013-02-26 Thread Oleg
URL: http://gna.org/bugs/?20561 Summary: Move translations from freeciv-server to the clients. Project: Freeciv Submitted by: o01eg Submitted on: Втр 26 Фев 2013 10:07:53 Category: general Severity: 1 -

Re: [Freeciv-Dev] Comment changes (was: [bug #20494] Uninitialized PACKET_UNIT_ORDERS)

2013-02-26 Thread Marko Lindqvist
On 26 February 2013 11:49, Jacob Nevins 0jacobnk.fc...@chiark.greenend.org.uk wrote: Marko Lindqvist writes: [...] Should have added comment at least to remind why exactly so. [...] Where I work, we have a policy that every commit is accounted to a bug like here, but we have an exception for

[Freeciv-Dev] [bug #20561] Move translations from freeciv-server to the clients.

2013-02-26 Thread Jacob Nevins
Follow-up Comment #1, bug #20561 (project freeciv): I've thought about this. Not really practical; consider messages that are currently constructed out of bits (unit names, numbers, ...) on the server and sent as single strings to the client; you'd need to send the format string and arguments to

[Freeciv-Dev] [bug #20561] Move translations from freeciv-server to the clients.

2013-02-26 Thread Oleg
Follow-up Comment #2, bug #20561 (project freeciv): What if send client packet with arguments instead the format string like here http://svn.gna.org/viewcvs/freeciv?view=revisionrevision=22161 Is modpack-specific text can be translated now?

[Freeciv-Dev] [patch #3755] Road type out increase regardless of terrain

2013-02-26 Thread Marko Lindqvist
URL: http://gna.org/patch/?3755 Summary: Road type out increase regardless of terrain Project: Freeciv Submitted by: cazfi Submitted on: Tue 26 Feb 2013 06:31:30 PM EET Category: general Priority: 5 -

[Freeciv-Dev] [patch #3755] Road type output increase regardless of terrain

2013-02-26 Thread Marko Lindqvist
Update of patch #3755 (project freeciv): Summary: Road type out increase regardless of terrain = Road type output increase regardless of terrain ___ Reply to this item at: http://gna.org/patch/?3755

[Freeciv-Dev] [bug #20543] lua error: Execution time limit exceeded in script

2013-02-26 Thread Marko Lindqvist
Follow-up Comment #4, bug #20543 (project freeciv): Testing my patch I've noticed that there's something wrong with the supposed randomness of it. Every map I create has Scorched Spot and Deep Trench and no other labels while each label should appear with same probability.

[Freeciv-Dev] [patch #3741] Use ruleset author flag names in README.effects

2013-02-26 Thread Marko Lindqvist
Update of patch #3741 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed

[Freeciv-Dev] [patch #3756] RFC: UI for building generic roads, bases, etc

2013-02-26 Thread Jacob Nevins
URL: http://gna.org/patch/?3756 Summary: RFC: UI for building generic roads, bases, etc Project: Freeciv Submitted by: jtn Submitted on: Tue Feb 26 23:46:55 2013 Category: client Priority: 5 - Normal

[Freeciv-Dev] [bug #20551] failed to compile luasql: not compatible with Lua 5.2

2013-02-26 Thread Jacob Nevins
Follow-up Comment #8, bug #20551 (project freeciv): Applying the patch (file #17336) I get cc1: warnings being treated as errors ls_mysql.c: In function ‘cur_nullify’: ls_mysql.c:193: error: no return statement in function returning non-void And indeed that appears to be true. The whole

[Freeciv-Dev] [bug #20551] failed to compile luasql: not compatible with Lua 5.2

2013-02-26 Thread Jacob Nevins
Follow-up Comment #9, bug #20551 (project freeciv): (Erm, I should have said that's in dependencies/luasql-2.1.1/src/ls_mysql.c.) ___ Reply to this item at: http://gna.org/bugs/?20551 ___

[Freeciv-Dev] [bug #20565] automake warning: variable `EXTRA_freeciv_manual_DEPENDENCIES' is defined but...

2013-02-26 Thread Jacob Nevins
URL: http://gna.org/bugs/?20565 Summary: automake warning: variable `EXTRA_freeciv_manual_DEPENDENCIES' is defined but... Project: Freeciv Submitted by: jtn Submitted on: Wed Feb 27 00:33:54 2013 Category: bootstrap

[Freeciv-Dev] [bug #20565] automake warning: variable `EXTRA_freeciv_manual_DEPENDENCIES' is defined but...

2013-02-26 Thread Jacob Nevins
Update of bug #20565 (project freeciv): Planned Release: 2.5.0 = 2.4.0,2.5.0 ___ Follow-up Comment #1: Actually this is happening on S2_4 as well (only it's manual/Makefile.am there).

[Freeciv-Dev] [bug #20565] automake warning: variable `EXTRA_freeciv_manual_DEPENDENCIES' is defined but...

2013-02-26 Thread Marko Lindqvist
Follow-up Comment #2, bug #20565 (project freeciv): That's a good warning, the line in question does nothing sensible. It came with bug #20095. It seems like something one meant to do just temporarily while developing/testing the patch (not yet removing dependency list completely, but renaming it

[Freeciv-Dev] [patch #3745] Set have_river_overlay correctly in case of road with compat_special = River

2013-02-26 Thread Marko Lindqvist
Update of patch #3745 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed

[Freeciv-Dev] [bug #20553] Units with both icon and orientation sprites display icon everywhere

2013-02-26 Thread Marko Lindqvist
Update of bug #20553 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed

[Freeciv-Dev] [patch #3737] Make get_defense_power() static

2013-02-26 Thread Marko Lindqvist
Update of patch #3737 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed

[Freeciv-Dev] [bug #20565] automake warning: variable `EXTRA_freeciv_manual_DEPENDENCIES' is defined but...

2013-02-26 Thread Marko Lindqvist
Update of bug #20565 (project freeciv): Status:None = Ready For Test ___ Follow-up Comment #3: Fixes attached (file #17355, file #17356)

[Freeciv-Dev] [bug #20551] failed to compile luasql: not compatible with Lua 5.2

2013-02-26 Thread Marko Lindqvist
Follow-up Comment #10, bug #20551 (project freeciv): No caller expects return value, so making the return value void. I'm more worried about the fact that this didn't turn out as error in my build. Despite -Werror it shows it just as an warning. (file #17357)

[Freeciv-Dev] [bug #20567] Lua random() not really random

2013-02-26 Thread Marko Lindqvist
URL: http://gna.org/bugs/?20567 Summary: Lua random() not really random Project: Freeciv Submitted by: cazfi Submitted on: Wed 27 Feb 2013 09:30:30 AM EET Category: None Severity: 3 - Normal

[Freeciv-Dev] [bug #20567] Lua random() not really random

2013-02-26 Thread Marko Lindqvist
Follow-up Comment #1, bug #20567 (project freeciv): There must be some problem in how main gameseed is restored after map has been generated (note that it's already restored by the time map_generated lua signal). Actually, if restoring of gameseed worked like it seems to be designed, our new 2.4