[Freeciv-Dev] [patch #4636] civ2civ3 rules: fixes

2014-04-27 Thread David Fernandez
Follow-up Comment #9, patch #4636 (project freeciv): ok, I'll do it. ___ Reply to this item at: http://gna.org/patch/?4636 ___ Mensaje enviado vía/por Gna! http://gna.org/

[Freeciv-Dev] [patch #4668] Requirement type MinCulture

2014-04-27 Thread Emmet Hikory
Follow-up Comment #1, patch #4668 (project freeciv): Noticed some typos in helpdata.c: ...minimum culture if %d ..., rather than ...of %d... in the second entry of several PL_() calls (the first entries use of). ___ Reply to this item

[Freeciv-Dev] [patch #4668] Requirement type MinCulture

2014-04-27 Thread Emmet Hikory
Follow-up Comment #2, patch #4668 (project freeciv): More detailed review: 1) if/of typo (see comment #2) 2) Uses minsize, rather than minculture in !preq-present (else) conditions in helpdata.c 3) cityturn.c:: notification worklist_change_build_target(): text implies REQ_RANGE_CITY (although

[Freeciv-Dev] [patch #4459] Requirement range Traderoutes

2014-04-27 Thread Emmet Hikory
Follow-up Comment #1, patch #4459 (project freeciv): I thought I'd try this, but ran into some uncertainties for some requirement types. For Extra, BaseFlag, RoadFlag, Terrain, Resource, TerrainCass, TerrainFlag, and MinSize should whether the current player knows and/or sees the qualifying

[Freeciv-Dev] [bug #21901] Segmentation fault in style_of_nation in Freeciv-web

2014-04-27 Thread Jacob Nevins
Follow-up Comment #9, bug #21901 (project freeciv): I can't now remember why I didn't make is_playable entirely a server-side thing when doing the nationsets rework (patch #3448 etc). I certainly considered but, but ended up with it being the clients' responsibility to check is_playable; I wonder

[Freeciv-Dev] [bug #21913] find_beachhead() doesn't work properly

2014-04-27 Thread pepeto
Update of bug #21913 (project freeciv): Assigned to: pepeto = persia ___ Follow-up Comment #5: I've attached better patches for this for S2_4, S2_5, and trunk, which address the most

Re: [Freeciv-Dev] Freeciv-Web ideas, suggestions and feedback

2014-04-27 Thread Andreas Røsdal
Thanks for the feedback by testing on a Chromebook. As Freeciv-web is the only way to play Freeciv on a Chromebook, since it's only web-based, so I really want to improve Freeciv-web so that it works better on a Chromebook. The challenge is that the Chromebooks usually have slow CPUs and no

[Freeciv-Dev] [bug #21972] genhash_bucket_lookup() taking 12% of the time

2014-04-27 Thread anonymous
Follow-up Comment #3, bug #21972 (project freeciv): Should the default section of the case statement be included as a fallback if all if conditions do not match? I'm not sure if this would never be possible ... ___ Reply to this item at:

[Freeciv-Dev] [patch #4636] civ2civ3 rules: fixes

2014-04-27 Thread David Fernandez
Follow-up Comment #10, patch #4636 (project freeciv): Updated patch with conflicts between bases, instead of requirements. (file #20595, file #20596) ___ Additional Item Attachment: File name: civ2civ3-bases-2.patch Size:6 KB File

[Freeciv-Dev] [patch #4558] Help generator: generalize unit_type_fulfills_requirement()

2014-04-27 Thread Sveinung Kvilhaugsvik
Update of patch #4558 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #21972] genhash_bucket_lookup() taking 12% of the time

2014-04-27 Thread Marko Lindqvist
Follow-up Comment #4, bug #21972 (project freeciv): Should the default section of the case statement be included as a fallback if all if conditions do not match? Bug part of the optimization there is that there's no branching (if (xxx)) when there's only one *possible* case. We don't want to

[Freeciv-Dev] [bug #21913] find_beachhead() doesn't work properly

2014-04-27 Thread Emmet Hikory
Follow-up Comment #6, bug #21913 (project freeciv): Thanks for the catch. These updated patches should ideally leak less memory. (file #20597, file #20598, file #20599) ___ Additional Item Attachment: File name:

[Freeciv-Dev] [patch #3871] Support airlifting units with complex nativity

2014-04-27 Thread Emmet Hikory
Update of patch #3871 (project freeciv): Status:None = Ready For Test Assigned to:None = persia Planned Release: = 2.6.0

[Freeciv-Dev] [patch #4651] Barbarian Leaders should accept amphibious bodyguards

2014-04-27 Thread Emmet Hikory
Update of patch #4651 (project freeciv): Category:None = ai Status:None = Ready For Test Assigned to:None = persia Planned Release:

[Freeciv-Dev] [patch #4665] Alien government bonuses rework

2014-04-27 Thread Marko Lindqvist
Update of patch #4665 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed

[Freeciv-Dev] [bug #21979] worklist_change_build_target() messages imply REQ_RANGE_CITY regardless of real range

2014-04-27 Thread Marko Lindqvist
URL: http://gna.org/bugs/?21979 Summary: worklist_change_build_target() messages imply REQ_RANGE_CITY regardless of real range Project: Freeciv Submitted by: cazfi Submitted on: Mon 28 Apr 2014 12:32:30 AM EEST Category:

[Freeciv-Dev] [patch #4668] Requirement type MinCulture

2014-04-27 Thread Marko Lindqvist
Follow-up Comment #3, patch #4668 (project freeciv): 1 2 fixed, 3 raised as bug #21979 (file #20600) ___ Additional Item Attachment: File name: MinCulture-2.patch Size:14 KB

[Freeciv-Dev] [patch #4663] Preferred musicset

2014-04-27 Thread Marko Lindqvist
Follow-up Comment #2, patch #4663 (project freeciv): - Compare suggested musicset name against current musicset name, not soundset name (file #20601) ___ Additional Item Attachment: File name: PreferredMusicset-3.patch Size:14 KB

[Freeciv-Dev] [bug #21897] Enabling multiple fcdb backends cause same object files to be linked from multiple libraries

2014-04-27 Thread Marko Lindqvist
Update of bug #21897 (project freeciv): Severity: 3 - Normal = 5 - Blocker Planned Release: 2.4.3, 2.5.0, 2.6.0 = 2.4.3, 2.5.0-beta1, 2.6.0 ___ Follow-up Comment #11: I'm adding a new

[Freeciv-Dev] [patch #4671] Move limits on what terrain a spy action can be done from to action enablers

2014-04-27 Thread Sveinung Kvilhaugsvik
Follow-up Comment #2, patch #4671 (project freeciv): Thanks for your feed back, Emmet. Your suggestions looks like two alternatives I had considered. I may have considered them enough that anything even remotely similar looks like one of them. Please let me know if I'm talking about something

[Freeciv-Dev] [bug #21897] Enabling multiple fcdb backends cause same object files to be linked from multiple libraries

2014-04-27 Thread Marko Lindqvist
Additional Item Attachment, bug #21897 (project freeciv): File name: LuasqlBase-4.patch Size:5 KB File name: LuasqlBase-S2_4-4.patchSize:5 KB ___ Reply to this item at: http://gna.org/bugs/?21897

[Freeciv-Dev] [bug #21980] --disable-nls build broken

2014-04-27 Thread Marko Lindqvist
URL: http://gna.org/bugs/?21980 Summary: --disable-nls build broken Project: Freeciv Submitted by: cazfi Submitted on: Mon 28 Apr 2014 02:04:50 AM EEST Category: client Severity: 3 - Normal

[Freeciv-Dev] [patch #4673] Remove unused progtest.m4

2014-04-27 Thread Marko Lindqvist
URL: http://gna.org/patch/?4673 Summary: Remove unused progtest.m4 Project: Freeciv Submitted by: cazfi Submitted on: Mon 28 Apr 2014 02:21:12 AM EEST Category: bootstrap Priority: 5 - Normal

[Freeciv-Dev] [patch #4671] Move limits on what terrain a spy action can be done from to action enablers

2014-04-27 Thread Emmet Hikory
Follow-up Comment #3, patch #4671 (project freeciv): On Alternative 1: My fear here is that the logical conclusion to a patch series along that line ends up causing the ruleset to need to duplicate the entirety of the nativity rules that are in the engine (unless move also ends up using this

[Freeciv-Dev] [patch #4674] Rename PO_DOMAINS as PODOMAINS

2014-04-27 Thread Marko Lindqvist
URL: http://gna.org/patch/?4674 Summary: Rename PO_DOMAINS as PODOMAINS Project: Freeciv Submitted by: cazfi Submitted on: Mon 28 Apr 2014 03:08:05 AM EEST Category: bootstrap Priority: 5 - Normal

[Freeciv-Dev] [bug #21982] present=FALSE improvement requirements can cause incorrect server messages

2014-04-27 Thread Emmet Hikory
URL: http://gna.org/bugs/?21982 Summary: present=FALSE improvement requirements can cause incorrect server messages Project: Freeciv Submitted by: persia Submitted on: Mon 28 Apr 2014 01:29:07 PM JST Category: general

[Freeciv-Dev] [bug #21115] [metaticket] Negated requirements ('negated'=TRUE, 'present'=FALSE) do not work reliably

2014-04-27 Thread Emmet Hikory
Update of bug #21115 (project freeciv): Depends on: = bugs #21982 ___ Reply to this item at: http://gna.org/bugs/?21115 ___ Message sent