[Freeciv-Dev] [bug #16383] Option to forbid RiverNative units moving diagonally / cross-continent

2011-09-11 Thread Sveinung Kvilhaugsvik
Follow-up Comment #11, bug #16383 (project freeciv): Would you be OK with some way of specifying in the ruleset whether a given kind of non-native unit requires present or merely adjacent native terrain to a city? (I haven't even begun to think about what that might look like, but it should

[Freeciv-Dev] Connecting an AI that runs on the JVM to Freeciv

2011-09-12 Thread Sveinung Kvilhaugsvik
to rejected at once Sincerely Sveinung Kvilhaugsvik ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] Connecting an AI that runs on the JVM to Freeciv

2011-09-13 Thread Sveinung Kvilhaugsvik
On Mon, Sep 12, 2011 at 5:10 PM, Marko Lindqvist cazf...@gmail.com wrote: I don't have time for in-depth analysis aty the moment, but here are some quick clarifications Thank you. The fact that being marked as an AI and using the AI interface is two distinct things helped a lot. With same

Re: [Freeciv-Dev] Connecting an AI that runs on the JVM to Freeciv

2011-09-13 Thread Sveinung Kvilhaugsvik
On Mon, Sep 12, 2011 at 7:11 PM, Matthias Pfafferodt matthias.pfaffer...@mapfa.de wrote: Hello Sveinung, Hello Matthias, I do try at the moment to get a lua AI to work. It is not as easy as it may look. More information, especially about the different types of AIs you can find at the ticket:

Re: [Freeciv-Dev] Connecting an AI that runs on the JVM to Freeciv

2011-09-16 Thread Sveinung Kvilhaugsvik
Thank you for your feed back so far. I got some new options based on it: I understand that in order to record I need to change the server - either to make it record a game it self or to send the information to something else that will record it. Would it be much work for me to add a recording

[Freeciv-Dev] [patch #2979] Add 4 custom effects for rule set authors to use via Lua

2011-09-30 Thread Sveinung Kvilhaugsvik
URL: http://gna.org/patch/?2979 Summary: Add 4 custom effects for rule set authors to use via Lua Project: Freeciv Submitted by: sveinung Submitted on: Fri 30 Sep 2011 01:46:30 PM GMT Category: None

[Freeciv-Dev] Quick questions about packets.def

2011-11-24 Thread Sveinung Kvilhaugsvik
Hi, Is it correct to assume that a type alias must be defined before it's used? Is my understanding of the documentation correct if I interpret it to say that it's OK to directly use a basic type (instead of a type alias) in a field in a packet? I've found no basic type use in packets and no type

[Freeciv-Dev] [patch #3080] Remove unused field types from packets.def

2012-01-01 Thread Sveinung Kvilhaugsvik
URL: http://gna.org/patch/?3080 Summary: Remove unused field types from packets.def Project: Freeciv Submitted by: sveinung Submitted on: Mon 02 Jan 2012 01:06:12 AM GMT Category: None Priority: 5 -

Re: [Freeciv-Dev] [patch #1339] Unit type requirements

2012-01-07 Thread Sveinung Kvilhaugsvik
/srv_main_gen.c Sincerely Sveinung Kvilhaugsvik ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3345] View units in foreign cities

2012-06-26 Thread Sveinung Kvilhaugsvik
URL: http://gna.org/patch/?3345 Summary: View units in foreign cities Project: Freeciv Submitted by: sveinung Submitted on: Tue 26 Jun 2012 10:44:01 PM GMT Category: None Priority: 5 - Normal

[Freeciv-Dev] [bug #19868] Network protocol documentation

2012-06-29 Thread Sveinung Kvilhaugsvik
URL: http://gna.org/bugs/?19868 Summary: Network protocol documentation Project: Freeciv Submitted by: sveinung Submitted on: Fri 29 Jun 2012 09:02:23 AM GMT Category: None Severity: 1 - Wish

[Freeciv-Dev] [patch #3345] View units in foreign cities

2012-06-29 Thread Sveinung Kvilhaugsvik
Follow-up Comment #1, patch #3345 (project freeciv): Rename and base on current trunk. (file #15924) ___ Additional Item Attachment: File name: see_city_units.patch Size:1 KB

[Freeciv-Dev] [patch #3345] View units in foreign cities

2012-06-29 Thread Sveinung Kvilhaugsvik
Follow-up Comment #3, patch #3345 (project freeciv): Thank you for the tip. I'll send an updated patch after I have tested it. ___ Reply to this item at: http://gna.org/patch/?3345 ___

[Freeciv-Dev] [patch #3345] View units in foreign cities

2012-06-29 Thread Sveinung Kvilhaugsvik
Follow-up Comment #6, patch #3345 (project freeciv): Good catch. I looked at the compilation output again and found the mentioned warning now. I overlooked it among the information from make, translations, etc. (I don't have much experience concerning developing in C.) Seems like I (re)read the

[Freeciv-Dev] [patch #3015] Add citizens feature to built-in help

2012-06-30 Thread Sveinung Kvilhaugsvik
Follow-up Comment #7, patch #3015 (project freeciv): How about using a term like cultural identity? Rules ranging from no assimilation at all to quick assimilation can all use that term without becoming unrealistic. ___ Reply to this item

[Freeciv-Dev] [patch #3345] View units in foreign cities

2012-07-02 Thread Sveinung Kvilhaugsvik
Follow-up Comment #8, patch #3345 (project freeciv): New version. Tests: * Compiles using ./autogen.sh --enable-debug make * Auto game when map and game seed is the same (the effect isn't active): same as trunk (except time) * Auto game when map and game seed is the same (the effect is active

[Freeciv-Dev] [patch #3345] View units in foreign cities

2012-07-02 Thread Sveinung Kvilhaugsvik
Follow-up Comment #9, patch #3345 (project freeciv): Found a bug in my patch (unless its a consequence of me using the editor to test various scenarios): after invading a city containing a wonder granting this effect foreign cities not under fog of war at the time of the invasion appear empty.

[Freeciv-Dev] [bug #19868] Network protocol documentation

2012-07-06 Thread Sveinung Kvilhaugsvik
Follow-up Comment #2, bug #19868 (project freeciv): On Thu, Jul 5, 2012 at 6:38 PM, Marko Lindqvist wrote: Can you send your current patch as an reference what kind of results we are talking here? Hopefully the patch will get uploaded to Gna for real this time. This is the patch that I

Re: [Freeciv-Dev] [bug #19868] Network protocol documentation

2012-07-06 Thread Sveinung Kvilhaugsvik
On Thu, Jul 5, 2012 at 10:38 PM, Gilles J. Seguin se...@videotron.ca wrote: * Some recursive dependencies are ignored what is recursive ? nothing can you provide examples. My mistake. Should have been transitive dependencies. (Dependency of dependency) While the generated Java code

[Freeciv-Dev] Is this a bug? (no delta, no compression, focus blinking in gtk 2 research)

2013-02-06 Thread Sveinung Kvilhaugsvik
therefore can't tell if this is a side effect of my configuration or a bug triggered by it. -- Sincerely Sveinung Kvilhaugsvik ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3675] Rivers as road types in rulesets

2013-02-09 Thread Sveinung Kvilhaugsvik
Follow-up Comment #1, patch #3675 (project freeciv): Had a look. Setting the rivers to non pillageable was forgotten. PS! Thanks for publishing this patch and therefore making it less time consuming to try river as road before it's done

[Freeciv-Dev] [patch #3698] Corrections to docs/README.delta

2013-02-13 Thread Sveinung Kvilhaugsvik
URL: http://gna.org/patch/?3698 Summary: Corrections to docs/README.delta Project: Freeciv Submitted by: sveinung Submitted on: Wed 13 Feb 2013 12:24:59 PM GMT Category: None Priority: 5 - Normal

[Freeciv-Dev] [patch #3698] Corrections to docs/README.delta

2013-02-13 Thread Sveinung Kvilhaugsvik
Follow-up Comment #1, patch #3698 (project freeciv): The values of the unchanged fields will be filled in from an old version at the receiving side. could use a clarification. I had a look at the generated code when delta is enabled. If it is as simple as it appears, and keys etc aren't taken

[Freeciv-Dev] [patch #3698] Corrections to docs/README.delta

2013-02-14 Thread Sveinung Kvilhaugsvik
Follow-up Comment #3, patch #3698 (project freeciv): Maybe further clarifications would be welcome to determine how those bytes are used. Good idea. I added (See HACKING to learn how to understand the packet header) (avoids duplication) to the attached update. Also, I proposed a change in the

[Freeciv-Dev] [patch #3698] Corrections to docs/README.delta

2013-02-14 Thread Sveinung Kvilhaugsvik
Follow-up Comment #4, patch #3698 (project freeciv): My new understanding: Packets without a key will use the previous packet of the same kind. Packets with one key will use the previous packet of the same kind that had the same key. Packets with two keys will use the previous packet of the same

[Freeciv-Dev] [patch #3698] Corrections to docs/README.delta

2013-02-15 Thread Sveinung Kvilhaugsvik
Follow-up Comment #6, patch #3698 (project freeciv): Thank you for your help, Per. I have attached a new version adding the following explanation: The old version filled in from is the previous packet of the same kind that has the same value in each key field. (If the packet's kind don't have any

[Freeciv-Dev] [bug #19868] Network protocol documentation

2013-02-18 Thread Sveinung Kvilhaugsvik
Follow-up Comment #4, bug #19868 (project freeciv): Could you update this patch against current trunk and avoid usage of C++-style comments //? Yes. No C++-style comments. As the editing of text currently is done manually I want to be sure I don't do it wrong: Should I merge the information

[Freeciv-Dev] [bug #19868] Network protocol documentation

2013-02-19 Thread Sveinung Kvilhaugsvik
Follow-up Comment #6, bug #19868 (project freeciv): Attached is a version of the patch updated to svn trunk revision 22384 and a file containing the data it is based on. Should a multi line comment end in a blank line ( * last linen */)? Should comments I only change a part of be updated to the

[Freeciv-Dev] [bug #19868] Network protocol documentation

2013-02-20 Thread Sveinung Kvilhaugsvik
Follow-up Comment #7, bug #19868 (project freeciv): Warning: The attached patch breaks building when delta and bool folding is turned off. I suspect #define NAME VALUE /* start of commentn * next line */ may be involved (if NAME is replaced using VALUE /* start of comment but not the line that

[Freeciv-Dev] [bug #19868] Network protocol documentation

2013-02-20 Thread Sveinung Kvilhaugsvik
Follow-up Comment #9, bug #19868 (project freeciv): False alarm. Turns out that unless delta is enabled building using Werror will fail no matter if the patch is applied or not. ___ Reply to this item at: http://gna.org/bugs/?19868

[Freeciv-Dev] [bug #19868] Network protocol documentation

2013-02-20 Thread Sveinung Kvilhaugsvik
Follow-up Comment #10, bug #19868 (project freeciv): I would suggest for multi-line comment to move the comment before the macro. Thank you for your suggestion. I had to rework the original comments a bit since they now are above and need context. (file #17275)

Re: [Freeciv-Dev] contribute with AI - master thesis

2013-02-25 Thread Sveinung Kvilhaugsvik
150 effort and doing it locally cost 100 effort but someone else is willing to do 50% of it if its done in Freeciv you will still save effort by doing it in Freeciv. -- Sincerely Sveinung Kvilhaugsvik ___ Freeciv-dev mailing list Freeciv-dev@gna.org

[Freeciv-Dev] [bug #20666] Disaster flood requires river special

2013-03-27 Thread Sveinung Kvilhaugsvik
URL: http://gna.org/bugs/?20666 Summary: Disaster flood requires river special Project: Freeciv Submitted by: sveinung Submitted on: Wed 27 Mar 2013 02:03:51 PM GMT Category: None Severity: 3 - Normal

[Freeciv-Dev] [bug #20666] Disaster flood requires river special

2013-04-07 Thread Sveinung Kvilhaugsvik
Follow-up Comment #1, bug #20666 (project freeciv): Updated patch because of changes to trunk (file #17710) ___ Additional Item Attachment: File name: floodRoad.patchSize:0 KB

[Freeciv-Dev] Here be dragons

2013-04-28 Thread Sveinung Kvilhaugsvik
it. -- Sincerely Sveinung Kvilhaugsvik ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] Here be dragons

2013-04-30 Thread Sveinung Kvilhaugsvik
it is uploaded fixing the 2.4 issues will hopefully make it accessible to those that don't want to compile Freeciv them self. * that I'll keep secret for now as there are enough vaporware out there already -- Sincerely Sveinung Kvilhaugsvik ___ Freeciv

Re: [Freeciv-Dev] Here be dragons

2013-05-03 Thread Sveinung Kvilhaugsvik
On 4/30/13, Sveinung Kvilhaugsvik sveinun...@users.sourceforge.net wrote: A source tarball containing the source code of Freeciv and the source code of my system is coming. I just want to fix some issues I imagine may scare testers away for good first. After it is uploaded fixing the 2.4

[Freeciv-Dev] [bug #20781] Freeciv server segmentation fault on amd64

2013-05-03 Thread Sveinung Kvilhaugsvik
URL: http://gna.org/bugs/?20781 Summary: Freeciv server segmentation fault on amd64 Project: Freeciv Submitted by: sveinung Submitted on: Fri 03 May 2013 06:17:09 PM GMT Category: None Severity: 3 - Normal

[Freeciv-Dev] [bug #20781] Freeciv server segmentation fault on amd64

2013-05-03 Thread Sveinung Kvilhaugsvik
Follow-up Comment #1, bug #20781 (project freeciv): and by the email I just sent I mean http://marc.info/?l=freeciv-devm=136760487023896w=2 ___ Reply to this item at: http://gna.org/bugs/?20781

[Freeciv-Dev] [bug #20781] Freeciv server segmentation fault on amd64

2013-05-05 Thread Sveinung Kvilhaugsvik
Follow-up Comment #2, bug #20781 (project freeciv): I did some more testing. The bug is a lot more general than I believed. It can be reproduced by connecting two gtk2 Freeciv clients to the same local server, click observe in one client and pressing start in the other.

[Freeciv-Dev] [patch #3911] Improve protocol documentation

2013-05-13 Thread Sveinung Kvilhaugsvik
URL: http://gna.org/patch/?3911 Summary: Improve protocol documentation Project: Freeciv Submitted by: sveinung Submitted on: Mon 13 May 2013 11:10:23 PM GMT Category: None Priority: 5 - Normal

[Freeciv-Dev] Freeciv recorder 0.0.1

2013-05-15 Thread Sveinung Kvilhaugsvik
server (by using /quit) before disconnecting the last client the recorder may not exit. * The capability support is limited. Programs that understand the packets, like inspectTrace, will error out on variants. The recorder don't understand anything by default. -- Sincerely Sveinung Kvilhaugsvik

Re: [Freeciv-Dev] Hey All!

2013-05-16 Thread Sveinung Kvilhaugsvik
On Thu, May 16, 2013 at 8:21 AM, Chaitanya Sharma gopi.dai...@gmail.com wrote: Hi Everyone, Hi Chaitanya, I'm new to the freeciv development community., and just began setting up the dev environment for freeciv web on my local box here. Can someone point me to the bug tracker, that I can

[Freeciv-Dev] [bug #20837] Observing game crashes server

2013-05-24 Thread Sveinung Kvilhaugsvik
Follow-up Comment #3, bug #20837 (project freeciv): Seems like the issue in bug #20781 (Marko's patch solves it) ___ Reply to this item at: http://gna.org/bugs/?20837 ___ Message sent

[Freeciv-Dev] Freeciv recorder 0.0.2

2013-06-05 Thread Sveinung Kvilhaugsvik
a time out during a game but don't record time information the recording will be useless. * The Windows implementation of the Freeciv hack protocol may use a different location than Freeciv use on some set ups. -- Sincerely Sveinung Kvilhaugsvik

[Freeciv-Dev] [patch #3966] documentation: Terrain flags aren't unit type flags

2013-07-02 Thread Sveinung Kvilhaugsvik
URL: http://gna.org/patch/?3966 Summary: documentation: Terrain flags aren't unit type flags Project: Freeciv Submitted by: sveinung Submitted on: Tue 02 Jul 2013 02:24:46 PM GMT Category: None Priority: 5

[Freeciv-Dev] [patch #3974] Replace terrain.ruleset's (pollution|fallout)_(food|shield|trade)_penalty with yet another output effect

2013-07-05 Thread Sveinung Kvilhaugsvik
URL: http://gna.org/patch/?3974 Summary: Replace terrain.ruleset's (pollution|fallout)_(food|shield|trade)_penalty with yet another output effect Project: Freeciv Submitted by: sveinung Submitted on: Fri 05 Jul 2013 06:45:01 PM GMT

[Freeciv-Dev] [patch #3974] Replace terrain.ruleset's (pollution|fallout)_(food|shield|trade)_penalty with yet another output effect

2013-07-07 Thread Sveinung Kvilhaugsvik
Follow-up Comment #2, patch #3974 (project freeciv): On the contrary, this is needed as part of generic extras to get rid of the way pollution is hardcoded to be S_POLLUTION S_FALLOUT. Good. I hoped that would be the case. I saw only one coding style issue: output was declared in the middle

[Freeciv-Dev] [bug #20952] asserion failed in aidata.c's dai_plr_data_get()

2013-07-08 Thread Sveinung Kvilhaugsvik
URL: http://gna.org/bugs/?20952 Summary: asserion failed in aidata.c's dai_plr_data_get() Project: Freeciv Submitted by: sveinung Submitted on: Mon 08 Jul 2013 03:41:33 PM GMT Category: None Severity: 3 -

[Freeciv-Dev] [patch #3974] Replace terrain.ruleset's (pollution|fallout)_(food|shield|trade)_penalty with yet another output effect

2013-07-10 Thread Sveinung Kvilhaugsvik
Follow-up Comment #4, patch #3974 (project freeciv): If tile has both Pollution and Fallout, all three effects are active, resulting in 50% + 50% + 25% = 125% penalty? That is 50% + 50% + -25% = 75% penalty. Fun fact: I started using nreqs. Then I rewrote the effect definitions using negative

[Freeciv-Dev] [patch #3976] Extra requirements

2013-07-12 Thread Sveinung Kvilhaugsvik
Follow-up Comment #2, patch #3976 (project freeciv): Unfortunately we cannot obsolete the effects either. As we cannot have OR requirements in extra requirement list, one cannot make irrigation possible from nearby Ocean OR River OR Irrigation. Possible solution: Separate the action of building

[Freeciv-Dev] [patch #3976] Extra requirements

2013-07-13 Thread Sveinung Kvilhaugsvik
Follow-up Comment #5, patch #3976 (project freeciv): Isn't current model (that has the problem of being somewhat overlapping) about just what you propose. Yes. It is a generalization of it. Only some extras have an effect. There is an Irrig_Possible but no Maglev_Possible. What I suggest is

[Freeciv-Dev] [patch #4004] RFC: Generalized actions

2013-07-16 Thread Sveinung Kvilhaugsvik
Follow-up Comment #1, patch #4004 (project freeciv): I wonder if we could tie that actions stuff to causes I've partly implemented. One possibility is to have all actions cause EC_PLAYER_ACTION. Another is to make player actions a subset of causes.

[Freeciv-Dev] [patch #4042] Improve Output_Tile_Punish_Pct documentation

2013-07-25 Thread Sveinung Kvilhaugsvik
URL: http://gna.org/patch/?4042 Summary: Improve Output_Tile_Punish_Pct documentation Project: Freeciv Submitted by: sveinung Submitted on: Thu 25 Jul 2013 06:23:27 PM GMT Category: None Priority: 5 -

[Freeciv-Dev] [patch #4051] Diplomatic relation requirement type

2013-07-30 Thread Sveinung Kvilhaugsvik
URL: http://gna.org/patch/?4051 Summary: Diplomatic relation requirement type Project: Freeciv Submitted by: sveinung Submitted on: Tue 30 Jul 2013 06:43:22 PM GMT Category: None Priority: 5 - Normal

[Freeciv-Dev] [patch #4053] Use SPECENUM_COUNT for EFT_LAST

2013-07-31 Thread Sveinung Kvilhaugsvik
URL: http://gna.org/patch/?4053 Summary: Use SPECENUM_COUNT for EFT_LAST Project: Freeciv Submitted by: sveinung Submitted on: Wed 31 Jul 2013 11:29:29 PM GMT Category: None Priority: 5 - Normal

[Freeciv-Dev] [patch #4053] Use SPECENUM_COUNT for EFT_LAST

2013-08-01 Thread Sveinung Kvilhaugsvik
Follow-up Comment #2, patch #4053 (project freeciv): Reanmed (file #18607) ___ Additional Item Attachment: File name: COUNT_EFT_COUNT.patch Size:3 KB ___ Reply to this

[Freeciv-Dev] [patch #4004] RFC: Generalized actions

2013-08-01 Thread Sveinung Kvilhaugsvik
Follow-up Comment #2, patch #4004 (project freeciv): A suggested approach. It separates the concept action from the concept action enabler. An action is something a player can do. Examples of actions include building a road, building a rail road and inciting a city to revolt. It may be random if

[Freeciv-Dev] [patch #4077] action enablers + move the Spy unit flag requirement for the spy actions Poison city and Sabotage unit

2013-08-08 Thread Sveinung Kvilhaugsvik
URL: http://gna.org/patch/?4077 Summary: action enablers + move the Spy unit flag requirement for the spy actions Poison city and Sabotage unit Project: Freeciv Submitted by: sveinung Submitted on: Thu 08 Aug 2013 07:45:19 PM GMT

[Freeciv-Dev] [patch #4078] read the action enablers from the rule set (and send them to the client)

2013-08-08 Thread Sveinung Kvilhaugsvik
URL: http://gna.org/patch/?4078 Summary: read the action enablers from the rule set (and send them to the client) Project: Freeciv Submitted by: sveinung Submitted on: Thu 08 Aug 2013 07:51:04 PM GMT Category: None

[Freeciv-Dev] [patch #4079] Minimum size requirement of Poison city to action enablers

2013-08-08 Thread Sveinung Kvilhaugsvik
URL: http://gna.org/patch/?4079 Summary: Minimum size requirement of Poison city to action enablers Project: Freeciv Submitted by: sveinung Submitted on: Thu 08 Aug 2013 07:53:36 PM GMT Category: None

[Freeciv-Dev] [patch #4004] RFC: Generalized actions

2013-08-08 Thread Sveinung Kvilhaugsvik
Follow-up Comment #4, patch #4004 (project freeciv): As for the rest, I want to see some code before judging the design for performance etc. A snapshot of my progress is found in patch #4077, patch #4078 and patch #4079. Please let me know if it still is to early to judge.

[Freeciv-Dev] [patch #4077] action enablers + move the Spy unit flag requirement for the spy actions Poison city and Sabotage unit

2013-08-08 Thread Sveinung Kvilhaugsvik
Follow-up Comment #1, patch #4077 (project freeciv): Forgot to mention: the changes to the Xaw isn't tested as it compiles but won't start (no matter if this patch is applied or not). ___ Reply to this item at:

[Freeciv-Dev] [bug #21011] Xaw compiles but won't start

2013-08-08 Thread Sveinung Kvilhaugsvik
URL: http://gna.org/bugs/?21011 Summary: Xaw compiles but won't start Project: Freeciv Submitted by: sveinung Submitted on: Thu 08 Aug 2013 08:40:19 PM GMT Category: None Severity: 3 - Normal

[Freeciv-Dev] [patch #4077] action enablers + move the Spy unit flag requirement for the spy actions Poison city and Sabotage unit

2013-08-08 Thread Sveinung Kvilhaugsvik
Follow-up Comment #3, patch #4077 (project freeciv): Actually, our commit rules wouldn't require us to make changes to secondary clients even to keep them compiling. Is untested code preferred over ignoring the secondary clients? ___

[Freeciv-Dev] [patch #4051] Diplomatic relation requirement type

2013-08-12 Thread Sveinung Kvilhaugsvik
Follow-up Comment #1, patch #4051 (project freeciv): No longer just a request for comments. Applies on top of trunk SVN revision 23201. Among the changes are the addition of the relation real embassy (to/from) and renaming of the requirement type from DiplRelation to DiplRel. (file #18674)

[Freeciv-Dev] [patch #4078] read the action enablers from the rule set (and send them to the client)

2013-08-12 Thread Sveinung Kvilhaugsvik
Follow-up Comment #1, patch #4078 (project freeciv): Updated to apply on top of trunk svn revision 16510 and patch #4077. (file #18675) ___ Additional Item Attachment: File name: action_enablers_ruleset_2.patch Size:19 KB

[Freeciv-Dev] [patch #4051] Diplomatic relation requirement type

2013-08-13 Thread Sveinung Kvilhaugsvik
Follow-up Comment #3, patch #4051 (project freeciv): DRA_RECIEVES_SHARED_VISION - recEIves Thank you. Fixed. Can diplstate_type_by_name() return DS_LAST? No. It is pure paranoia about what someone may change in the future. Changed to an assert for now. The code that follow it is also pure

[Freeciv-Dev] [patch #4051] Diplomatic relation requirement type

2013-08-13 Thread Sveinung Kvilhaugsvik
Follow-up Comment #4, patch #4051 (project freeciv): Forgot to change the name in README.effects (file #18677) ___ Additional Item Attachment: File name: diplrel.patch Size:17 KB

[Freeciv-Dev] [patch #4091] Add a local range to diplomatic relation requirement type

2013-08-14 Thread Sveinung Kvilhaugsvik
URL: http://gna.org/patch/?4091 Summary: Add a local range to diplomatic relation requirement type Project: Freeciv Submitted by: sveinung Submitted on: Wed 14 Aug 2013 08:24:09 PM GMT Category: None

[Freeciv-Dev] [patch #4051] Diplomatic relation requirement type

2013-08-16 Thread Sveinung Kvilhaugsvik
Follow-up Comment #6, patch #4051 (project freeciv): Assuming this one goes in, I will be requesting follow-up patch to make diplstate_text() to use names of the states from the diplstate_type specenum instead of defining (identical) strings itself. Just to be clear before I start writing it: Do

[Freeciv-Dev] [patch #4004] RFC: Generalized actions

2013-08-16 Thread Sveinung Kvilhaugsvik
Follow-up Comment #6, patch #4004 (project freeciv): I'll go through your patches within a week (sorry for the delay, but I have limited time) for at least commenting them. Great. Hints when you read them: * As there currently only are two supported actions I have left them in an enum for now.

[Freeciv-Dev] [patch #4091] Add a local range to diplomatic relation requirement type

2013-08-16 Thread Sveinung Kvilhaugsvik
Follow-up Comment #1, patch #4091 (project freeciv): update to new version of patch #4051. (file #18684) ___ Additional Item Attachment: File name: diplrel_local.patchSize:29 KB

[Freeciv-Dev] [patch #4051] Diplomatic relation requirement type

2013-08-16 Thread Sveinung Kvilhaugsvik
Follow-up Comment #8, patch #4051 (project freeciv): In our naming conventions, is for boolean functions is usually placed in the beginning. is_diplrel_between() and is_diplrel_to_other(). Changed. (file #18687) ___ Additional Item

[Freeciv-Dev] [patch #4091] Add a local range to diplomatic relation requirement type

2013-08-16 Thread Sveinung Kvilhaugsvik
Follow-up Comment #2, patch #4091 (project freeciv): update to new version of patch #4051. (file #18688) ___ Additional Item Attachment: File name: diplrel_local.patchSize:29 KB

[Freeciv-Dev] [patch #4079] Minimum size requirement of Poison city to action enablers

2013-08-17 Thread Sveinung Kvilhaugsvik
Follow-up Comment #2, patch #4079 (project freeciv): Thank you. Fixed. (file #18696) ___ Additional Item Attachment: File name: poison_size_req.patch Size:11 KB ___ Reply

[Freeciv-Dev] [bug #21011] Xaw compiles but won't start

2013-08-17 Thread Sveinung Kvilhaugsvik
Follow-up Comment #2, bug #21011 (project freeciv): I realized I didn't have to test Xaw so I didn't investigate this bug more. Sorry about that. Have you tested that? Yes. It didn't work. You don't have suitable font in your system? That was the case. I tried adding a lot of xfonts.

[Freeciv-Dev] [patch #4077] action enablers + move the Spy unit flag requirement for the spy actions Poison city and Sabotage unit

2013-08-17 Thread Sveinung Kvilhaugsvik
Follow-up Comment #7, patch #4077 (project freeciv): Read the pathc, not tested yet. Thank you for your reviews. (I see that I need to work more on my ability to spot spelling mistakes and style mistakes) Looks promising I'm glad to hear it. I found some nitpicking I probably won't be able

[Freeciv-Dev] [bug #21037] Meeting not opened when /take player

2013-08-19 Thread Sveinung Kvilhaugsvik
Follow-up Comment #1, bug #21037 (project freeciv): But meeting dialog did not open once I had /taken the AI. Did you turn of AI mode after you took it? ___ Reply to this item at: http://gna.org/bugs/?21037

[Freeciv-Dev] [patch #4097] Kill diplstate_text(), use diplstate_type_name()

2013-08-19 Thread Sveinung Kvilhaugsvik
URL: http://gna.org/patch/?4097 Summary: Kill diplstate_text(), use diplstate_type_name() Project: Freeciv Submitted by: sveinung Submitted on: Mon 19 Aug 2013 02:17:45 PM GMT Category: None Priority: 5 -

[Freeciv-Dev] [patch #4098] Rename Xaw's actions.(c|h)

2013-08-19 Thread Sveinung Kvilhaugsvik
URL: http://gna.org/patch/?4098 Summary: Rename Xaw's actions.(c|h) Project: Freeciv Submitted by: sveinung Submitted on: Mon 19 Aug 2013 03:55:57 PM GMT Category: None Priority: 5 - Normal

[Freeciv-Dev] [patch #4077] action enablers + move the Spy unit flag requirement for the spy actions Poison city and Sabotage unit

2013-08-19 Thread Sveinung Kvilhaugsvik
Follow-up Comment #8, patch #4077 (project freeciv): Address review comments. (file #18713) ___ Additional Item Attachment: File name: action_enablers.patch Size:46 KB ___

[Freeciv-Dev] [patch #4078] read the action enablers from the rule set (and send them to the client)

2013-08-19 Thread Sveinung Kvilhaugsvik
Follow-up Comment #2, patch #4078 (project freeciv): Update to apply on top of patch #4077 (file #18714) ___ Additional Item Attachment: File name: action_enablers_ruleset.patch Size:19 KB

[Freeciv-Dev] [patch #4079] Minimum size requirement of Poison city to action enablers

2013-08-19 Thread Sveinung Kvilhaugsvik
Follow-up Comment #3, patch #4079 (project freeciv): Update to apply on top of patch #4078 (file #18715) ___ Additional Item Attachment: File name: poison_size_req.patch Size:11 KB

[Freeciv-Dev] [patch #4077] action enablers + move the Spy unit flag requirement for the spy actions Poison city and Sabotage unit

2013-08-19 Thread Sveinung Kvilhaugsvik
Follow-up Comment #9, patch #4077 (project freeciv): I just uploaded the wrong patch. Here is the correct one. (file #18716) ___ Additional Item Attachment: File name: action_enablers.patch Size:28 KB

[Freeciv-Dev] [patch #4077] action enablers + move the Spy unit flag requirement for the spy actions Poison city and Sabotage unit

2013-08-20 Thread Sveinung Kvilhaugsvik
Follow-up Comment #10, patch #4077 (project freeciv): Update to compile on top of current SVN. (file #18719) ___ Additional Item Attachment: File name: action_enablers_base.patch Size:28 KB

[Freeciv-Dev] [patch #4098] Rename Xaw's actions.(c|h)

2013-08-20 Thread Sveinung Kvilhaugsvik
Follow-up Comment #2, patch #4098 (project freeciv): You should change also multiple-inclusion-guard on xaw_actions.h. Thank you. Fixed. (file #18720) ___ Additional Item Attachment: File name: xawActionsRename.patch Size:1 KB

[Freeciv-Dev] [bug #20886] Fortresses can be used to take over territory within peaceful neighbour's city radius

2013-08-20 Thread Sveinung Kvilhaugsvik
Follow-up Comment #8, bug #20886 (project freeciv): Attached patch is 100% rule set based. It is primarily intended as a contribution to the discussion. * Transfer of ownership to border owner isn't addressed. (It may be possible to create an effect or requirement vector on the extra to trigger

[Freeciv-Dev] [patch #4100] Move the war requirement for spy actions to rule set

2013-08-20 Thread Sveinung Kvilhaugsvik
URL: http://gna.org/patch/?4100 Summary: Move the war requirement for spy actions to rule set Project: Freeciv Submitted by: sveinung Submitted on: Tue 20 Aug 2013 09:11:54 PM GMT Category: None Priority:

[Freeciv-Dev] [patch #3412] Unit_Bribe_Cost_Pct effect

2013-08-21 Thread Sveinung Kvilhaugsvik
Follow-up Comment #1, patch #3412 (project freeciv): Implemented in attached patch. Possible issues: The AI code is currently protected behind experimental. There are two reasons for this. The first is to make it easy to test that auto games (not involving the experimental AI) have the same

[Freeciv-Dev] [patch #3412] Unit_Bribe_Cost_Pct effect

2013-08-21 Thread Sveinung Kvilhaugsvik
Follow-up Comment #3, patch #3412 (project freeciv): Thanks for the information, Marko. Removed experimental guard. Halved in value. (file #18728) ___ Additional Item Attachment: File name: unit_bribe_cost.patch Size:9 KB

[Freeciv-Dev] [patch #4078] read the action enablers from the rule set (and send them to the client)

2013-08-22 Thread Sveinung Kvilhaugsvik
Follow-up Comment #3, patch #4078 (project freeciv): Add comment (file #18735) ___ Additional Item Attachment: File name: action_enablers_ruleset.patch Size:20 KB ___ Reply to

[Freeciv-Dev] [patch #4100] Move the war requirement for spy actions to rule set

2013-08-22 Thread Sveinung Kvilhaugsvik
Follow-up Comment #1, patch #4100 (project freeciv): Letting rule set authors permit sabotage of allied units could be done with a lot of extra effort. Do the extra effort, but only for the gtk clients. (file #18736) ___ Additional Item

[Freeciv-Dev] [patch #4103] Extra native_to

2013-08-23 Thread Sveinung Kvilhaugsvik
Follow-up Comment #1, patch #4103 (project freeciv): Had a look. In extras.h' extra_flag_id: Tile with this road is considered native road - extra So now it's possible that irrigation etc make tile native for a unit. Being able to do this for pollution opens some interesting possibilities.

[Freeciv-Dev] [patch #4100] Move the war requirement for spy actions to rule set

2013-08-23 Thread Sveinung Kvilhaugsvik
Follow-up Comment #2, patch #4100 (project freeciv): * Added support for the qt client, the sdl client and (untested) support for the sdl2 client. * Change capability string since new data is put in the value field on DIPLOMAT_MOVE. (Wondering if I in stead should add a new field) (file

[Freeciv-Dev] [patch #4104] Don't hard code pollution/fallout specials for global warming/cooling

2013-08-23 Thread Sveinung Kvilhaugsvik
URL: http://gna.org/patch/?4104 Summary: Don't hard code pollution/fallout specials for global warming/cooling Project: Freeciv Submitted by: sveinung Submitted on: Fri 23 Aug 2013 03:18:14 PM GMT Category: None

[Freeciv-Dev] [patch #4106] Refuel extra

2013-08-24 Thread Sveinung Kvilhaugsvik
Follow-up Comment #1, patch #4106 (project freeciv): Did you intentionally leave out the rule set changes (to avoid the noise)? ___ Reply to this item at: http://gna.org/patch/?4106 ___

[Freeciv-Dev] [bug #20886] Fortresses can be used to take over territory within peaceful neighbour's city radius

2013-08-25 Thread Sveinung Kvilhaugsvik
Follow-up Comment #10, bug #20886 (project freeciv): There's also the question if whatever limitations we implement should apply to beginning of the building, finishing of the building, or both. I see that tech loss and terrain change (caused by climate change) will check if unit activities can

[Freeciv-Dev] [bug #21064] Default AI checks for No_Incite when bribing a unit

2013-08-25 Thread Sveinung Kvilhaugsvik
URL: http://gna.org/bugs/?21064 Summary: Default AI checks for No_Incite when bribing a unit Project: Freeciv Submitted by: sveinung Submitted on: Sun 25 Aug 2013 08:34:10 PM GMT Category: None Severity: 3

[Freeciv-Dev] [patch #4078] read the action enablers from the rule set (and send them to the client)

2013-08-25 Thread Sveinung Kvilhaugsvik
Follow-up Comment #5, patch #4078 (project freeciv): Remove action enabler requirements that aren't moved to the rule set yet. (file #18764) ___ Additional Item Attachment: File name: action_enablers_ruleset.patch Size:18 KB

  1   2   3   4   5   6   7   8   9   10   >