Re: [Freeciv-Dev] (PR#38190) Gui-xaw compiler warning on x86_64
http://bugs.freeciv.org/Ticket/Display.html?id=38190 > On Thu, 15 Mar 2007 Marko Lindqvist wrote: > On 3/15/07, Egor Vyscrebentsov wrote: > > > > On Thu, 15 Mar 2007 Marko Lindqvist wrote: > > > > > cc1: warnings being treated as errors > > > ../../../src.patched/client/gui-xaw/cma_fe.c: In function > > > 'remove_preset_yes': > > > ../../../src.patched/client/gui-xaw/cma_fe.c:465: warning: cast from > > > pointer to integer of different size > > > > x86_64? > > Yes > > > Can attached patch help? > > Yes, it works. So, gui-xaw needs an audit of its code... I'm unable to check warnings on x86_64 and will be unable for a while... Well, hopefully, most part of code should be safe. If there will be any other warnings, I would ask to post them at this ticket. -- Thanks, evyscr ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#38190) Gui-xaw compiler warning
http://bugs.freeciv.org/Ticket/Display.html?id=38190 > On 3/15/07, Egor Vyscrebentsov <[EMAIL PROTECTED]> wrote: > > On Thu, 15 Mar 2007 Marko Lindqvist wrote: > > > cc1: warnings being treated as errors > > ../../../src.patched/client/gui-xaw/cma_fe.c: In function > > 'remove_preset_yes': > > ../../../src.patched/client/gui-xaw/cma_fe.c:465: warning: cast from > > pointer to integer of different size > > x86_64? Yes > Can attached patch help? Yes, it works. - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#38190) Gui-xaw compiler warning
http://bugs.freeciv.org/Ticket/Display.html?id=38190 >
On Thu, 15 Mar 2007 Marko Lindqvist wrote:
> cc1: warnings being treated as errors
> ../../../src.patched/client/gui-xaw/cma_fe.c: In function 'remove_preset_yes':
> ../../../src.patched/client/gui-xaw/cma_fe.c:465: warning: cast from
> pointer to integer of different size
x86_64? Can attached patch help?
--
Thanks, evyscr
--- cma_fe.c.orig 2007-02-04 18:18:46 +0300
+++ cma_fe.c 2007-03-15 15:37:26 +0300
@@ -462,7 +462,7 @@
static void remove_preset_yes(Widget w, XtPointer row,
XtPointer call_data)
{
- cmafec_preset_remove((int)row);
+ cmafec_preset_remove(XTPOINTER_TO_INT(row));
update_cma_preset_list();
destroy_message_dialog(w);
}
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#38190) Gui-xaw compiler warning
http://bugs.freeciv.org/Ticket/Display.html?id=38190 > cc1: warnings being treated as errors ../../../src.patched/client/gui-xaw/cma_fe.c: In function 'remove_preset_yes': ../../../src.patched/client/gui-xaw/cma_fe.c:465: warning: cast from pointer to integer of different size - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
