Re: [Freeciv-Dev] (PR#39386) cleanup tilespec.c

2007-06-17 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39386 > The rather different code in S2_1 was difficult to compare without straightening it, too. This makes the differences more apparent, and hopefully will assist debugging recent reports of load failures in certain configurations. Committed S2_

Re: [Freeciv-Dev] (PR#39386) cleanup tilespec.c

2007-06-06 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39386 > Committed trunk revision 12976. Note that this makes it obvious that the code does not even come close to the doc/README.graphics documentation! (Very confusing to new coders.) Moreover, the match_type = "full" requires the cell_type = "re

[Freeciv-Dev] (PR#39386) cleanup tilespec.c

2007-06-06 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39386 > Do we allow a cleanup phase? Trying to understand tilespec.c, there are a number of places where an if{} or {} was added around major sections of code without reindenting. Also, several levels of alternating ifs and switches, where fewer le