[Freeciv-Dev] (PR#39703) [gui-sdl] error handling of missing font

2007-09-26 Thread Christian Prochaska

URL: http://bugs.freeciv.org/Ticket/Display.html?id=39703 

 [dmarks - Do 13. Sep 2007, 07:26:09]:
 
 If gui-sdl can't locate the font specified in the themespec, it exits
 with a bus error. I think it could be handled more cleanly than so...
 
  ~Daniel
 

Patch attached.
Index: client/gui-sdl/themespec.c
===
--- client/gui-sdl/themespec.c	(revision 13656)
+++ client/gui-sdl/themespec.c	(working copy)
@@ -735,7 +735,11 @@
   if (t-font_filename) {
 t-font_filename = mystrdup(t-font_filename);
   } else {
-freelog(LOG_ERROR, Could not open font: %s, c);
+freelog(LOG_FATAL, Could not open font: %s, c);
+section_file_free(file);
+FC_FREE(fname);
+theme_free(t);
+return NULL;
   }
   freelog(LOG_DEBUG, theme font file %s, t-font_filename);
 
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] (PR#39703) [gui-sdl] error handling of missing font

2007-09-13 Thread Daniel Markstedt

URL: http://bugs.freeciv.org/Ticket/Display.html?id=39703 

If gui-sdl can't locate the font specified in the themespec, it exits
with a bus error. I think it could be handled more cleanly than so...

 ~Daniel



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev