[Freeciv-Dev] (PR#39870) unithand routines misnamed handle_* and real_*

2007-11-18 Thread Jason Short

http://bugs.freeciv.org/Ticket/Display.html?id=39870 >

> [wsimpson - Sun Nov 18 01:56:44 2007]:
> 
> Whether by history or mistake, some functions have a leading handle_ that
> are not actually network packet routines.  Another has leading real_
> 
> This makes reading the code more difficult, as it is hard to discern where
> the calls are generated.
> 
>   bool handle_unit_move_request
> 
>   void handle_unit_activity_request
>   static void handle_unit_activity_request_targeted
>   static void handle_unit_activity_request_base
> 
>   void real_unit_change_homecity

This is a historical coincidence (used as a lazy means of implementing
actions then spread far and wide after the precedent was set) and would
be a good target for fixing.

-jason


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] (PR#39870) unithand routines misnamed handle_* and real_*

2007-11-17 Thread William Allen Simpson

http://bugs.freeciv.org/Ticket/Display.html?id=39870 >

Whether by history or mistake, some functions have a leading handle_ that
are not actually network packet routines.  Another has leading real_

This makes reading the code more difficult, as it is hard to discern where
the calls are generated.

  bool handle_unit_move_request

  void handle_unit_activity_request
  static void handle_unit_activity_request_targeted
  static void handle_unit_activity_request_base

  void real_unit_change_homecity



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev