[Freeciv-Dev] [bug #13807] [patch] define the settings within a function

2009-06-28 Thread Madeline Book
Update of bug #13807 (project freeciv): Open/Closed:Open => Closed ___ Follow-up Comment #5: I'm closing this ticket as it has now been superseded by #13807.

[Freeciv-Dev] [bug #13807] [patch] define the settings within a function

2009-06-28 Thread Madeline Book
Follow-up Comment #4, bug #13807 (project freeciv): > This will help! The 'static initializers' error message > was the reason for me to try it with a function. Is an > union portable to win, ...? Struct/union initializers are part of the c language (but not c++ apparently), so it should work wi

[Freeciv-Dev] [bug #13807] [patch] define the settings within a function

2009-06-28 Thread Matthias Pfafferodt
Follow-up Comment #3, bug #13807 (project freeciv): > If you are worried that you cannot use static initializers > with unions, you need not be, since you can use the > syntax: > > union foo { > int i; > const char *s; > bool b; > }; > > union foo f1 = { .b = TRUE }; > union foo f2 = {

[Freeciv-Dev] [bug #13807] [patch] define the settings within a function

2009-06-28 Thread Madeline Book
Follow-up Comment #2, bug #13807 (project freeciv): There's also no reason to have a SETTINGS_MAX; try to find a design that is not limited in this way. As I said in #13805, get rid of all the references to 'settings' outside of settings.c, and minimize the number of references in that file too

[Freeciv-Dev] [bug #13807] [patch] define the settings within a function

2009-06-28 Thread Madeline Book
Follow-up Comment #1, bug #13807 (project freeciv): I'm not sure that we need to get rid of the static 'settings' array and use dynamic memory for settings, since even with your approach there will still be at least one variable global to the settings.c file. If you are worried that you cannot u

[Freeciv-Dev] [bug #13807] [patch] define the settings within a function

2009-06-28 Thread Madeline Book
Update of bug #13807 (project freeciv): Assigned to:None => mbook ___ Reply to this item at: ___ Message sen

[Freeciv-Dev] [bug #13807] [patch] define the settings within a function

2009-06-28 Thread Matthias Pfafferodt
URL: Summary: [patch] define the settings within a function Project: Freeciv Submitted by: syntron Submitted on: Sonntag 28.06.2009 um 17:31 Category: general Severity: 2 - Min