[Freeciv-Dev] [bug #14594] game.info.killcitizen broken

2009-10-27 Thread pepeto

Update of bug #14594 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?14594

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #14594] game.info.killcitizen broken

2009-10-25 Thread Marko Lindqvist

Follow-up Comment #1, bug #14594 (project freeciv):

IMHO helptext should use word both instead of air. Both is already used
as move type in units.ruleset and it includes amphibious units.

In the future killcitizen should be defined separately for each unit class,
and not by move type. Problem is that then it cannot no longer be server
setting but must be moved to rulesets. But let's leave that change to 2.3
anyway.

___

Reply to this item at:

  http://gna.org/bugs/?14594

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #14594] game.info.killcitizen broken

2009-10-25 Thread pepeto

Follow-up Comment #2, bug #14594 (project freeciv):

Both is included only for helicopters and air units in current default
ruleset.  I agree that air is not exact compared with what we want to do. 
But in my mind, both is a bit confusing.  The help would look:
1 = land
2 = sea
4 = both

I would understand that setting this value to 'both' will include the two
previous cases.

The new version of the patch I am attaching changes the setting help text
to:
1 = land moving units
2 = sea moving units
4 = units able to move both on land and sea


(file #7099)
___

Additional Item Attachment:

File name: trunk_S2_2_killcitizen2.diff   Size:29 KB


___

Reply to this item at:

  http://gna.org/bugs/?14594

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #14594] game.info.killcitizen broken

2009-10-24 Thread pepeto

URL:
  http://gna.org/bugs/?14594

 Summary: game.info.killcitizen broken
 Project: Freeciv
Submitted by: pepeto
Submitted on: samedi 24.10.2009 à 14:44
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: pepeto
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.2.0

___

Details:

It appears that in current trunk and S2_2, the land attacks doesn't reduce
the size of the cities whereas sea attacks do that (with default killcitizen
of 1).  Also, the help text claims that heli move type exists and make a
wrong maximum for the setting.

The attach patch fixes all this.  GAME_MAX_KILLCITIZEN is directly dependent
of MOVETYPE_LAST.




___

File Attachments:


---
Date: samedi 24.10.2009 à 14:44  Name: trunk_S2_2_killcitizen.diff  Size: 2
ko   By: pepeto

http://gna.org/bugs/download.php?file_id=7089

___

Reply to this item at:

  http://gna.org/bugs/?14594

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev