[Freeciv-Dev] [bug #14840] MSG_NOSIGNAL is not portable

[pepeto]

Update of bug #14840 (project freeciv):

Severity:  3 - Normal => 5 - Blocker
Priority:  5 - Normal => 9 - Immediate  
  Status:None => Fixed  
 Assigned to:None => pepeto 
 Open/Closed:Open => Closed 
 Planned Release:None => 2.2.0  


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #14840] MSG_NOSIGNAL is not portable

[Daniel Markstedt]

Update of bug #14840 (project freeciv):

Operating System:None => Mac OS 

___

Follow-up Comment #2:

Affecting at least Mac OS 10.6.2.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #14840] MSG_NOSIGNAL is not portable

[pepeto]

Follow-up Comment #1, bug #14840 (project freeciv):

> Looks like MSG_NOSIGNAL is a Linux thing, and isn't portable to
> (e.g.) Mac OS X and various BSDs (see e.g. here, here, here).

This is my mistake.

> I think this came in in the fix for bug #14607 on trunk/S2_2. In
> this case, there doesn't seem to be any need to suppress SIGPIPE
> in fc_writesocket(), as fc_init_network() already sets up to
> ignore SIGPIPE. So, I think it's OK to just revert to write().

It was already the case when I got this signal, and it didn't help. 
Attaching an other patch, testing the definition of MSG_NOSIGNAL.


(file #7379)
___

Additional Item Attachment:

File name: trunk_S2_2_MSG_NOSIGNAL.diff   Size:0 KB


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #14840] MSG_NOSIGNAL is not portable

[Jacob Nevins]

URL:
  

 Summary: MSG_NOSIGNAL is not portable
 Project: Freeciv
Submitted by: jtn
Submitted on: Thursday 26/11/09 at 00:00
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: None

___

Details:

dmarks mentioned running into "`MSG_NOSIGNAL' undeclared" errors on trunk/S_2
on freeciv-dev.

Looks like MSG_NOSIGNAL is a Linux thing, and isn't portable to (e.g.) Mac OS
X and various BSDs (see e.g. here
, here
, here
).

I think this came in in the fix for bug #14607 on trunk/S2_2. In this case,
there doesn't seem to be any need to suppress SIGPIPE in fc_writesocket(), as
fc_init_network() already sets up to ignore SIGPIPE. So, I think it's OK to
just revert to write().

Attached a trivial patch against S2_2 which does that. However, I don't know
how exactly to reproduce the problem of bug #14607, so I can't say I've
thoroughly tested it.

If I'm wrong about my fix, the links above suggest how to do this on
different systems, so we'll probably need some horrid autoconf stuff.



___

File Attachments:


---
Date: Thursday 26/11/09 at 00:00  Name: msg_nosignal.diff  Size: 339B   By:
jtn
Avoid non-portable MSG_NOSIGNAL [S2_2]


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev