[Freeciv-Dev] [bug #15041] Cannot free the fortify order
Follow-up Comment #5, bug #15041 (project freeciv): Can you give more detail on what you were trying to do with the unit which the client wouldn't let you? Also, was the unit ACTIVITY_FORTIFYING, or ACTIVITY_FORTIFIED? This change has unfortunately broken a desirable behaviour of the client for me. I was very pleased when the Clear unit orders on selection option was added (back in RT#40724), as previously it was impossible to focus certain units without losing important state (settler progress or fortification, say); and it's necessary to focus units to see their combat chances against an enemy units, or how many movement points they have left. Now I run with this option cleared all the time, for that reason. I'd like to regain this ability, but obviously without resurrecting *your* problem. I think this means reverting this change and possibly replacing it with another. The most obvious thing you can't do with a focused but busy unit is move it with the cursor keys / number pad -- nothing happens. (All the other orders I've tried supersede fortification.) This movement restriction seems to be enforced on the server, not the client -- variously in test_unit_move_to_tile() (silently discards action) and handle_unit_orders() (discards with error). I don't know if this is deliberate. I can see a point to such a restriction -- it stops you accidentally moving the wrong unit and losing e.g. progress towards a terrain improvement. However, a user can't in general rely on Freeciv to stop them making irreversible mistakes -- accidentally moving a unit somewhere silly is in the same category, and can't be caught. So, I could live without this safety net. If the problem is with unit movements, then I can raise a new bug with an alternative workaround, which depends on what we want to do: * If we want to allow move keys to clear orders, then I think simply calling clear_unit_orders() from key_unit_move() or thereabouts should fix the issue. * If we don't want that, then revert this change and somehow document how you tell a unit that yes, you _really_ mean to disturb it -- there are a couple ways: ** The [G]oto key works even if a unit is fortified/fortifying (the client clears the orders). ** More cumbersome: pressing [SPACE] always clears a unit's orders. You can then re-focus it and use the cursor keys. ___ Reply to this item at: http://gna.org/bugs/?15041 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15041] Cannot free the fortify order
Update of bug #15041 (project freeciv): Status: Fixed = Need Info Open/Closed: Closed = Open ___ Follow-up Comment #6: I checked RT#40724 again. It seems I missed understand the meaning of that option: Patch implements a client option to disable the behaviour that makes units lose their orders/current activity when they are selected. So when the option is not set to its default value, clicking on a unit or selecting a group of units with the selection rectangle or mass select shortcuts (e.g. 'y') will not immediately make the units stop what they are doing. Instead, the units' orders will only be cleared when the user issues new orders (e.g. goto somewhere else, a different activity, etc.) or when space is pressed. You are right on numerous points. My problem was that I was unable to assign new orders to one unit fortified (I don't remember if it was CTIVITY_FORTIFYING or ACTIVITY_FORTIFIED). In this case, shouldn't we consider adding a new key to free the orders of the selected units? ___ Reply to this item at: http://gna.org/bugs/?15041 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15041] Cannot free the fortify order
Follow-up Comment #7, bug #15041 (project freeciv): In this case, shouldn't we consider adding a new key to free the orders of the selected units? I have been wondering about that for a while. I do go through the focus unit, [SPACE], re-focus unit, [W] rigmarole to clear a unit's orders/activity and get it back on the available list without actually committing to an order there and then; but I thought that might just be me procrastinating. Do you do the same thing? Currently we have [W] which will dismiss a busy unit without disturbing it, and [SPACE] which will clear a busy unit's orders and also remove it from the list of unit awaiting orders. What we don't have is a key which clears the unit's orders and puts it on the list of units awaiting orders. Clearly we need the ability to do the first and third things. I'm not convinced the second is useful. So, I think we only really *need* two keys, and adding yet another key to all the clients is (a) one more thing to remember (b) a dreadful faff. We could change [SPACE] so that for busy units it doesn't dismiss them entirely (requiring another [SPACE] to do that), or we could swap the function of [W] and [SPACE] for busy units. ___ Reply to this item at: http://gna.org/bugs/?15041 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15041] Cannot free the fortify order
Update of bug #15041 (project freeciv): Status: Need Info = Invalid ___ Follow-up Comment #9: Ok, thank you for the explanation which points out my mistake. I will revert the committed patch immediately. ___ Reply to this item at: http://gna.org/bugs/?15041 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15041] Cannot free the fortify order
Update of bug #15041 (project freeciv): Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?15041 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15041] Cannot free the fortify order
Follow-up Comment #13, bug #15041 (project freeciv): I've raised bug #15195 for some of the the issues I raised earlier, to see if anyone else thinks it can be improved. ___ Reply to this item at: http://gna.org/bugs/?15041 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15041] Cannot free the fortify order
Update of bug #15041 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?15041 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15041] Cannot free the fortify order
Update of bug #15041 (project freeciv): Planned Release: 2.2.0 = 2.1.11, 2.2.0 ___ Reply to this item at: http://gna.org/bugs/?15041 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15041] Cannot free the fortify order
URL: http://gna.org/bugs/?15041 Summary: Cannot free the fortify order Project: Freeciv Submitted by: pepeto Submitted on: samedi 02.01.2010 à 22:50 Category: client Severity: 2 - Minor Priority: 3 - Low Status: None Assigned to: None Originator Email: Open/Closed: Open Release: 2.2-beta Discussion Lock: Any Operating System: None Planned Release: 2.2.0 ___ Details: Sometimes occurs... No idea why. ___ Reply to this item at: http://gna.org/bugs/?15041 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
