[Freeciv-Dev] [bug #15312] add check for ptile == NULL within map_colatitude()

2010-02-11 Thread Matthias Pfafferodt
Update of bug #15312 (project freeciv): Status:None => Fixed Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #15312] add check for ptile == NULL within map_colatitude()

2010-02-09 Thread pepeto
Follow-up Comment #8, bug #15312 (project freeciv): Seems good! ___ Reply to this item at: ___ Message posté via/par Gna! http://gna.org/ __

[Freeciv-Dev] [bug #15312] add check for ptile == NULL within map_colatitude()

2010-02-09 Thread Matthias Pfafferodt
Follow-up Comment #7, bug #15312 (project freeciv): yet another version (S2_2 using RETURN_VAL_IF_FAIL()) (file #8029) ___ Additional Item Attachment: File name: version3-S2_2-add-check-for-ptile-NULL-within-map_colatitude.patch Size:0 KB

[Freeciv-Dev] [bug #15312] add check for ptile == NULL within map_colatitude()

2010-02-09 Thread pepeto
Follow-up Comment #6, bug #15312 (project freeciv): > That's due to the fact that log_assert_ret_val() is only defined > within trunk. For S2_2 assert() will be needed ... (S2_2 can use RETURN_VAL_IF_FAIL()). ___ Reply to this item at:

[Freeciv-Dev] [bug #15312] add check for ptile == NULL within map_colatitude()

2010-02-09 Thread Matthias Pfafferodt
Follow-up Comment #5, bug #15312 (project freeciv): updated version for trunk * fix the check; it has to be ptile != NULL (file #8019) ___ Additional Item Attachment: File name: 20100209-trunk-add-check-for-ptile-NULL-within-map_colatitu

[Freeciv-Dev] [bug #15312] add check for ptile == NULL within map_colatitude()

2010-02-09 Thread Matthias Pfafferodt
Follow-up Comment #4, bug #15312 (project freeciv): > Seems a good compromise. Unfortunately, file #8001 appears to > compile on trunk only, not S2_2. That's due to the fact that log_assert_ret_val() is only defined within trunk. For S2_2 assert() will be needed ... Please use the attached pat

[Freeciv-Dev] [bug #15312] add check for ptile == NULL within map_colatitude()

2010-02-08 Thread pepeto
Follow-up Comment #3, bug #15312 (project freeciv): > Perhaps 'MAX_COLATITUDE / 2' Seems a good compromise. Unfortunately, file #8001 appears to compile on trunk only, not S2_2. ___ Reply to this item at:

[Freeciv-Dev] [bug #15312] add check for ptile == NULL within map_colatitude()

2010-02-08 Thread Matthias Pfafferodt
Follow-up Comment #2, bug #15312 (project freeciv): > assert() should be depreciated in newer version. Prefer the > log_assert_ret() macro or RETURN_IF_FAIL() in S2_2. I thought about this but did not know that to safely return? map_colatitude() should return the colatitude. Should I use 0, MAX

[Freeciv-Dev] [bug #15312] add check for ptile == NULL within map_colatitude()

2010-02-08 Thread pepeto
Follow-up Comment #1, bug #15312 (project freeciv): assert() should be depreciated in newer version. Prefer the log_assert_ret() macro or RETURN_IF_FAIL() in S2_2. (I'm currently working on a patch to remove all assert() calls). ___ Rep

[Freeciv-Dev] [bug #15312] add check for ptile == NULL within map_colatitude()

2010-02-08 Thread Matthias Pfafferodt
URL: Summary: add check for ptile == NULL within map_colatitude() Project: Freeciv Submitted by: syntron Submitted on: Montag 08.02.2010 um 15:52 Category: general Severity: 3