[Freeciv-Dev] [bug #15312] add check for ptile == NULL within map_colatitude()

2010-02-11 Thread Matthias Pfafferodt 

Update of bug #15312 (project freeciv):

  Status:None => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15312] add check for ptile == NULL within map_colatitude()

2010-02-09 Thread pepeto 

Follow-up Comment #8, bug #15312 (project freeciv):

Seems good!

___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15312] add check for ptile == NULL within map_colatitude()

2010-02-09 Thread Matthias Pfafferodt 

Follow-up Comment #7, bug #15312 (project freeciv):

yet another version (S2_2 using RETURN_VAL_IF_FAIL())

(file #8029)
___

Additional Item Attachment:

File name: version3-S2_2-add-check-for-ptile-NULL-within-map_colatitude.patch
Size:0 KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15312] add check for ptile == NULL within map_colatitude()

2010-02-09 Thread pepeto 

Follow-up Comment #6, bug #15312 (project freeciv):

> That's due to the fact that log_assert_ret_val() is only defined
> within trunk. For S2_2 assert() will be needed ...

(S2_2 can use RETURN_VAL_IF_FAIL()).

___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15312] add check for ptile == NULL within map_colatitude()

2010-02-09 Thread Matthias Pfafferodt 

Follow-up Comment #5, bug #15312 (project freeciv):

updated version for trunk

* fix the check; it has to be ptile != NULL

(file #8019)
___

Additional Item Attachment:

File name:
20100209-trunk-add-check-for-ptile-NULL-within-map_colatitude.patch Size:0 KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15312] add check for ptile == NULL within map_colatitude()

2010-02-09 Thread Matthias Pfafferodt 

Follow-up Comment #4, bug #15312 (project freeciv):

> Seems a good compromise. Unfortunately, file #8001 appears to
> compile on trunk only, not S2_2. 

That's due to the fact that log_assert_ret_val() is only defined within
trunk. For S2_2 assert() will be needed ...

Please use the attached patch for S2_2

(file #8018)
___

Additional Item Attachment:

File name: 20100209-S2_2-add-check-for-ptile-NULL-within-map_colatitude.patch
Size:0 KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15312] add check for ptile == NULL within map_colatitude()

2010-02-08 Thread pepeto 

Follow-up Comment #3, bug #15312 (project freeciv):

> Perhaps 'MAX_COLATITUDE / 2'

Seems a good compromise.  Unfortunately, file #8001 appears to compile on
trunk only, not S2_2.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15312] add check for ptile == NULL within map_colatitude()

2010-02-08 Thread Matthias Pfafferodt 

Follow-up Comment #2, bug #15312 (project freeciv):

> assert() should be depreciated in newer version. Prefer the
> log_assert_ret() macro or RETURN_IF_FAIL() in S2_2. 

I thought about this but did not know that to safely return? map_colatitude()
should return the colatitude. Should I use 0, MAX_COLATITUDE or a value
inbetween? Perhaps 'MAX_COLATITUDE / 2' as for all temperate maps could be OK
- see the attached patch.

(file #8001)
___

Additional Item Attachment:

File name:
version2-trunk-S2_2-add-check-for-ptile-NULL-within-map_colatitude.patch
Size:0 KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15312] add check for ptile == NULL within map_colatitude()

2010-02-08 Thread pepeto 

Follow-up Comment #1, bug #15312 (project freeciv):

assert() should be depreciated in newer version.  Prefer the log_assert_ret()
macro or RETURN_IF_FAIL() in S2_2.

(I'm currently working on a patch to remove all assert() calls).


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15312] add check for ptile == NULL within map_colatitude()

2010-02-08 Thread Matthias Pfafferodt 

URL:
  

 Summary: add check for ptile == NULL within map_colatitude()
 Project: Freeciv
Submitted by: syntron
Submitted on: Montag 08.02.2010 um 15:52
Category: general
Severity: 3 - Normal
Priority: 1 - Later
  Status: None
 Assigned to: syntron
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.2.0

___

Details:





___

File Attachments:


---
Date: Montag 08.02.2010 um 15:52  Name:
S2_1-add-check-for-ptile-NULL-within-map_colatitude.patch  Size: 792B   By:
syntron


---
Date: Montag 08.02.2010 um 15:52  Name:
trunk-S2_2-add-check-for-ptile-NULL-within-map_colatitude.patch  Size: 792B  
By: syntron



___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev