[Freeciv-Dev] [bug #16375] Buoy created inside national borders has no vision effect until save/load

2010-08-08 Thread Jacob Nevins

Update of bug #16375 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?16375

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #16375] Buoy created inside national borders has no vision effect until save/load

2010-08-06 Thread Jacob Nevins

URL:
  http://gna.org/bugs/?16375

 Summary: Buoy created inside national borders has no vision
effect until save/load
 Project: Freeciv
Submitted by: jtn
Submitted on: Saturday 08/07/10 at 01:44
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Release: 2.2.2
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.2.3,2.3.0

___

Details:

Originally reported
[url=http://forum.freeciv.org/viewtopic.php?p=25947#25947]on the forum[/url]
by HanduMan:

[A] buoy set inside it's owner's national borders does not provide the extra
vision effect.
In the savegame there are two afghani triremes carrying engineer units which
are making bouys. Klick turn done once and you'll see the first buoy appear
with widened field of vision. Klick it once more and another buoy appears
inside your borders but without extra vision.

If you save and load at this point, you get the vision effect from the second
buoy.

create_base() is relying on map_claim_ownership_full() to enact the base
vision as a side effect of taking the new base, but that function does
nothing if we already own the tile. Patch attached.



___

File Attachments:


---
Date: Saturday 08/07/10 at 01:44  Name: bouybug0.sav.gz  Size: 24kB   By: jtn
From forum: quot;/take Ahmadquot;
http://gna.org/bugs/download.php?file_id=9727

___

Reply to this item at:

  http://gna.org/bugs/?16375

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #16375] Buoy created inside national borders has no vision effect until save/load

2010-08-06 Thread Jacob Nevins

Additional Item Attachment, bug #16375 (project freeciv):

File name: S2_2-trunk-buoy-vision-in-our-borders.diff Size:1 KB


___

Reply to this item at:

  http://gna.org/bugs/?16375

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev