[Freeciv-Dev] [bug #16379] Detaching troubles

2010-08-09 Thread pepeto 

Update of bug #16379 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?16379

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16379] Detaching troubles

2010-08-07 Thread pepeto 

URL:
  http://gna.org/bugs/?16379

 Summary: Detaching troubles
 Project: Freeciv
Submitted by: pepeto
Submitted on: samedi 07.08.2010 à 10:34
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: trunk
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.3.0

___

Details:

When detaching in current trunk, There is only one player left on the start
page and I get lot of error messages :

1: in player_diplstate_get() [player.c::266]: assertion 'plr2 != ((void *)0)'
failed.
1: SVP, rapportez ce bogue à https://gna.org/projects/freeciv/
1: in handle_player_diplstate() [packhand.c::1951]: assertion 'ds != ((void
*)0)' failed.
1: SVP, rapportez ce bogue à https://gna.org/projects/freeciv/
1: in player_diplstate_get() [player.c::266]: assertion 'plr2 != ((void *)0)'
failed.
1: SVP, rapportez ce bogue à https://gna.org/projects/freeciv/
1: in handle_player_diplstate() [packhand.c::1951]: assertion 'ds != ((void
*)0)' failed.
1: SVP, rapportez ce bogue à https://gna.org/projects/freeciv/
1: in player_diplstate_get() [player.c::266]: assertion 'plr2 != ((void *)0)'
failed.
1: SVP, rapportez ce bogue à https://gna.org/projects/freeciv/
1: in handle_player_diplstate() [packhand.c::1951]: assertion 'ds != ((void
*)0)' failed.
1: SVP, rapportez ce bogue à https://gna.org/projects/freeciv/
1: in player_diplstate_get() [player.c::266]: assertion 'plr2 != ((void *)0)'
failed.
1: SVP, rapportez ce bogue à https://gna.org/projects/freeciv/
1: in handle_player_diplstate() [packhand.c::1951]: assertion 'ds != ((void
*)0)' failed.
1: SVP, rapportez ce bogue à https://gna.org/projects/freeciv/
1: in player_diplstate_get() [player.c::265]: assertion 'plr1 != ((void *)0)'
failed.
1: SVP, rapportez ce bogue à https://gna.org/projects/freeciv/
1: in handle_player_diplstate() [packhand.c::1951]: assertion 'ds != ((void
*)0)' failed.
1: SVP, rapportez ce bogue à https://gna.org/projects/freeciv/
1: in player_diplstate_get() [player.c::265]: assertion 'plr1 != ((void *)0)'
failed.
1: SVP, rapportez ce bogue à https://gna.org/projects/freeciv/
1: in handle_player_diplstate() [packhand.c::1951]: assertion 'ds != ((void
*)0)' failed.
1: SVP, rapportez ce bogue à https://gna.org/projects/freeciv/
1: in player_diplstate_get() [player.c::265]: assertion 'plr1 != ((void *)0)'
failed.
1: SVP, rapportez ce bogue à https://gna.org/projects/freeciv/
1: in handle_player_diplstate() [packhand.c::1951]: assertion 'ds != ((void
*)0)' failed.
1: SVP, rapportez ce bogue à https://gna.org/projects/freeciv/
1: in player_diplstate_get() [player.c::265]: assertion 'plr1 != ((void *)0)'
failed.
1: SVP, rapportez ce bogue à https://gna.org/projects/freeciv/
1: in handle_player_diplstate() [packhand.c::1951]: assertion 'ds != ((void
*)0)' failed.
1: SVP, rapportez ce bogue à https://gna.org/projects/freeciv/






___

Reply to this item at:

  http://gna.org/bugs/?16379

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16379] Detaching troubles

2010-08-07 Thread pepeto 

Follow-up Comment #1, bug #16379 (project freeciv):

The lost players are due to the usage of player_slots_free() and
player_slots_init() in game_reset().


___

Reply to this item at:

  http://gna.org/bugs/?16379

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16379] Detaching troubles

2010-08-07 Thread pepeto 

Update of bug #16379 (project freeciv):

  Status:None = Ready For Test 
 Assigned to:None = pepeto 

___

Follow-up Comment #2:

Fix attached:
* Use player_clear() instead of full player_slots_init/free().
* player_destroy() call player_clear() (no need to have not documented
dependent functions).

NB: it also removes all the error messages.


(file #9733)
___

Additional Item Attachment:

File name: trunk_game_reset.diff  Size:4 KB


___

Reply to this item at:

  http://gna.org/bugs/?16379

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev