[Freeciv-Dev] [bug #16440] Voteinfo bar is too long at the right of the screen

2010-09-08 Thread Jacob Nevins
Follow-up Comment #20, bug #16440 (project freeciv): We could also reducing the label size to 60 characters instead of 80, it should be really enough. Hmm, not sure, assuming you mean (struct voteinfo_bar).label. To pick a random example: _(1/2) Vote 1 by billybob: [failed] set

[Freeciv-Dev] [bug #16440] Voteinfo bar is too long at the right of the screen

2010-09-08 Thread pepeto
Follow-up Comment #23, bug #16440 (project freeciv): Hmm, not sure, assuming you mean (struct voteinfo_bar).label. To pick a random example: (1/2) Vote 1 by billybob: [failed] set separatepoles 0 (needs 51% in favor). is 76 characters. Feels like we might be able to slim the button area a

[Freeciv-Dev] [bug #16440] Voteinfo bar is too long at the right of the screen

2010-09-07 Thread Jacob Nevins
Follow-up Comment #18, bug #16440 (project freeciv): Oops, this is assigned to me, but I was waiting for you to confirm your patch. IMO it's good as it is, and we should get it in 2.2.3. If you're busy I can commit it. ___ Reply to this

[Freeciv-Dev] [bug #16440] Voteinfo bar is too long at the right of the screen

2010-09-07 Thread pepeto
Follow-up Comment #19, bug #16440 (project freeciv): It's not my best patch, but it is stable and ok for committing... Feel free to commit. ___ Reply to this item at: http://gna.org/bugs/?16440

[Freeciv-Dev] [bug #16440] Voteinfo bar is too long at the right of the screen

2010-09-04 Thread pepeto
Follow-up Comment #17, bug #16440 (project freeciv): We could also reducing the label size to 60 characters instead of 80, it should be really enough. ___ Reply to this item at: http://gna.org/bugs/?16440

[Freeciv-Dev] [bug #16440] Voteinfo bar is too long at the right of the screen

2010-08-25 Thread pepeto
Follow-up Comment #14, bug #16440 (project freeciv): When merge isn't set and small display is, the vote bar is not split, and it's still too long. Well, my patch improves it giving FALSE to parameter resize to gtk_paned_pack2(), then it doesn't hide the map too much. Not sure I

[Freeciv-Dev] [bug #16440] Voteinfo bar is too long at the right of the screen

2010-08-25 Thread pepeto
Follow-up Comment #15, bug #16440 (project freeciv): This is a patch to illustrate my purpose. It fixes also bug #16520. (Remember that the small display layout option was created mostly to save vertical space.) (file #10013) ___

[Freeciv-Dev] [bug #16440] Voteinfo bar is too long at the right of the screen

2010-08-24 Thread pepeto
Follow-up Comment #11, bug #16440 (project freeciv): I think that voteinfo_bar_new() should directly takes as argument bool split_bar instead of pregame, to don't confuse developpers using the options a bit everywhere. Done in the attachment. When merge isn't set and small display is, the

[Freeciv-Dev] [bug #16440] Voteinfo bar is too long at the right of the screen

2010-08-24 Thread pepeto
Follow-up Comment #12, bug #16440 (project freeciv): Changed my mind. Probably the vote bar should stay on the bottom of the window, not going to the right part. ___ Reply to this item at: http://gna.org/bugs/?16440

[Freeciv-Dev] [bug #16440] Voteinfo bar is too long at the right of the screen

2010-08-24 Thread Jacob Nevins
Follow-up Comment #13, bug #16440 (project freeciv): Sorry, not been able to look at this until now. When merge isn't set and small display is, the vote bar is not split, and it's still too long. Well, my patch improves it giving FALSE to parameter resize to gtk_paned_pack2(), then it

[Freeciv-Dev] [bug #16440] Voteinfo bar is too long at the right of the screen

2010-08-23 Thread pepeto
Follow-up Comment #10, bug #16440 (project freeciv): Two points: * I think that voteinfo_bar_new() should directly takes as argument bool split_bar instead of pregame, to don't confuse developpers using the options a bit everywhere. * When merge isn't set and small display is, the vote bar is

[Freeciv-Dev] [bug #16440] Voteinfo bar is too long at the right of the screen

2010-08-22 Thread Jacob Nevins
Follow-up Comment #8, bug #16440 (project freeciv): I've just realised that the display of the voteinfo bar in the pregame screen now depends on the in-game display options, which doesn't seem right. Since the pregame window defaults to being fairly small, the new split-line behaviour seems

[Freeciv-Dev] [bug #16440] Voteinfo bar is too long at the right of the screen

2010-08-22 Thread Jacob Nevins
Additional Item Attachment, bug #16440 (project freeciv): File name: S2_2-trunk-long-voteinfo-bar-is-long-extra2.diff Size:2 KB ___ Reply to this item at: http://gna.org/bugs/?16440 ___

[Freeciv-Dev] [bug #16440] Voteinfo bar is too long at the right of the screen

2010-08-21 Thread pepeto
Follow-up Comment #6, bug #16440 (project freeciv): Is this the right condition? I'd have thought you wanted to split the bar if Arrange widgets for small displays is set but Merge isn't set (because the chat window ends up taller and narrower) -- from your recent changes I'm guessing this

[Freeciv-Dev] [bug #16440] Voteinfo bar is too long at the right of the screen

2010-08-20 Thread Jacob Nevins
Follow-up Comment #5, bug #16440 (project freeciv): Bit late but: Is this the right condition? I'd have thought you wanted to split the bar if Arrange widgets for small displays is set but Merge isn't set (because the chat window ends up taller and narrower) -- from your recent changes I'm

[Freeciv-Dev] [bug #16440] Voteinfo bar is too long at the right of the screen

2010-08-17 Thread pepeto
Update of bug #16440 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #16440] Voteinfo bar is too long at the right of the screen

2010-08-15 Thread pepeto
Update of bug #16440 (project freeciv): Status:None = Ready For Test Assigned to:None = pepeto Planned Release: = 2.2.3, 2.3.0