Update of bug #16775 (project freeciv):
Status: Ready For Test = Fixed
Open/Closed:Open = Closed
___
Reply to this item at:
Follow-up Comment #9, bug #16775 (project freeciv):
Third patch attached:
* Removed the assertion at the end of get_defender(), as it is normal to
return NULL if no defender has been found.
* Removed COULD_OCCUPY macro, replaced by unit_can_take_over().
* Fixed a FIXME in server/unithand.c
*
Follow-up Comment #7, bug #16775 (project freeciv):
New patch attached which would solve this problem.
(file #10680)
___
Additional Item Attachment:
File name: trunk_get_defender2.diff Size:12 KB
Update of bug #16775 (project freeciv):
Status: In Progress = Ready For Test
___
Reply to this item at:
http://gna.org/bugs/?16775
___
Message posté
Follow-up Comment #8, bug #16775 (project freeciv):
--- server/unithand.c (revision 18197)
+++ server/unithand.c (working copy)
@@ -1409,7 +1409,9 @@
}
/* The attack is legal wrt the alliances */
-victim = get_defender(punit, pdesttile);
+if (is_attack_unit(punit)) {
+
Update of bug #16775 (project freeciv):
Status: Ready For Test = In Progress
Assigned to:None = pepeto
___
Reply to this item at:
Follow-up Comment #6, bug #16775 (project freeciv):
I got the following core dump after applying the patch; savegame attached. It
crashs in turn 306.
#0 0x7f5c8f5eb645 in raise () from /lib64/libc.so.6
No symbol table info available.
#1 0x0058513f in fc_assert_fail (file=0x5f7f18
Update of bug #16775 (project freeciv):
Category:None = ai
Status:None = Ready For Test
___
Follow-up Comment #5:
Fix attached. It
URL:
http://gna.org/bugs/?16775
Summary: lot of errors of type 'get_defender bug'
Project: Freeciv
Submitted by: syntron
Submitted on: Montag 27.09.2010 um 22:41
Category: None
Severity: 3 - Normal
Follow-up Comment #1, bug #16775 (project freeciv):
Probably. Do you use a special ruleset? Do you have a savegame to reproduce?
___
Reply to this item at:
http://gna.org/bugs/?16775
___
Follow-up Comment #2, bug #16775 (project freeciv):
to reproduce use the attached script (some techs are needed to get some
combats ...)
(file #10480)
___
Additional Item Attachment:
File name: defender.serv Size:0 KB
Follow-up Comment #3, bug #16775 (project freeciv):
This is my mistake. I tested the human possibility of the patch, but not the
AI. Attaching a patch to transform the error message in assertion. It would
help to investigate.
(file #10481)
12 matches
Mail list logo
