[Freeciv-Dev] [bug #16844] Base radius_sq fields are encoded as unsigned on network

2010-10-10 Thread Jacob Nevins

URL:
  http://gna.org/bugs/?16844

 Summary: Base radius_sq fields are encoded as unsigned on
network
 Project: Freeciv
Submitted by: jtn
Submitted on: Sunday 10/10/10 at 18:29
Category: general
Severity: 2 - Minor
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.3.0

___

Details:

In the definition of PACKET_RULESET_BASE, the fields border_sq,
vision_main_sq, and vision_invis_sq are defined as UINT8. However, the value
-1 is used in these fields to indicate that the effect doesn't apply to this
kind of base.

Thus, by the time these field values get to the client, they have most likely
been mangled to 255.

This currently has no effect on the client, but it's about to become
important for some documentation patches I'm writing.




___

Reply to this item at:

  http://gna.org/bugs/?16844

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #16844] Base radius_sq fields are encoded as unsigned on network

2010-10-10 Thread Jacob Nevins

Additional Item Attachment, bug #16844 (project freeciv):

File name: trunk-signed-base-radius-sq.diff Size:1 KB


___

Reply to this item at:

  http://gna.org/bugs/?16844

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev