[Freeciv-Dev] [bug #16847] Clean up list-generating pattern in help

[Jacob Nevins]

Update of bug #16847 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 
 Planned Release: => 2.3.0  


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16847] Clean up list-generating pattern in help

[Jacob Nevins]

Follow-up Comment #2, bug #16847 (project freeciv):

New patch attached which additionally removes the existing useless Q_() and
doesn't propagate the pattern further. (I checked the codebase and there
aren't any more.)

I agree about such a utility, so I've raised patch #2064, but I don't intend
to work on it right this minute.

(file #10800)
___

Additional Item Attachment:

File name: trunk-cleanup-list-generation-bis.diff Size:6 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16847] Clean up list-generating pattern in help

[pepeto]

Follow-up Comment #1, bug #16847 (project freeciv):

There are usage of Q_() in non qualifier strings. I maintain my comment in
patch #2056 about the need of a utility for doing string lists.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16847] Clean up list-generating pattern in help

[Jacob Nevins]

Additional Item Attachment, bug #16847 (project freeciv):

File name: trunk-cleanup-list-generation.diff Size:5 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16847] Clean up list-generating pattern in help

[Jacob Nevins]

URL:
  

 Summary: Clean up list-generating pattern in help
 Project: Freeciv
Submitted by: jtn
Submitted on: Sunday 10/10/10 at 20:01
Category: docs
Severity: 2 - Minor
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

There's a recurring pattern in the help of generating lists of one, two, or
more elements separated by "or" or "and". Some of them are a bit grody. While
working on patch #2049 I've incidentally harmonised some of them a bit,
removing some arbitrary limits in the process.

(There's definitely scope for factoring this out further; we could have a
couple of functions that take a strvec and format it into "and" and "or"
separated lists respectively; this could remove a chunk of code from these
and other places, such as helptext_government() and techs_with_flag_string(),
and centralise the handling of i18n issues. But that's more than I have time
for right now.)




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev