[Freeciv-Dev] [bug #16864] fix console output (handle_stdin_input_real())
Update of bug #16864 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?16864 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16864] fix console output (handle_stdin_input_real())
Update of bug #16864 (project freeciv): Operating System:None = Any Planned Release: 2.6.0 = 2.5.0, 2.6.0 ___ Follow-up Comment #10: Improved patch attached: only lines prefixed by '#' are considered as comments. The patch also applies against S2_4, but I guess it is safer to not commit it in that branch, because it may break some script compatibility. (file #21706) ___ Additional Item Attachment: File name: handle_stdin_input.patch Size:10 KB ___ Reply to this item at: http://gna.org/bugs/?16864 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16864] fix console output (handle_stdin_input_real())
Update of bug #16864 (project freeciv): Assigned to: syntron = pepeto Planned Release: 2.4.0 = 2.6.0 ___ Follow-up Comment #9: pepeto was the last one to touch this, and only one involved currently active. ___ Reply to this item at: http://gna.org/bugs/?16864 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16864] fix console output (handle_stdin_input_real())
Follow-up Comment #7, bug #16864 (project freeciv): I didn't see this, so in bug #19817 I proposed to stop # being a mandatory part of the /playercolor syntax (it's still accepted). I still don't see any reason to force people to enter a hash, so I think I'm going to stick with that, but the ideas for changing command parsing in this ticket may still be good. ___ Reply to this item at: http://gna.org/bugs/?16864 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16864] fix console output (handle_stdin_input_real())
Update of bug #16864 (project freeciv): Planned Release: 2.3.0 = 2.4.0 ___ Follow-up Comment #6: update target to freeciv 2.4.0 ___ Reply to this item at: http://gna.org/bugs/?16864 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16864] fix console output (handle_stdin_input_real())
Update of bug #16864 (project freeciv): Summary: cut_comment only for server scripts = fix console output (handle_stdin_input_real()) ___ Follow-up Comment #3: new version of the patch fix console output (handle_stdin_input_real()) * remove cut_comment(); comments are not allowed on the command line * cleanup removing of spaces; use remove_leading_trailing_spaces() * prevent '/ help' from beeing a valid command * fix write to the console if the command was issued from a client * remove allargs as it is identical to arg (file #10958) ___ Additional Item Attachment: File name: 20101028-trunk-fix-console-output-handle_stdin_input_real.patch Size:5 KB ___ Reply to this item at: http://gna.org/bugs/?16864 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] [bug #16864] fix console output (handle_stdin_input_real())
I have no access to gna at the moment. If this comment turns out to be relevant, someone should add it as comment to report. On 28 October 2010 15:38, Matthias Pfafferodt no-reply.invalid-addr...@gna.org wrote: Update of bug #16864 (project freeciv): * remove cut_comment(); comments are not allowed on the command line But are comments still allowed in scripts used by read command or as commandline parameter -r? They must be. - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] [bug #16864] fix console output (handle_stdin_input_real())
Le jeudi 28 octobre 2010 à 16:11 +0300, Marko Lindqvist a écrit : I have no access to gna at the moment. If this comment turns out to be relevant, someone should add it as comment to report. I don't understand the end... On 28 October 2010 15:38, Matthias Pfafferodt no-reply.invalid-addr...@gna.org wrote: Update of bug #16864 (project freeciv): * remove cut_comment(); comments are not allowed on the command line But are comments still allowed in scripts used by read command or as commandline parameter -r? They must be. Comments are still allowed but in whole line only, no appended to a command line. So: # Comment is allowed /list players # Comment is disallowed. The idea is to allow the character '#' in the command line, notably to treat colors in a format such as '#rrggbb'. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16864] fix console output (handle_stdin_input_real())
Follow-up Comment #4, bug #16864 (project freeciv): But are comments still allowed in scripts used by read command or as commandline parameter -r? They must be. As discussed in comment #1 only the possibility to add comments to commands from the command line should be removed. In scripts, comments should still be possible. As the original patch does not provide this, here is an updated version ... (Thanks for the reminder) test.serv: help #comment old behaviour: help #comment Welcome - this is the introductory help text for the Freeciv server. [...] read test 2: Loading script file: ./test.serv Welcome - this is the introductory help text for the Freeciv server. [...] new behaviour: help #comment No match for help argument '#comment'. read test 2: Loading script file: ./test.serv Welcome - this is the introductory help text for the Freeciv server. [...] (file #10963) ___ Additional Item Attachment: File name: 20101028-2-trunk-fix-console-output-handle_stdin_input_real.patch Size:4 KB ___ Reply to this item at: http://gna.org/bugs/?16864 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16864] fix console output (handle_stdin_input_real())
Follow-up Comment #5, bug #16864 (project freeciv): and now the correct file ... (file #10965) ___ Additional Item Attachment: File name: 20101028-3-trunk-fix-console-output-handle_stdin_input_real.patch Size:4 KB ___ Reply to this item at: http://gna.org/bugs/?16864 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
