[Freeciv-Dev] [bug #17049] in handle_player_diplstate() [packhand.c::1953]: assertion 'ds != ((void *)0)

2010-11-14 Thread Matthias Pfafferodt

Update of bug #17049 (project freeciv):

  Status:None = Ready For Test 
 Assigned to:None = syntron

___

Follow-up Comment #4:

Thanks for the savegame. Here is a bug fix:

create the player slot on the client as soon as possible

* if a player is split, send the information about the new player slot to all
connections as soon as possible. This ensures that the player slot is created
on the client(s). Thus, the diplomatic state is available.

But the savegame shows another problem. After the civil war the Sicilian
player gets knowledge about the new map, i.e. the teritorium of both nations
after the civil war.

(file #11217)
___

Additional Item Attachment:

File name:
20101114-trunk-create-the-player-slot-on-the-client-as-soon-as-poss.patch
Size:1 KB


___

Reply to this item at:

  http://gna.org/bugs/?17049

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #17049] in handle_player_diplstate() [packhand.c::1953]: assertion 'ds != ((void *)0)

2010-11-14 Thread pepeto

Follow-up Comment #5, bug #17049 (project freeciv):

You mean borders? The savegame was with foggedborders off.


___

Reply to this item at:

  http://gna.org/bugs/?17049

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #17049] in handle_player_diplstate() [packhand.c::1953]: assertion 'ds != ((void *)0)

2010-11-14 Thread Matthias Pfafferodt

Follow-up Comment #6, bug #17049 (project freeciv):

 You mean borders? The savegame was with foggedborders off. 

OK; then all is fine ;-)

___

Reply to this item at:

  http://gna.org/bugs/?17049

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #17049] in handle_player_diplstate() [packhand.c::1953]: assertion 'ds != ((void *)0)

2010-11-12 Thread pepeto

Follow-up Comment #3, bug #17049 (project freeciv):

You patch doesn't solve the problem. Attaching a savegame. You need to take
Derbent.


(file #11197)
___

Additional Item Attachment:

File name: civil_war.sav.bz2  Size:15 KB


___

Reply to this item at:

  http://gna.org/bugs/?17049

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #17049] in handle_player_diplstate() [packhand.c::1953]: assertion 'ds != ((void *)0)

2010-11-11 Thread Matthias Pfafferodt

Follow-up Comment #1, bug #17049 (project freeciv):

The initialisation of the second player on the client seems to be missing.
See also gna bug #16334. The data of the new player due to civil war should
be send as soon as possible. I will check this.

___

Reply to this item at:

  http://gna.org/bugs/?17049

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #17049] in handle_player_diplstate() [packhand.c::1953]: assertion 'ds != ((void *)0)

2010-11-11 Thread Matthias Pfafferodt

Follow-up Comment #2, bug #17049 (project freeciv):

I'm not sure that caused this. In civil_war() the player are updated directly
after the creation of the new civil war player. Thus, the client should know
about the new player ... Do you have a savegame?

(possible patch attached)

(file #11184)
___

Additional Item Attachment:

File name: 2010-trunk-fix-civil-war.patch Size:1 KB


___

Reply to this item at:

  http://gna.org/bugs/?17049

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #17049] in handle_player_diplstate() [packhand.c::1953]: assertion 'ds != ((void *)0)

2010-11-09 Thread pepeto

URL:
  http://gna.org/bugs/?17049

 Summary: in handle_player_diplstate() [packhand.c::1953]:
assertion 'ds != ((void *)0)
 Project: Freeciv
Submitted by: pepeto
Submitted on: mardi 09.11.2010 à 09:17
Category: client
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: trunk, S2_3
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.3.0

___

Details:

It occured at client side when a player was split by civil war.


0: in handle_player_diplstate() [packhand.c::1953]: assertion 'ds != ((void
*)0)' failed.
0: SVP, rapportez ce bogue à http://gna.org/projects/freeciv/

Program received signal SIGINT, Interrupt.
0x755d17bb in raise (sig=value optimised out)
at ../nptl/sysdeps/unix/sysv/linux/pt-raise.c:42
42  in ../nptl/sysdeps/unix/sysv/linux/pt-raise.c
(gdb) bt full
#0  0x755d17bb in raise (sig=value optimised out)
at ../nptl/sysdeps/unix/sysv/linux/pt-raise.c:42
No locals.
#1  0x0055e07f in fc_assert_fail (file=0x5be71f player.c, 
function=0x5bec30 player_diplstate_get, line=273, 
assertion=value optimised out, message=0x0) at log.c:476
level = LOG_FATAL
#2  0x0054c79e in player_diplstate_get (plr1=value optimised out, 
plr2=value optimised out) at player.c:273
__FUNCTION__ = player_diplstate_get
#3  0x0043bbbe in handle_player_diplstate (packet=0x4a11780)
at packhand.c:1950
plr1 = 0x4391550
plr2 = 0x0
my_player = 0x4391550
ds = value optimised out
__FUNCTION__ = handle_player_diplstate
#4  0x00441cf5 in client_handle_packet (type=value optimised out, 
packet=0x0) at packhand_gen.c:133
No locals.
#5  0x00417abe in client_packet_input (packet=value optimised out,

type=59) at client_main.c:565
__FUNCTION__ = client_packet_input
#6  0x0041d355 in input_from_server (fd=value optimised out)
at clinet.c:379
result = true
packet = 0x0
type = PACKET_PLAYER_DIPLSTATE
__FUNCTION__ = input_from_server
#7  0x74d18d3f in gdk_io_invoke (source=value optimised out, 
condition=value optimised out, data=value optimised out)
at /build/buildd/gtk+2.0-2.20.1/gdk/gdkevents.c:1082
closure = 0x43dadb0
gdk_cond = GDK_INPUT_READ
#8  0x72b348c2 in g_main_dispatch (context=0xb43160)
at /build/buildd/glib2.0-2.24.1/glib/gmain.c:1960
dispatch = 0x72b76e10 g_io_unix_dispatch
user_data = 0x43dadb0
callback = 0x74d18cf0 gdk_io_invoke
cb_funcs = 0x72dd2610
cb_data = 0x2374d40
current_source_link = {data = 0x18d6ee0, next = 0x0}
source = 0x18d6ee0
current = 0x1641900
i = 1
#9  IA__g_main_context_dispatch (context=0xb43160)
at /build/buildd/glib2.0-2.24.1/glib/gmain.c:2513
No locals.
#10 0x72b38748 in g_main_context_iterate (context=0xb43160, 
block=value optimised out, dispatch=value optimised out, 
self=value optimised out)
at /build/buildd/glib2.0-2.24.1/glib/gmain.c:2591
max_priority = 0
timeout = 0
some_ready = 1
nfds = 4
allocated_nfds = -223062448
fds = value optimised out
__PRETTY_FUNCTION__ = g_main_context_iterate
#11 0x72b38c55 in IA__g_main_loop_run (loop=0x1640390)
at /build/buildd/glib2.0-2.24.1/glib/gmain.c:2799
self = 0x9af090
__PRETTY_FUNCTION__ = IA__g_main_loop_run
#12 0x750dbbb7 in IA__gtk_main ()
at /build/buildd/gtk+2.0-2.20.1/gtk/gtkmain.c:1219
tmp_list = 0xb57900
functions = 0x0
init = 0xbba990
loop = value optimised out
#13 0x00416e5f in ui_main (argc=1, argv=0x7fffe328)
at gui_main.c:1637
home = value optimised out
sig = value optimised out
__FUNCTION__ = ui_main
#14 0x00417f3f in client_main (argc=value optimised out, 
argv=0x7fffe328) at client_main.c:509
i = 3
loglevel = LOG_NORMAL
ui_options = value optimised out
ui_separator = false
option = value optimised out
user_tileset = false
fatal_assertions = 2
__FUNCTION__ = client_main
#15 0x72791c4d in __libc_start_main (main=value optimised out, 
argc=value optimised out, ubp_av=value optimised out, 
init=value optimised out, fini=value optimised out, 
rtld_fini=value optimised out, stack_end=0x7fffe318)
at libc-start.c:226
result = value optimised out
unwind_buf = {cancel_jmp_buf = {{jmp_buf = {0, -6661889963760425205,

4272320, 140737488347936, 0, 0, 6661889963077003019,