[Freeciv-Dev] [bug #17095] Freeland: match_with has too many types (5, max 3)
Update of bug #17095 (project freeciv): Planned Release:2.3.0, 2.4.0 = 2.2.6, 2.3.0, 2.4.0 ___ Reply to this item at: http://gna.org/bugs/?17095 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17095] Freeland: match_with has too many types (5, max 3)
Update of bug #17095 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed Operating System:None = Any ___ Reply to this item at: http://gna.org/bugs/?17095 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17095] Freeland: match_with has too many types (5, max 3)
Update of bug #17095 (project freeciv): Category:None = general Status:None = Ready For Test Assigned to:None = jtn ___ Follow-up Comment #4: Our patches seem broadly equivalent, so I plan to commit mine. (Mine sets a higher limit of 9 as opposed to 6. In tileset_setup_tile_type(), there is a loop that can increase with the cube of this limit, but only if the tileset actually reaches that limit, so it shouldn't make any difference for Freeland.) ___ Reply to this item at: http://gna.org/bugs/?17095 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17095] Freeland: match_with has too many types (5, max 3)
Update of bug #17095 (project freeciv): Planned Release: = 2.3.0, 2.4.0 ___ Reply to this item at: http://gna.org/bugs/?17095 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17095] Freeland: match_with has too many types (5, max 3)
Follow-up Comment #3, bug #17095 (project freeciv): In attachment my last patches that resolve this bug on freeciv 2.2.x/2.3.x (file #12658, file #12659) ___ Additional Item Attachment: File name: freeciv-2.2.x.diff Size:1 KB File name: freeciv-2.3.x.diff Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?17095 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17095] Freeland: match_with has too many types (5, max 3)
Follow-up Comment #1, bug #17095 (project freeciv): It seems Peter has been distributing a patch with Freeland 3 for Freeciv 2.2.x, without which it apparently doesn't work: see the forum http://forum.freeciv.org/viewtopic.php?t=1648postdays=0postorder=ascstart=60#25290. It's unfortunate that a patch is required, as it will mean that many people can't use Freeland. Looking at the patch, it lifts the restriction on the number of match_types (%s.layer%d_match_with), and would make this warning go away. As far as I can tell, the restriction on the number of match types to MATCH_FULL+1 is completely arbitrary. It looks like it used to be that you specified an explicit match_style in the tileset, but now it's implicit in the number of match_types you specify, with MATCH_FULL being the one you get for more than two; but as far as I can it doesn't follow that the numeric number of types should be tied to the value of MATCH_FULL, an internal enumeration. As long as we have arrays in this data structure there will be an arbitrary limit, but we could lift it to (say) 8 (with a new name for this limit). However, my understand of the tileset format is murky at best, so I'd like a second opinion from someone who understands tilesets a bit better... ___ Reply to this item at: http://gna.org/bugs/?17095 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17095] Freeland: match_with has too many types (5, max 3)
Follow-up Comment #2, bug #17095 (project freeciv): Attached a cleaned-up version of Peter's patch. With it, I can load Freeland 3.0.0 alpha2 in S2_2 (not tried updating it to S2_3). Anyone know of a good reason not to commit this? (file #12656, file #12657) ___ Additional Item Attachment: File name: trunk-S2_3-increase-match-with.diff Size:1 KB File name: S2_2-increase-match-with.diff Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?17095 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17095] Freeland: match_with has too many types (5, max 3)
URL: http://gna.org/bugs/?17095 Summary: Freeland: match_with has too many types (5, max 3) Project: Freeciv Submitted by: dmarks Submitted on: Wednesday 11/17/2010 at 14:28 Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: S2_3 Discussion Lock: Any Operating System: None Planned Release: ___ Details: Loading Freeland (smallest size) tileset in 2.3 causes the following warnings. Using this work-in-progress test version I pieced together using the 3.0-alpha version the author released a couple of years ago. http://download.gna.org/freeciv/incoming/freeland-2.2.99-debug.tar.gz rdmarkst...@gaslight:~/fc/22$ ./client/freeciv-gtk2 --tiles=freeland 1: [tile_grassland] match_with has too many types (5, max 3) 1: [tile_plains] match_with has too many types (5, max 3) 1: [tile_desert] match_with has too many types (5, max 3) 1: [tile_tundra] match_with has too many types (5, max 3) 1: [tile_arctic] match_with has too many types (5, max 3) 1: [tile_coast] match_with has too many types (5, max 3) 1: [tile_floor] match_with has too many types (5, max 3) 1: [tile_swamp] match_with has too many types (5, max 3) 1: [tile_jungle] match_with has too many types (5, max 3) 1: [tile_forest] match_with has too many types (5, max 3) 1: [tile_hills] match_with has too many types (5, max 3) 1: [tile_mountains] match_with has too many types (5, max 3) 1: [tile_grassland] match_with has too many types (5, max 3) 1: [tile_plains] match_with has too many types (5, max 3) 1: [tile_desert] match_with has too many types (5, max 3) 1: [tile_tundra] match_with has too many types (5, max 3) 1: [tile_arctic] match_with has too many types (5, max 3) 1: [tile_coast] match_with has too many types (5, max 3) 1: [tile_swamp] match_with has too many types (5, max 3) 1: [tile_jungle] match_with has too many types (5, max 3) 1: [tile_forest] match_with has too many types (5, max 3) 1: [tile_hills] match_with has too many types (5, max 3) 1: [tile_mountains] match_with has too many types (5, max 3) 1: [tile_grassland] match_with has too many types (5, max 3) 1: [tile_plains] match_with has too many types (5, max 3) 1: [tile_desert] match_with has too many types (5, max 3) 1: [tile_tundra] match_with has too many types (5, max 3) 1: [tile_arctic] match_with has too many types (5, max 3) 1: [tile_coast] match_with has too many types (5, max 3) 1: [tile_swamp] match_with has too many types (5, max 3) 1: [tile_jungle] match_with has too many types (5, max 3) 1: [tile_forest] match_with has too many types (5, max 3) 1: [tile_hills] match_with has too many types (5, max 3) 1: [tile_mountains] match_with has too many types (5, max 3) 1: [tile_grassland] match_with has too many types (5, max 3) 1: [tile_plains] match_with has too many types (5, max 3) 1: [tile_desert] match_with has too many types (5, max 3) 1: [tile_tundra] match_with has too many types (5, max 3) 1: [tile_arctic] match_with has too many types (5, max 3) 1: [tile_coast] match_with has too many types (5, max 3) 1: [tile_floor] match_with has too many types (5, max 3) 1: [tile_swamp] match_with has too many types (5, max 3) 1: [tile_jungle] match_with has too many types (5, max 3) 1: [tile_forest] match_with has too many types (5, max 3) 1: [tile_hills] match_with has too many types (5, max 3) 1: [tile_mountains] match_with has too many types (5, max 3) ___ Reply to this item at: http://gna.org/bugs/?17095 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev