[Freeciv-Dev] [bug #17953] Restrict climate change (global warming / nuclear winter) land<->sea terrain changes to coastlines

[Jacob Nevins]

Update of bug #17953 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17953] Restrict climate change (global warming / nuclear winter) land<->sea terrain changes to coastlines

[Jacob Nevins]

Follow-up Comment #2, bug #17953 (project freeciv):

The attached animations demonstrate the difference in behaviour. Generated
with the following server settings:

mapimg define turns=1:zoom=1:map=tcub:show=all
set autosaves ""
set topology WRAPX
set gameseed 1302037152
set mapseed 1538399225


and patch #2624 and the following addition to data/default/script.lua:

function per_turn(turn, year)
  if (turn ~= 0) then
climate_change(GLOBAL_WARMING, 50)
  end
  return false
end

signal.connect("turn_started", "per_turn")


(file #12800, file #12801, file #12802, file #12803)
___

Additional Item Attachment:

File name: oldgw.gif  Size:54 KB
File name: oldnw.gif  Size:86 KB
File name: newgw.gif  Size:63 KB
File name: newnw.gif  Size:86 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17953] Restrict climate change (global warming / nuclear winter) land<->sea terrain changes to coastlines

[Jacob Nevins]

Update of bug #17953 (project freeciv):

  Status:   Need Info => Ready For Test 
 Assigned to:None => jtn
 Release: => 2.3.0-beta4
 Planned Release: => 2.3.0,2.4.0
 Summary: Should global catasrophe (global warming / nuclear
winter) land<->sea terrain changes check surrounding terrain? => Restrict
climate change (global warming / nuclear winter) land<->sea terrain changes to
coastlines

___

Follow-up Comment #1:

> However, this process takes no account of the surrounding terrain
This wasn't entirely fair; with the current rulesets, land->sea changes only
happen if there's ocean/lake or a river nearby. The problem was worse with
nuclear winter, with glacier tiles appearing randomly in the middle of the
sea.

Anyway, fixing this turns out to be trivially easy.

While I was in there, I fixed a pre-existing minor problem (that would have
been exacerbated by this change): if a change is blocked due to tile
conditions (e.g., a city tile can't be changed to a glacier per bug #15258),
that tile was immune to change -- a city on grassland near the coast would
stay on grassland indefinitely rather than fall in the sea
(warmer_wetter_result). Now, the alternative transformation
(warmer_drier_result) is enacted instead.

(file #12799)
___

Additional Item Attachment:

File name: trunk-S2_3-climate-change-coastlines.diff Size:3 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev