[Freeciv-Dev] [bug #18095] 'ai-phase_is_initialized' assertion failure

2011-06-03 Thread Marko Lindqvist

Follow-up Comment #5, bug #18095 (project freeciv):

For the record: I cannot reproduce in TRUNK. Related functionality has been
moved around a bit there, so the call to ai_data_get() is probably correctly
within ai_data_phase_init() and ai_data_phase_done() boundaries.

I'll see if there is easy (and non-invasive) fix for S2_3.

___

Reply to this item at:

  http://gna.org/bugs/?18095

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #18095] 'ai-phase_is_initialized' assertion failure

2011-06-03 Thread Marko Lindqvist

Update of bug #18095 (project freeciv):

  Status:None = Ready For Test 

___

Follow-up Comment #6:

I'll propose attached patch for S2_3 ('S' as stable) only. It removes the
assert and minimizes bad effects of such calls that have been triggering the
assert.

Note that this assert was added only recently. For years we have been
releasing stable releases with a lot of bugs that would have triggered it. In
S2_3 we at least have a lot less those than before even if some remain.

(file #13087)
___

Additional Item Attachment:

File name: DataPhaseKludge_18095.diff Size:1 KB


___

Reply to this item at:

  http://gna.org/bugs/?18095

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #18095] 'ai-phase_is_initialized' assertion failure

2011-06-03 Thread Marko Lindqvist

Follow-up Comment #7, bug #18095 (project freeciv):

 minimizes bad effects of such calls that have been triggering
 the assert.

I wonder if similar patch should be created even for S2_2?

___

Reply to this item at:

  http://gna.org/bugs/?18095

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #18095] 'ai-phase_is_initialized' assertion failure

2011-06-03 Thread Marko Lindqvist

Follow-up Comment #8, bug #18095 (project freeciv):

- Calculate new data in any case, so we return more sensible data even to
those illegal callers.

(file #13088)
___

Additional Item Attachment:

File name: DataPhaseKludge_18095-2.diff   Size:1 KB


___

Reply to this item at:

  http://gna.org/bugs/?18095

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #18095] 'ai-phase_is_initialized' assertion failure

2011-05-17 Thread Jacob Nevins

Update of bug #18095 (project freeciv):

 Release: 2.3.0 beta3 = 2.3.0-beta4


___

Reply to this item at:

  http://gna.org/bugs/?18095

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #18095] 'ai-phase_is_initialized' assertion failure

2011-05-17 Thread Jacob Nevins

Update of bug #18095 (project freeciv):

 Planned Release: = 2.3.0  

___

Follow-up Comment #3:

Reproduced with latest S2_3 (r19631, post beta4). Server backtrace:


#0  0x7f610b6b6a75 in *__GI_raise (sig=value optimised out)
at ../nptl/sysdeps/unix/sysv/linux/raise.c:64
pid = value optimised out
selftid = value optimised out
#1  0x0058578f in fc_assert_fail (file=0x5d03d6 advdata.c,
function=0x5d05f1 ai_data_get, line=786,
assertion=value optimised out, message=0x0) at log.c:476
level = LOG_FATAL
#2  0x0044d39e in ai_data_get (pplayer=0x2aa4210) at advdata.c:786
ai = 0x2a83bd0
__FUNCTION__ = ai_data_get
#3  0x0044d3d7 in ai_channel (pplayer=0x464e, c1=17998, c2=6)
at advdata.c:907
ai = 0x6
#4  0x00447a04 in goto_is_sane (punit=0x2aa40e0, ptile=0x2c8d218,
omni=false) at aitools.c:505
pplayer = 0x2aa4210
pcity = 0x0
my_cont = 6
target_cont = 17998
__FUNCTION__ = goto_is_sane
#5  0x00447d3d in ai_unit_goto_constrained (punit=0x2aa40e0,
ptile=0x2c8d218, parameter=0x7fff206743a0) at aitools.c:414
alive = value optimised out
pfm = value optimised out
path = value optimised out
__FUNCTION__ = ai_unit_goto_constrained
#6  0x00452376 in explorer_goto (punit=0x2aa40e0) at
autoexplorer.c:129
parameter = {start_tile = 0x2c8acf8, moves_left_initially = 9,
  fuel_left_initially = 1, move_rate = 9, fuel = 1, owner =
0x2aa4210, 
  uclass = 0xa4f210, unit_flags = {vec =  00 00  00b 00 00}, 
  omniscience = false, get_MC = 0x59b5e0 sea_overlap_move, 
  unknown_MC = 6, get_TB = 0x4519f0 explorer_tb, get_EC = 0, 
  can_invade_tile = 0x574b30 player_can_invade_tile, get_zoc = 0, 
  is_pos_dangerous = 0, get_moves_left_req = 0, get_costs = 0, 
  data = 0x2ad3fd0}
risk_cost = {base_value = 0, fearfulness = 2.5608054827978485e-317, 
  enemy_zoc_cost = 0}
#7  manage_auto_explorer (punit=0x2aa40e0) at autoexplorer.c:366
pplayer = 0x2aa4210
init_tile = 0x2c8acf8
log_most_desirable = 9.7503363730419537
max_dist = 6
best_tile = 0x2c8d218
best_MC = 3
pfm = 0x2aaee20
parameter = {start_tile = 0x2c8acf8, moves_left_initially = 9, 
  fuel_left_initially = 1, move_rate = 9, fuel = 1, owner =
0x2aa4210, 
  uclass = 0xa4f210, unit_flags = {vec =  00 00  00b 00 00}, 
  omniscience = false, get_MC = 0x59b870 seamove_no_bombard, 
  unknown_MC = 6, get_TB = 0x59ac60 no_fights_or_unknown, 
  get_EC = 0, can_invade_tile = 0x574b30 player_can_invade_tile, 
  get_zoc = 0, is_pos_dangerous = 0, get_moves_left_req = 0, 
  get_costs = 0, data = 0x2aa40e0}
__FUNCTION__ = manage_auto_explorer
#8  0x0041d7e9 in do_explore (punit=0x464e) at unittools.c:2288
No locals.
#9  0x0041e9a4 in update_unit_activity (pplayer=value optimised
out)
at unittools.c:720
id = 171
activity = ACTIVITY_IDLE
ptile = 0x2c8acf8
check_adjacent_units = true
#10 update_unit_activities (pplayer=value optimised out) at
unittools.c:516
punit = 0x2aa40e0
punit_index = 0
punit_size = value optimised out
__FUNCTION__ = update_unit_activities
#11 0x0040d069 in begin_phase () at srv_main.c:892
MY_i = 52
pplayer = 0x2aa4210
#12 srv_running () at srv_main.c:2114
save_counter = 1
is_new_turn = true
eot_timer = 0x2960b60
need_send_pending_events = false
#13 srv_main () at srv_main.c:2551
__FUNCTION__ = srv_main
#14 0x00404137 in main (argc=value optimised out, 
argv=0x7fff20674778) at civserver.c:375
inx = 4
showhelp = false
showvers = false
option = 0x22c0950 240213+ 02
__FUNCTION__ = main


___

Reply to this item at:

  http://gna.org/bugs/?18095

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #18095] 'ai-phase_is_initialized' assertion failure

2011-05-17 Thread Jacob Nevins

Follow-up Comment #4, bug #18095 (project freeciv):

(The assertion fails every time I hit Turn Done, so it's unlike the previous
problem which occurred on loading a savegame.)

___

Reply to this item at:

  http://gna.org/bugs/?18095

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #18095] 'ai-phase_is_initialized' assertion failure

2011-05-16 Thread Angelo Locritani

Follow-up Comment #2, bug #18095 (project freeciv):

sorry, my mistake. the version is 2.3.0-beta4, not beta3

___

Reply to this item at:

  http://gna.org/bugs/?18095

___
  Messaggio inviato con/da Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #18095] 'ai-phase_is_initialized' assertion failure

2011-05-08 Thread Jacob Nevins

Follow-up Comment #1, bug #18095 (project freeciv):

 it seems that bug #17728 is not yet solved...
You've reported this against 2.3.0-beta3... bug #17728 (or rather bug #17699)
was still at large in that version. It should be fixed in beta4.

___

Reply to this item at:

  http://gna.org/bugs/?18095

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #18095] 'ai-phase_is_initialized' assertion failure

2011-05-01 Thread Angelo Locritani

URL:
  http://gna.org/bugs/?18095

 Summary: 'ai-phase_is_initialized' assertion failure
 Project: Freeciv
Submitted by: alocritani
Submitted on: dom 01 mag 2011 08:57:16 GMT
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.3.0 beta3
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

it seems that bug #17728 is not yet solved...

Load the attached savegame
select the trireme in athina and give the autoexplore command to it
as the new turn starts I always receive the following assertion failure:
in ai_data_get() [advdata.c::786]: assertion ai-phase_is_initialized'
failed.



___

File Attachments:


---
Date: dom 01 mag 2011 08:57:16 GMT  Name: assertion_failed.sav.gz  Size: 33kB
  By: alocritani

http://gna.org/bugs/download.php?file_id=12940

___

Reply to this item at:

  http://gna.org/bugs/?18095

___
  Messaggio inviato con/da Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev