[Freeciv-Dev] [bug #18339] Typo in signal name

[Marko Lindqvist]

Update of bug #18339 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18339] Typo in signal name

[Marko Lindqvist]

Update of bug #18339 (project freeciv):

 Planned Release: 2.2.8, 2.3.0, 2.4.0 => 2.4.0  


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18339] Typo in signal name

[Marko Lindqvist]

Follow-up Comment #4, bug #18339 (project freeciv):

So I guess those work.

But I still think that we should change them in trunk:
1) Someone checking if freeciv uses certain signal by grepping signal name as
given in gtk-documentation
2) Consistency


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18339] Typo in signal name

[Jacob Nevins]

Follow-up Comment #3, bug #18339 (project freeciv):

The book "Foundations of GTK+ Development" from 2007, chapter 2, p28 (found
on Google
)
claims:

"When typing the signal name, the underscore and dash characters are
interchangeable. They will be parsed as the same character, so it does not
make any difference which one you choose."

I haven't found anything in the Gtk/Glib reference stating this, though, so I
don't know whether it applies to all versions and all signals.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18339] Typo in signal name

[Marko Lindqvist]

Follow-up Comment #2, bug #18339 (project freeciv):

I've found several other signal names written similar way with underscore. I
have to check gtk+/glib documentation to see if it actually accepts these
signal names where "-" -> "_" If it does, this ticket will turn from bugfix in
to cleanup (consistency)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18339] Typo in signal name

[Jacob Nevins]

Follow-up Comment #1, bug #18339 (project freeciv):

I randomly hoped this might have some bearing on bug #17805, but it makes no
difference to the behaviour.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18339] Typo in signal name

[Marko Lindqvist]

URL:
  

 Summary: Typo in signal name
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 12 Jul 2011 08:38:04 PM EEST
Category: client-gtk-2.0
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.2.8, 2.3.0, 2.4.0

___

Details:

Name of the "switch-page" signal has typo when setting handler for it,
presumably leading to some kind of theming bug.

Fix attached. Trunk version makes same change to gtk3-client just to keep
client synchronized. This is not really correct fix for gtk3-client as it
still depends on deprecated stuff.c




___

File Attachments:


---
Date: Tue 12 Jul 2011 08:38:04 PM EEST  Name: GtkSwitchPageSignal.diff  Size:
1kB   By: cazfi


---
Date: Tue 12 Jul 2011 08:38:04 PM EEST  Name: GtkSwitchPageSignal-S2_3.diff 
Size: 567B   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev