[Freeciv-Dev] [bug #18880] assertion 'adv-phase_is_initialized' failed.

2014-04-06 Thread Marko Lindqvist
Update of bug #18880 (project freeciv):

 Planned Release:   2.4.0 = 2.4.0, 2.5.0   


___

Reply to this item at:

  http://gna.org/bugs/?18880

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #18880] assertion 'adv-phase_is_initialized' failed.

2011-11-08 Thread Matthias Pfafferodt

Update of bug #18880 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 
 Planned Release:   2.3.1?, 2.4.0 = 2.4.0  

___

Follow-up Comment #7:

Patched applied to S2_4 and trunk - S2_3 could be follow if needed (2.3.2?)

___

Reply to this item at:

  http://gna.org/bugs/?18880

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #18880] assertion 'adv-phase_is_initialized' failed.

2011-11-05 Thread Jacob Nevins

Update of bug #18880 (project freeciv):

 Planned Release:   2.4.0, 2.3.1? = 2.3.1?, 2.4.0  

___

Follow-up Comment #2:

On S2_3 (r20455), if I reinstate the assertion compiled out in bug #18095, I
see these assertion failures in this reproduction case. So it seems like a
good idea to fix this for 2.3.1, if possible.

___

Reply to this item at:

  http://gna.org/bugs/?18880

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #18880] assertion 'adv-phase_is_initialized' failed.

2011-11-05 Thread Marko Lindqvist

Follow-up Comment #3, bug #18880 (project freeciv):

 if I reinstate the assertion compiled out in bug #18095, I see
 these assertion failures in this reproduction case. So it seems
 like a good idea to fix this for 2.3.1, if possible.

Please note that same commit that removed the assert from S2_3 also added
some emergency code for the cases where it used to trigger. In practice S2_3
already does same recalculations as this patch, just in a bit different time
(it may actually get more correct data as it's refreshed just when needed...)
While this patch fixes real bug, these ai/adv data sequences are error-prone
so that I'd rather not touch them in stable branch without good reason.

___

Reply to this item at:

  http://gna.org/bugs/?18880

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #18880] assertion 'adv-phase_is_initialized' failed.

2011-11-05 Thread Jacob Nevins

Follow-up Comment #4, bug #18880 (project freeciv):

Mm, OK. There are things that that workaround doesn't patch up, in particular
pointers from ai_data (see bug #18796); but if you're happy that this case is
unlikely to hit anything like that, perhaps it's better to leave S2_3 alone.

___

Reply to this item at:

  http://gna.org/bugs/?18880

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #18880] assertion 'adv-phase_is_initialized' failed.

2011-10-29 Thread Matthias Pfafferodt

URL:
  http://gna.org/bugs/?18880

 Summary: assertion 'adv-phase_is_initialized' failed.
 Project: Freeciv
Submitted by: syntron
Submitted on: Sa 29 Okt 2011 13:56:47 CEST
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: svn20352
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.4.0

___

Details:

If you make contact to another nation on your start position the following
assert fails:

1: in adv_data_get() [advdata.c::590]: assertion 'adv-phase_is_initialized'
failed.
2: Backtrace:
2: 0:
/mnt/data/sdc6/matthias/git/freeciv.git/common/.libs/libfreeciv.so.0(+0xf2e7d)
[0x7f9f1f45ee7d]
2: 1:
/mnt/data/sdc6/matthias/git/freeciv.git/common/.libs/libfreeciv.so.0(vdo_log+0xad)
[0x7f9f1f4654ad]
2: 2:
/mnt/data/sdc6/matthias/git/freeciv.git/common/.libs/libfreeciv.so.0(do_log+0x7f)
[0x7f9f1f46559f]
2: 3:
/mnt/data/sdc6/matthias/git/freeciv.git/common/.libs/libfreeciv.so.0(fc_assert_fail+0x9b)
[0x7f9f1f4657db]
2: 4:
/mnt/data/sdc6/matthias/git/freeciv.git/server/.libs/libfreeciv-srv.so.0(adv_data_get+0x9e)
[0x7f9f1fdeb63e]
2: 5:
/mnt/data/sdc6/matthias/git/freeciv.git/server/.libs/libfreeciv-srv.so.0(dai_data_phase_begin+0x40)
[0x7f9f1fdc4790]
2: 6:
/mnt/data/sdc6/matthias/git/freeciv.git/server/.libs/libfreeciv-srv.so.0(ai_plr_data_get+0x47)
[0x7f9f1fdc5497]
2: 7:
/mnt/data/sdc6/matthias/git/freeciv.git/server/.libs/libfreeciv-srv.so.0(+0xef60b)
[0x7f9f1fdb860b]
2: 8:
/mnt/data/sdc6/matthias/git/freeciv.git/server/.libs/libfreeciv-srv.so.0(dai_treaty_evaluate+0xe1)
[0x7f9f1fdb9b11]
2: 9:
/mnt/data/sdc6/matthias/git/freeciv.git/server/.libs/libfreeciv-srv.so.0(handle_diplomacy_create_clause_req+0x102)
[0x7f9f1fd18312]
2:10:
/mnt/data/sdc6/matthias/git/freeciv.git/server/.libs/libfreeciv-srv.so.0(make_contact+0x28e)
[0x7f9f1fd329de]
2:11:
/mnt/data/sdc6/matthias/git/freeciv.git/server/.libs/libfreeciv-srv.so.0(maybe_make_contact+0x2fd)
[0x7f9f1fd32e1d]
2:12:
/mnt/data/sdc6/matthias/git/freeciv.git/server/.libs/libfreeciv-srv.so.0(create_unit_full+0x12e)
[0x7f9f1fdab8ce]
2:13:
/mnt/data/sdc6/matthias/git/freeciv.git/server/.libs/libfreeciv-srv.so.0(create_unit+0x19)
[0x7f9f1fdaba39]
2:14:
/mnt/data/sdc6/matthias/git/freeciv.git/server/.libs/libfreeciv-srv.so.0(+0x58a42)
[0x7f9f1fd21a42]
2:15:
/mnt/data/sdc6/matthias/git/freeciv.git/server/.libs/libfreeciv-srv.so.0(init_new_game+0xae9)
[0x7f9f1fd225a9]
2:16:
/mnt/data/sdc6/matthias/git/freeciv.git/server/.libs/libfreeciv-srv.so.0(srv_main+0x297f)
[0x7f9f1fd8e69f]
2:17:
/mnt/data/sdc6/matthias/git/freeciv.git/server/.libs/freeciv-server()
[0x4053c8]
2:18: /lib64/libc.so.6(__libc_start_main+0xfd) [0x7f9f1afa5b7d]
2:19:
/mnt/data/sdc6/matthias/git/freeciv.git/server/.libs/freeciv-server()
[0x404979]

Steps to reproduce:

set size 2
set aifill 120
start

Possible solution:
- on creation of a nation initialise the advisor - adv_data_phase_init()
- after _all_ nations are created deinitialise it - adv_data_phase_done()




___

Reply to this item at:

  http://gna.org/bugs/?18880

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #18880] assertion 'adv-phase_is_initialized' failed.

2011-10-29 Thread Matthias Pfafferodt

Update of bug #18880 (project freeciv):

  Status:None = Ready For Test 
 Assigned to:None = syntron

___

Follow-up Comment #1:

add patch - advisor and ai phases must be started for contacts at this point

(file #14314)
___

Additional Item Attachment:

File name: 0005-fix-missing-advisor-if-contact-on-placing-the-first-.patch
Size:1 KB


___

Reply to this item at:

  http://gna.org/bugs/?18880

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #18880] assertion 'adv-phase_is_initialized' failed.

2011-10-29 Thread Matthias Pfafferodt

Update of bug #18880 (project freeciv):

 Planned Release:   2.4.0 = 2.4.0, 2.3.1?  


___

Reply to this item at:

  http://gna.org/bugs/?18880

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev