[Freeciv-Dev] [bug #19398] Packet creation overflow checks broken

2012-02-04 Thread Jacob Nevins 
Update of bug #19398 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 

___

Follow-up Comment #3:

(Committed to trunk as
[http://svn.gna.org/viewcvs/freeciv?view=revisionrevision=20798 r20798.)

___

Reply to this item at:

  http://gna.org/bugs/?19398

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19398] Packet creation overflow checks broken

2012-02-02 Thread Jacob Nevins 
URL:
  http://gna.org/bugs/?19398

 Summary: Packet creation overflow checks broken
 Project: Freeciv
Submitted by: jtn
Submitted on: Fri Feb  3 02:33:21 2012
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: In Progress
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Release: 2.2.7,2.3.1
 Discussion Lock: Any
Operating System: Any
 Planned Release: 2.3.2,2.4.0,2.5.0

___

Details:

As pointed out in bug #19241, enough_space() in dataio.c has a bogus check for
packet overflow when creating a packet which will never fire.

The attached patch fixes this and also adds an assertion to most packet
transmissions that too_short isn't set, to help diagnose bugs like bug #19241
in future.




___

Reply to this item at:

  http://gna.org/bugs/?19398

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19398] Packet creation overflow checks broken

2012-02-02 Thread Jacob Nevins 
Update of bug #19398 (project freeciv):

  Status: In Progress = Ready For Test 


___

Reply to this item at:

  http://gna.org/bugs/?19398

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev