[Freeciv-Dev] [bug #19802] Start position goodness calculation tries to use road compatibility specials
Update of bug #19802 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?19802 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19802] Start position goodness calculation tries to use road compatibility specials
Update of bug #19802 (project freeciv): Status: In Progress = Ready For Test ___ Follow-up Comment #2: Here's a patch that works sanely with standard rulesets. I'm not particularly happy with how I ended designing algorithms so that they produce expected result for given rulesets instead of designing them to work generally correctly. As player to be assigned to the starting position is decided only later, I couldn't pass player information to requirement checking - player related requirements, such as technology level (Railroad) are not checked - RPT_POSSIBLE would say that Railroads are available (from the beginning) - I had to use RPT_CERTAIN - As Road has UnitFlag Settlers requirement, I have to pass unit type that will suffice for RPT_CERTAIN to consider Roads possible. (file #15844) ___ Additional Item Attachment: File name: MapGenRoads-2.diff Size:5 KB ___ Reply to this item at: http://gna.org/bugs/?19802 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19802] Start position goodness calculation tries to use road compatibility specials
Update of bug #19802 (project freeciv): Status: Ready For Test = In Progress ___ Follow-up Comment #1: Passing NULL unit type to road requirement check means that very typical requirement of unit type flag Settlers results in unfulfilled requirements. This in turn means that startposition evaluation does not consider benefits of any roads for any tiles. ___ Reply to this item at: http://gna.org/bugs/?19802 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19802] Start position goodness calculation tries to use road compatibility specials
URL: http://gna.org/bugs/?19802 Summary: Start position goodness calculation tries to use road compatibility specials Project: Freeciv Submitted by: cazfi Submitted on: Wed 13 Jun 2012 03:00:26 AM EEST Category: general Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.5.0 ___ Details: When calculating start position score, and trying to check what tile would produce with road in it, S_ROAD special is set. This no longer has any effect at all (until game is saved and loaded again so that savegame backward compatibility loading code kicks in) Attached fix sets correct road types, even multiple ones if applicaple, instead. ___ File Attachments: --- Date: Wed 13 Jun 2012 03:00:26 AM EEST Name: MapGenRoads.diff Size: 2kB By: cazfi http://gna.org/bugs/download.php?file_id=15815 ___ Reply to this item at: http://gna.org/bugs/?19802 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
