URL:
<http://gna.org/bugs/?19984>
Summary: Client's limited knowledged used when displaying
military unhappiness caused by unit
Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 26 Jul 2012 11:33:20 AM EEST
Category: client
Severity: 3 - Normal
Priority: 5 - Normal
Status: None
Assigned to: None
Originator Email:
Open/Closed: Open
Release:
Discussion Lock: Any
Operating System: None
Planned Release:
_______________________________________________________
Details:
Client can display completely bogus information about military unhappiness
caused by units, since it tries to determine it itself with its limited
knowledge. I have not checked all clients carefully, but from quick grepping
it seems that broken code exist in all of them.
gtk3-client:
city_dialog_update_supported_units():
1. It gets value of effect EFT_MAKE_CONTENT_MIL to decide how many units get
free upkeep. Client may end up displaying wrong number of units free of
happiness upkeep
2. It calls city_unit_unhappiness() for each unit, which for units in fortress
ends up checking if there's friendly city nearby. There could be allied city
near that player does not know about (it would make sense that unknown cities
would not lift unhappiness, but as server side does not work that way, client
ends showing wrong information)
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?19984>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
