[Freeciv-Dev] [bug #20452] Unit can convert in bad circumstances

2013-01-28 Thread Marko Lindqvist 
Update of bug #20452 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20452] Unit can convert in bad circumstances

2013-01-24 Thread Marko Lindqvist 
Follow-up Comment #1, bug #20452 (project freeciv):

- Check that conversion or upgrade target unit type can transport type of
cargo unit currently holds.

(file #17014, file #17015)
___

Additional Item Attachment:

File name: UnitTransformChecks.patch  Size:1 KB
File name: UnitTransformChecks-S2_3.patch Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20452] Unit can convert in bad circumstances

2013-01-23 Thread Marko Lindqvist 
URL:
  

 Summary: Unit can convert in bad circumstances
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 24 Jan 2013 01:39:46 AM EET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.3.4, 2.4.0, 2.5.0

___

Details:

Unit can be converted to another type even when
1) target unit cannot exist in the tile
2) target unit has not enough space for the cargo

Fix for these attached.


This makes cargo space check equivalent to what's being done in case of unit
upgrade. But this is still buggy for both upgrade and convert case; there's no
check for cargo type. If there's space for 2 infantry units, that pass as
transport capacity for 2 aircraft.



___

File Attachments:


---
Date: Thu 24 Jan 2013 01:39:46 AM EET  Name: ConvertTerrainCheck.patch  Size:
776B   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev