Update of bug #20494 (project freeciv):
Status: Ready For Test = Fixed
Open/Closed:Open = Closed
___
Reply to this item at:
Update of bug #20494 (project freeciv):
Assigned to:None = pepeto
Planned Release: = 2.3.5, 2.4.0, 2.5.0
___
Follow-up Comment #4:
I vaguely remember
Follow-up Comment #3, bug #20494 (project freeciv):
dio_put_uint8() reports:
1: Trying to put 117815226 into 8 bits
1: Trying to put -1078379272 into 8 bits
1: Trying to put 1970164 into 8 bits
1: Trying to put 1970164 into 8 bits
1: Trying to put 155 into 8 bits
valgrind reports:
Follow-up Comment #2, bug #20494 (project freeciv):
I don't see what's wrong in initializing this structure to zero. In the same
file, function send_connect_route(), memset() is called for the same
structure.
___
Reply to this item at:
URL:
http://gna.org/bugs/?20494
Summary: Uninitialized PACKET_UNIT_ORDERS
Project: Freeciv
Submitted by: pepeto
Submitted on: dim. 10 févr. 2013 16:19:48 CET
Category: client
Severity: 3 - Normal
Follow-up Comment #1, bug #20494 (project freeciv):
I vaguely remember thinking this is finally deciding to leave it as it is.
Should have added comment at least to remind why exactly so. Probably I were
afraid of masking some erronous use *before* actual send.