[Freeciv-Dev] [bug #20501] Help could be clearer about CanFortify defence bonus vs cities

2013-02-20 Thread Marko Lindqvist
Follow-up Comment #9, bug #20501 (project freeciv):

 One thing i've noticed in conjunction with server-side
 auto-attack: units that have been given the 'Fortify' command
 can be reliably counted on to engage approaching enemies.

 Sounds opposite of what it should be. Fortified units have have better
defense, so they should be less likely to find attack better option than
waiting in defense. Attack also removes their fortified status, so it weakens
their defense value against further attackers.

 I noticed that unit_win_chance() is used by autoattack. Some of the recently
fixed defense bugs affected it, but I believed it to affect client side win
chance display only.

___

Reply to this item at:

  http://gna.org/bugs/?20501

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20501] Help could be clearer about CanFortify defence bonus vs cities

2013-02-20 Thread Marko Lindqvist
Follow-up Comment #10, bug #20501 (project freeciv):

 I believed it to affect client side win chance display only.

For jtn wondering what to put to NEWS: believed unit_win_chance() to affect
client side win chance display only and the change affecting
unit_win_chance() in turn was specific to city defense, for which you cannot
see the client side chance display - sum is no user-visible change.

___

Reply to this item at:

  http://gna.org/bugs/?20501

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20501] Help could be clearer about CanFortify defence bonus vs cities

2013-02-20 Thread anonymous
Follow-up Comment #11, bug #20501 (project freeciv):

 For jtn wondering what to put to NEWS:
Thank you :) I was wondering exactly that. --jtn

___

Reply to this item at:

  http://gna.org/bugs/?20501

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20501] Help could be clearer about CanFortify defence bonus vs cities

2013-02-19 Thread Jacob Nevins
Update of bug #20501 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 
 Planned Release:   2.3.5,2.4.0,2.5.0 = 2.4.0,2.5.0


___

Reply to this item at:

  http://gna.org/bugs/?20501

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20501] Help could be clearer about CanFortify defence bonus vs cities

2013-02-18 Thread Jacob Nevins
Follow-up Comment #4, bug #20501 (project freeciv):

 I vaguely wonder about making this clearer in the UI [...]
Raised separately as patch #3718.

 Then there are Worker-type units, which gui shortcut 'f' makes 
 to build fortress instead of fortifying. They still have 
 CanFortify flag, so I think gui is the only think preventign 
 them from havign forifying action too - in theory modified 
 client could send fortify request for them.
It won't be honoured though, I believe -- (UTY)F_SETTLERS units are explicitly
prevented from fortifying IIRC (we guessed that the reason is purely this UI
one).

 One thing i've noticed in conjunction with server-side 
 auto-attack: units that have been given the 'Fortify' command 
 can be reliably counted on to engage approaching enemies. Units 
 that have been given the 'Sentry' command aren't as courageous.
I haven't played with autoattack, but this sounds like a bug to me. Can you
raise a new ticket about this with some more detail?

___

Reply to this item at:

  http://gna.org/bugs/?20501

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20501] Help could be clearer about CanFortify defence bonus vs cities

2013-02-18 Thread Jacob Nevins
Update of bug #20501 (project freeciv):

  Status:None = Ready For Test 
 Planned Release: = 2.3.5,2.4.0,2.5.0  

___

Follow-up Comment #5:

Patch applies to S2_3, but I may defer applying it until it's clear that
touching strings there is worthwhile.

(file #17245)
___

Additional Item Attachment:

File name: trunk-S2_4-S2_3-help-canfortify-city-bonus.patch Size:1 KB


___

Reply to this item at:

  http://gna.org/bugs/?20501

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20501] Help could be clearer about CanFortify defence bonus vs cities

2013-02-18 Thread David Lowe
Follow-up Comment #6, bug #20501 (project freeciv):

 I haven't played with autoattack, but this sounds like a bug to me. Can you
raise a
 new ticket about this with some more detail?

Let me set up a reproducible test case.

___

Reply to this item at:

  http://gna.org/bugs/?20501

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20501] Help could be clearer about CanFortify defence bonus vs cities

2013-02-12 Thread Jacob Nevins
URL:
  http://gna.org/bugs/?20501

 Summary: Help could be clearer about CanFortify defence bonus
vs cities
 Project: Freeciv
Submitted by: jtn
Submitted on: Tue Feb 12 10:01:29 2013
Category: docs
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: Any
 Planned Release: 

___

Details:

CanFortify units get their fortify defence bonus automatically when in cities,
regardless of what they're doing. I somehow hadn't twigged that this was tied
to the CanFortify flag; it became apparent when reviewing patch #3672.

The built-in help has this to say on the subject:

In individual unit help:


  * May fortify, granting a 50% defensive bonus.


Could helpfully point out that this happens automatically in cities.

In helpdata.txt, section Combat (Default Combat Rules):


 - If the defender is a land unit, and is either fortified or inside a city,
its strength is multiplied by 1.5.


All of this text is flagged as being for the default ruleset, so it's more
excusable here.




___

Reply to this item at:

  http://gna.org/bugs/?20501

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20501] Help could be clearer about CanFortify defence bonus vs cities

2013-02-12 Thread Jacob Nevins
Follow-up Comment #1, bug #20501 (project freeciv):

I vaguely wonder about making this clearer in the UI -- currently there's
nothing stopping players from needlessly fortifying their units in cities in
the mistaken belief that this will help. Perhaps if units in cities never
reach fortified state (grey fort icon) and are permanently fortifying
(yellow F) when inside cities, and if a city is built around them they go
from fortified to fortifying, would hint (somewhat obliquely) that something
funny is going on?

I don't want to take the order away entirely, as I sometimes use it as an
alternative to Sentry when I don't want a unit to wake up and hassle me every
time a foreigner passes by.

___

Reply to this item at:

  http://gna.org/bugs/?20501

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20501] Help could be clearer about CanFortify defence bonus vs cities

2013-02-12 Thread Marko Lindqvist
Follow-up Comment #2, bug #20501 (project freeciv):

Then there are Worker-type units, which gui shortcut 'f' makes to build
fortress instead of fortifying. They still have CanFortify flag, so I think
gui is the only think preventign them from havign forifying action too - in
theory modified client could send fortify request for them.

___

Reply to this item at:

  http://gna.org/bugs/?20501

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20501] Help could be clearer about CanFortify defence bonus vs cities

2013-02-12 Thread David Lowe
Follow-up Comment #3, bug #20501 (project freeciv):

One thing i've noticed in conjunction with server-side auto-attack: units that
have been given the 'Fortify' command can be reliably counted on to engage
approaching enemies.  Units that have been given the 'Sentry' command aren't
as courageous.  Thus, there is still a benefit to having the manual fortify
command.

 Then there are Worker-type units, which gui shortcut 'f' makes to build
fortress instead of fortifying.

When i was new, this part was somewhat confusing that the same command does
two different things.  Besides, there have been times when i wished i could
have a worker just hunker down to the mountain for a turn or two.  However,
that is getting out of the scope of a 'docs' ticket.

___

Reply to this item at:

  http://gna.org/bugs/?20501

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev