[Freeciv-Dev] [bug #20565] automake warning: variable `EXTRA_freeciv_manual_DEPENDENCIES' is defined but...

[Marko Lindqvist]

Update of bug #20565 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20565] automake warning: variable `EXTRA_freeciv_manual_DEPENDENCIES' is defined but...

[Marko Lindqvist]

Follow-up Comment #7, bug #20565 (project freeciv):

>From automake-1.11.3 NEWS:

"For programs and libraries, automake now detects EXTRA_foo_DEPENDENCIES"

So it doesn't work on all automake versions we want to support, and is
redundant declaration anyway.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20565] automake warning: variable `EXTRA_freeciv_manual_DEPENDENCIES' is defined but...

[RafałMużyło]

Follow-up Comment #6, bug #20565 (project freeciv):

Well, of course it's a reserved name - that's why it was used there.
EXTRA is a valid *prefix* for _DEPENDENCIES variables - see i.e. 'info
automake1.11 Linking'.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20565] automake warning: variable `EXTRA_freeciv_manual_DEPENDENCIES' is defined but...

[Marko Lindqvist]

Follow-up Comment #5, bug #20565 (project freeciv):

It's an error in the sense that "_DEPENDENCIES" is reserved suffix for a
automake variable name, and for that reserved meaning this variable name makes
no sense.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20565] automake warning: variable `EXTRA_freeciv_manual_DEPENDENCIES' is defined but...

[RafałMużyło]

Follow-up Comment #4, bug #20565 (project freeciv):

Which version of automake are you using ?
AFAICT, while the construct does look redundant in this particular case, it's
nevertheless valid (that is, it shouldn't trigger an error).

Regarding the fixes: while they look OK, it seems that '../client/helpdata.lo'
in freeciv_manual_LDADD should be '$(top_builddir)/client/helpdata.lo', but it
doesn't look like it would make a difference.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20565] automake warning: variable `EXTRA_freeciv_manual_DEPENDENCIES' is defined but...

[Marko Lindqvist]

Update of bug #20565 (project freeciv):

  Status:None => Ready For Test 

___

Follow-up Comment #3:

Fixes attached

(file #17355, file #17356)
___

Additional Item Attachment:

File name: ManualDepLdadd.patch   Size:0 KB
File name: ManualDepLdadd-S2_4.patch  Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20565] automake warning: variable `EXTRA_freeciv_manual_DEPENDENCIES' is defined but...

[Marko Lindqvist]

Follow-up Comment #2, bug #20565 (project freeciv):

That's a good warning, the line in question does nothing sensible. It came
with bug #20095. It seems like something one meant to do just temporarily
while developing/testing the patch (not yet removing dependency list
completely, but renaming it to dummy name), but then forgot to final one.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20565] automake warning: variable `EXTRA_freeciv_manual_DEPENDENCIES' is defined but...

[Jacob Nevins]

Update of bug #20565 (project freeciv):

 Planned Release:   2.5.0 => 2.4.0,2.5.0

___

Follow-up Comment #1:

Actually this is happening on S2_4 as well (only it's manual/Makefile.am
there).

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20565] automake warning: variable `EXTRA_freeciv_manual_DEPENDENCIES' is defined but...

[Jacob Nevins]

URL:
  

 Summary: automake warning: variable
`EXTRA_freeciv_manual_DEPENDENCIES' is defined but...
 Project: Freeciv
Submitted by: jtn
Submitted on: Wed Feb 27 00:33:54 2013
Category: bootstrap
Severity: 2 - Minor
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 2.5.0

___

Details:

Recently I've been getting the following warning when automake runs (e.g. as
part of autogen.sh):


tools/Makefile.am:45: variable `EXTRA_freeciv_manual_DEPENDENCIES' is defined
but no program or
tools/Makefile.am:45: library has `EXTRA_freeciv_manual' as canonical name
(possible typo)


The relevant bit of tools/Makefile.am is:


# This is a bit of a hack.  The program links in with the server lib
# but also uses some files from the client.
EXTRA_freeciv_manual_DEPENDENCIES = \
 $(top_builddir)/client/helpdata.lo





___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev