[Freeciv-Dev] [bug #20750] packets.c:send_packet_data(): warning: variable 'packet_type' set but not used [-Wunused-but-set-variable]

[Marko Lindqvist]

Update of bug #20750 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20750] packets.c:send_packet_data(): warning: variable 'packet_type' set but not used [-Wunused-but-set-variable]

[Marko Lindqvist]

Update of bug #20750 (project freeciv):

Category:None => general
 Assigned to:None => cazfi  
 Planned Release:   2.4.0 => 2.3.5, 2.4.0   


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20750] packets.c:send_packet_data(): warning: variable 'packet_type' set but not used [-Wunused-but-set-variable]

[pepeto]

Update of bug #20750 (project freeciv):

  Status:None => Ready For Test 
 Planned Release: 2.4.0,2.5.0 => 2.4.0  

___

Follow-up Comment #1:

Patch attached for S2_4. It applies cleanly to S2_3 too.

Note this warning shouldn't appear in S2_5 and trunk.


(file #17969)
___

Additional Item Attachment:

File name: send_packet_data.diff  Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20750] packets.c:send_packet_data(): warning: variable 'packet_type' set but not used [-Wunused-but-set-variable]

[Jacob Nevins]

URL:
  

 Summary: packets.c:send_packet_data(): warning: variable
'packet_type' set but not used [-Wunused-but-set-variable]
 Project: Freeciv
Submitted by: jtn
Submitted on: Sat Apr 20 10:58:51 2013
Category: None
Severity: 2 - Minor
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: S2_4 r22731
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 2.4.0,2.5.0

___

Details:

Noticed scrolling by while making a test S2_4 release build:


  CC packets.lo
packets.c: In function 'send_packet_data':
packets.c:205:9: warning: variable 'packet_type' set but not used
[-Wunused-but-set-variable]


Since this wasn't an --enable-debug=yes build (no -Werror), this warning
didn't stop the build. In fact it looks like this will only show up when
debugging is off, because the variable is only used if DEBUG is defined, so
it'll never break the build. Should still clean it up though.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev