[Freeciv-Dev] [bug #20856] aisettler.c:food_starvation() seems to assume hardcoded 2 food/citizen.

[Marko Lindqvist]

Update of bug #20856 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20856] aisettler.c:food_starvation() seems to assume hardcoded 2 food/citizen.

[Marko Lindqvist]

Follow-up Comment #5, bug #20856 (project freeciv):

- S2_3 version

(file #18227)
___

Additional Item Attachment:

File name: FoodStarvation-S2_3.patch  Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20856] aisettler.c:food_starvation() seems to assume hardcoded 2 food/citizen.

[Marko Lindqvist]

Update of bug #20856 (project freeciv):

  Status:None => Ready For Test 
 Assigned to:None => cazfi  


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20856] aisettler.c:food_starvation() seems to assume hardcoded 2 food/citizen.

[Micke]

Follow-up Comment #4, bug #20856 (project freeciv):

Quite so. I forgot to change < to <=...


(file #18041)
___

Additional Item Attachment:

File name: aisettler_food_starvation.diff Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20856] aisettler.c:food_starvation() seems to assume hardcoded 2 food/citizen.

[Emmet Hikory]

Follow-up Comment #3, bug #20856 (project freeciv):

Shouldn't this be game.info.food_cost+1 ?  While the logic will allow growth,
I think it represents a behaviour change that would cause the AI to select
less favorable cities more often (where inherent food surplus is only 1 rather
than 2).  I'm not opposed to this behaviour change for 2.5 or 2.6 if others
think it a good idea, but think it ought not be changed for 2.3 and 2.4.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20856] aisettler.c:food_starvation() seems to assume hardcoded 2 food/citizen.

[Micke]

Follow-up Comment #2, bug #20856 (project freeciv):

This basic one ought to work on all versions. I don't think it's worth the
trouble of doing more unless one can make the AI send workers out ahead to
work on land for future use in a reasonable manner.

(file #18038)
___

Additional Item Attachment:

File name: aisettler_food_starvation.diff Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20856] aisettler.c:food_starvation() seems to assume hardcoded 2 food/citizen.

[Marko Lindqvist]

Update of bug #20856 (project freeciv):

 Planned Release: => 2.3.5, 2.4.0, 2.5.0,
2.6.0

___

Follow-up Comment #1:

It seems like that to me too. Will you prepare patches for this?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20856] aisettler.c:food_starvation() seems to assume hardcoded 2 food/citizen.

[Micke]

URL:
  

 Summary: aisettler.c:food_starvation() seems to assume
hardcoded 2 food/citizen.
 Project: Freeciv
Submitted by: mss_8734
Submitted on: Thu May 30 14:29:47 2013
Category: ai
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

static bool food_starvation(const struct cityresult *result)
{
  /* Avoid starvation: We must have enough food to grow. */
  return (result->city_center.tdc->food
  + (result->best_other.tdc ? result->best_other.tdc->food
: 0) < 3);
}

Am I reading this function and its use completely wrong or ought that rely on
the ruleset defined food cost for citizen upkeep?





___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev