Update of bug #21144 (project freeciv):
Status: Ready For Test = Fixed
Assigned to:None = cazfi
Open/Closed:Open = Closed
Follow-up Comment #5, bug #21144 (project freeciv):
- S2_3 version
(file #19055)
___
Additional Item Attachment:
File name: PossiblyNegated-S2_3.patch Size:21 KB
___
Reply to
Follow-up Comment #3, bug #21144 (project freeciv):
- S2_5 version
- New TRUNK version: One more use of BOOL_TO_TRISTATE()
Also, bug affects RPT_CERTAIN too: uncertain negated req is evaluated as TRUE
while it should be FALSE.
(file #19030, file #19031)
Update of bug #21144 (project freeciv):
Status: In Progress = Ready For Test
___
Follow-up Comment #4:
- S2_4 version
(file #19037)
___
URL:
http://gna.org/bugs/?21144
Summary: RPT_POSSIBLE and negated reqs returning wrong answer
Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 17 Sep 2013 02:15:45 AM EEST
Category: general
Severity:
Follow-up Comment #1, bug #21144 (project freeciv):
Patch for TRUNK.
This patch touches so many lines of requirements.c that any change to that
file is likely to cause this patch not to apply at all. For that reason this
should go in quick to minimize the risk of conflicts. I won't wait
Follow-up Comment #2, bug #21144 (project freeciv):
Forgot to do one modification pass to the patch: Do not pass req_problem_type
to functions that no longer need it (they return TRI_MAYBE instead of boolean
value that depends on problem type)
(file #19017)