[Freeciv-Dev] [bug #21144] RPT_POSSIBLE and negated reqs returning wrong answer

2013-09-22 Thread Marko Lindqvist
Update of bug #21144 (project freeciv):

  Status:  Ready For Test = Fixed  
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?21144

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #21144] RPT_POSSIBLE and negated reqs returning wrong answer

2013-09-20 Thread Marko Lindqvist
Follow-up Comment #5, bug #21144 (project freeciv):

- S2_3 version

(file #19055)
___

Additional Item Attachment:

File name: PossiblyNegated-S2_3.patch Size:21 KB


___

Reply to this item at:

  http://gna.org/bugs/?21144

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #21144] RPT_POSSIBLE and negated reqs returning wrong answer

2013-09-17 Thread Marko Lindqvist
Follow-up Comment #3, bug #21144 (project freeciv):

- S2_5 version
- New TRUNK version: One more use of BOOL_TO_TRISTATE()

Also, bug affects RPT_CERTAIN too: uncertain negated req is evaluated as TRUE
while it should be FALSE.

(file #19030, file #19031)
___

Additional Item Attachment:

File name: PossiblyNegated-3.patch.bz2Size:4 KB
File name: PossiblyNegated-S2_5.patch.bz2 Size:4 KB


___

Reply to this item at:

  http://gna.org/bugs/?21144

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #21144] RPT_POSSIBLE and negated reqs returning wrong answer

2013-09-17 Thread Marko Lindqvist
Update of bug #21144 (project freeciv):

  Status: In Progress = Ready For Test 

___

Follow-up Comment #4:

- S2_4 version

(file #19037)
___

Additional Item Attachment:

File name: PossiblyNegated-S2_4.patch.bz2 Size:3 KB


___

Reply to this item at:

  http://gna.org/bugs/?21144

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #21144] RPT_POSSIBLE and negated reqs returning wrong answer

2013-09-16 Thread Marko Lindqvist
URL:
  http://gna.org/bugs/?21144

 Summary: RPT_POSSIBLE and negated reqs returning wrong answer
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 17 Sep 2013 02:15:45 AM EEST
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: In Progress
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.3.5, 2.4.1, 2.5.0, 2.6.0

___

Details:

RPT_POSSIBLE effect is evaluated to boolean result already when it's reversed
for negated req. This means that uncertain negated req will evaluate to FALSE
while it should be TRUE.

I'm introducing enum fc_tristate type (with values TRI_NO, TRI_YES, and
TRI_MAYBE) and evaluating requirements to that type (instead of boolean) until
negating the result for negated requirements.




___

Reply to this item at:

  http://gna.org/bugs/?21144

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #21144] RPT_POSSIBLE and negated reqs returning wrong answer

2013-09-16 Thread Marko Lindqvist
Follow-up Comment #1, bug #21144 (project freeciv):

Patch for TRUNK.

This patch touches so many lines of requirements.c that any change to that
file is likely to cause this patch not to apply at all. For that reason this
should go in quick to minimize the risk of conflicts. I won't wait
implementation for other branches (that each needs to be made from scratch) to
be ready for commit at the same time, but am about to commit this one as soon
as possible.

(file #19016)
___

Additional Item Attachment:

File name: PossiblyNegated.patch.bz2  Size:4 KB


___

Reply to this item at:

  http://gna.org/bugs/?21144

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #21144] RPT_POSSIBLE and negated reqs returning wrong answer

2013-09-16 Thread Marko Lindqvist
Follow-up Comment #2, bug #21144 (project freeciv):

Forgot to do one modification pass to the patch: Do not pass req_problem_type
to functions that no longer need it (they return TRI_MAYBE instead of boolean
value that depends on problem type)

(file #19017)
___

Additional Item Attachment:

File name: PossiblyNegated-2.patch.bz2Size:4 KB


___

Reply to this item at:

  http://gna.org/bugs/?21144

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev