[Freeciv-Dev] [bug #21326] You already had a city called Helsinki. The city was renamed to Helsinki.
Update of bug #21326 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?21326 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21326] You already had a city called Helsinki. The city was renamed to Helsinki.
Update of bug #21326 (project freeciv): Status: In Progress = Ready For Test ___ Follow-up Comment #6: Comment added for featured_text_to_plain_text(). (file #20739) ___ Additional Item Attachment: File name: featured_text_to_plain_text2.patch Size:5 KB ___ Reply to this item at: http://gna.org/bugs/?21326 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21326] You already had a city called Helsinki. The city was renamed to Helsinki.
Update of bug #21326 (project freeciv): Assigned to:None = pepeto ___ Reply to this item at: http://gna.org/bugs/?21326 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21326] You already had a city called Helsinki. The city was renamed to Helsinki.
Update of bug #21326 (project freeciv): Status:None = Ready For Test Planned Release: = 2.4. ___ Reply to this item at: http://gna.org/bugs/?21326 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21326] You already had a city called Helsinki. The city was renamed to Helsinki.
Update of bug #21326 (project freeciv): Category:None = general Planned Release:2.4. = 2.4.3,2.5.0,2.6.0 ___ Follow-up Comment #3: Fix attached which replace only the links built by users (and client lua script). Server link texts are reputed to be correct. This kind of makes sense for units (as it can translate the name into the reader's language), but that doesn't really apply to city names. It allows users to have updated links, to communicate whereas they don't have the same city names at map, and to avoid users making voluntary wrong names when editing links (in chatline). (file #20731) ___ Additional Item Attachment: File name: featured_text_to_plain_text.patch Size:4 KB ___ Reply to this item at: http://gna.org/bugs/?21326 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21326] You already had a city called Helsinki. The city was renamed to Helsinki.
Follow-up Comment #4, bug #21326 (project freeciv): It allows users to have updated links, to communicate whereas they don't have the same city names at map, and to avoid users making voluntary wrong names when editing links (in chatline). Ah, that makes sense, thanks. That's probably worth noting in a comment. ___ Reply to this item at: http://gna.org/bugs/?21326 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21326] You already had a city called Helsinki. The city was renamed to Helsinki.
Follow-up Comment #2, bug #21326 (project freeciv): Possible fixes are to make the client honour the 'name=' property of links more often, or to defer the notify_player() on the server to later in transfer_city() (probably after the call to send_city_info())? What about using [l ...]Valencia[/l] in this case ? ___ Reply to this item at: http://gna.org/bugs/?21326 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21326] You already had a city called Helsinki. The city was renamed to Helsinki.
URL:
http://gna.org/bugs/?21326
Summary: You already had a city called Helsinki. The city was
renamed to Helsinki.
Project: Freeciv
Submitted by: log65536
Submitted on: Wed Dec 4 20:28:07 2013
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
Status: None
Assigned to: None
Originator Email:
Open/Closed: Open
Release:
Discussion Lock: Any
Operating System: None
Planned Release:
___
Details:
I got this message when I captured an enemy's Helsinki and the server
automatically renamed it to Valencia, because I already had another city
called Helsinki.
The bug sounded trivial, so I decided to investigate:
sz_strlcpy(old_city_name, city_name(pcity));
if (CNM_PLAYER_UNIQUE == game.server.allowed_city_names
city_list_find_name(ptaker-cities, city_name(pcity))) {
sz_strlcpy(pcity-name,
city_name_suggestion(ptaker, pcenter));
notify_player(ptaker, pcenter, E_BAD_COMMAND, ftc_server,
_(You already had a city called %s.
The city was renamed to %s.),
old_city_name,
city_link(pcity));
}
My guess is that city_link() creates the link correctly to the city now called
Valencia, but the client processes this link by city id rather than by name,
and thus uses the old name.
Unfortunately, I am not familiar enough with the code to investigate further.
___
Reply to this item at:
http://gna.org/bugs/?21326
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21326] You already had a city called Helsinki. The city was renamed to Helsinki.
Follow-up Comment #1, bug #21326 (project freeciv): My guess is that city_link() creates the link correctly to the city now called Valencia, but the client processes this link by city id rather than by name, and thus uses the old name. Spot on. See common/featured_text.c:text_tag_replace_text(). This kind of makes sense for units (as it can translate the name into the reader's language), but that doesn't really apply to city names. And I think the correct name will be provided in the link as a '[l tgt=city ... name=Valencia]', which makes it a bit silly to get this wrong! Possible fixes are to make the client honour the 'name=' property of links more often, or to defer the notify_player() on the server to later in transfer_city() (probably after the call to send_city_info())? ___ Reply to this item at: http://gna.org/bugs/?21326 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
