[Freeciv-Dev] [bug #21347] Ability to not save resources not exposed to scenario editor

[Marko Lindqvist]

Update of bug #21347 (project freeciv):

  Status:  Ready For Test => Duplicate  
 Open/Closed:Open => Closed 

___

Follow-up Comment #12:

-> patch #7325

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21347] Ability to not save resources not exposed to scenario editor

[Marko Lindqvist]

Follow-up Comment #9, bug #21347 (project freeciv):

New TRUNK version of the revert patch, containing network protocol changes.

(file #27656)
___

Additional Item Attachment:

File name: RevertEditorHaveResources-2.patch Size:9 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21347] Ability to not save resources not exposed to scenario editor

[Marko Lindqvist]

Update of bug #21347 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #8:

Patches to revert editor view of have_resources (some other parts of recent
changes remain as rework toward future implementation)

If this revert gets accepted as solution for now, new ticket about really
adding editor support for have_resources should be added.

(file #27638, file #27639)
___

Additional Item Attachment:

File name: RevertEditorHaveResources.patch Size:8 KB
File name: RevertEditorHaveResources-S2_6.patch Size:6 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21347] Ability to not save resources not exposed to scenario editor

[Marko Lindqvist]

Update of bug #21347 (project freeciv):

  Status:   Fixed => In Progress
 Open/Closed:  Closed => Open   

___

Follow-up Comment #7:

Turns out 'have_resources' set to FALSE interacts really badly with existing
vision. It could only be used in a scenario map that has no players.

For now (and permanently for S2_6) I see removal of the editor support for
'have_resources' as the best course of action.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21347] Ability to not save resources not exposed to scenario editor

[Marko Lindqvist]

Update of bug #21347 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21347] Ability to not save resources not exposed to scenario editor

[Marko Lindqvist]

Follow-up Comment #4, bug #21347 (project freeciv):

> There's problems with the initial state of the setting in client side

-> bug #24767

That part should not require network protocol changes.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21347] Ability to not save resources not exposed to scenario editor

[Marko Lindqvist]

Update of bug #21347 (project freeciv):

  Status:None => Ready For Test 
 Contains string changes:None => Yes

___

Follow-up Comment #3:

S2_6 version

There's problems with the initial state of the setting in client side, but
those are likely to go to another ticket (have to investigate a bit more)


(file #27560)
___

Additional Item Attachment:

File name: EditorHaveResources-S2_6-2.patch Size:12 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21347] Ability to not save resources not exposed to scenario editor

[Marko Lindqvist]

Follow-up Comment #2, bug #21347 (project freeciv):

TRUNK commit candidate. S2_6 to follow.

(file #27558)
___

Additional Item Attachment:

File name: EditorHaveResources-2.patchSize:16 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21347] Ability to not save resources not exposed to scenario editor

[Marko Lindqvist]

Follow-up Comment #1, bug #21347 (project freeciv):

My current WIP patch for TRUNK attached, but as long as bug #24627 is there,
it's quite useless.

(file #27244)
___

Additional Item Attachment:

File name: EditorHaveResources.patch  Size:16 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21347] Ability to not save resources not exposed to scenario editor

[Marko Lindqvist]

Update of bug #21347 (project freeciv):

  Depends on: => bugs #24627


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21347] Ability to not save resources not exposed to scenario editor

[Marko Lindqvist]

Update of bug #21347 (project freeciv):

Category:None => editor 
 Planned Release: => 2.6.0, 3.0.0   


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21347] Ability to not save resources not exposed to scenario editor

[Jacob Nevins]

Update of bug #21347 (project freeciv):

  Depends on: = bugs #21346


___

Reply to this item at:

  http://gna.org/bugs/?21347

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21347] Ability to not save resources not exposed to scenario editor

[Jacob Nevins]

URL:
  http://gna.org/bugs/?21347

 Summary: Ability to not save resources not exposed to
scenario editor
 Project: Freeciv
Submitted by: jtn
Submitted on: Sat Dec 14 13:27:03 2013
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: Any
 Planned Release: 

___

Details:

For scenarios, the savefile format has the ability to specify that no
resources be saved in the scenario, so that resources will be generated
randomly when the scenario is loaded for play, according to settings chosen in
pregame.

(This is controlled by the specials capability in the savefile, which
becomes the server's have_resources variable -- in fact these have
controlled whether more stuff is saved at various times, see bug #21346 for
confusion, which will need sorting out first.)

* There's an additional wrinkle: if the savegame doesn't have the specials
capability but does have rivers_overlay, then just river specials are saved
(in older versions; gen_roads makes this moot in newer versions).

However, there's no way for people editing scenarios with the built-in map
editor to access this functionality, though -- it's currently necessary to
hack savefiles by hand, I think. (Maybe the old, separate editor could use
these?)

The only way to load a scenario for editing is to start a game with it (which
will generate resources and set have_resources). If you go into edit mode and
do save scenario, those resources will be saved in the game and new
resources will not be generated when the resulting scenario is loaded for
play.

Existing scenarios with this property (search as earth-80x50-v3, which has
rivers_overlay instead of specials) thus can't be edited without losing
this property.

The obvious place to expose this in the UI is as a flag alongside Save
players in game/scenario properties. Implementation issues:
* What should be the UI if a player does save scenario with this flag set
but resources present on the map? The obvious one is to pop up a clear
resources or unset flag choice, but the client/server interaction makes this
hard. Unlike players, I'm uncomfortable with quietly discarding stuff in the
savefile but leaving it visible in the editor -- too easy to lose work.
* We'll need to squirrel away the 'have_resources' value from game load so
that it can be reinstated on scenario save, because currently you can only
edit having gone through a game-start transition, which will set the real
have_resources flag.

Could in principle expose 'have_rivers_overlay', but if we only get round to
this in S2_5 or later (as seems likely) then I think the issue goes away (and
so should rivers_overlay, probably).

May as well expose 'have_huts' at the same time (once the confusion of bug
#21345 is sorted out).




___

Reply to this item at:

  http://gna.org/bugs/?21347

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev