[Freeciv-Dev] [bug #21384] Client segfault in fill_grid_sprite_array on server shutdown or player /remove
Follow-up Comment #10, bug #21384 (project freeciv): What kind of implications this has on 'foggedborders' setting? The bug, or the fix? I think the crash occurred regardless of foggedborders. As regards the fixed version, this bit of comment #3 describes the main quirk that can happen with foggedborders enabled: if the [dead] player slot ever ends up reused to make room for a new player, as in create_command_newcomer(), then we will need to remove the dead players' info from other player maps at that time, which will look a little odd -- information will disappear from your map for no apparent reason -- but probably won't occur much in practice ___ Reply to this item at: http://gna.org/bugs/?21384 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21384] Client segfault in fill_grid_sprite_array on server shutdown or player /remove
Follow-up Comment #8, bug #21384 (project freeciv): Postscript: cazfi actually spotted this problem nearly two years ago. From bug #18588 comment 1: I suspect that there's similar problem when tile owner is removed from game. Remaining players may still have him as owner of the tile in their player map. Fixing this needs more investigation. Setting tile owner to NULL is part of player map removal, and it might be bad idea to simply call tile knowledge update for all players when one player map is in such a state. I don't *think* my solution trips over the issue described... ___ Reply to this item at: http://gna.org/bugs/?21384 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21384] Client segfault in fill_grid_sprite_array on server shutdown or player /remove
Update of bug #21384 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?21384 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21384] Client segfault in fill_grid_sprite_array on server shutdown or player /remove
Update of bug #21384 (project freeciv): Category: client-gtk-2.0 = general Status:None = Ready For Test Assigned to:None = jtn Operating System: GNU/Linux = Any Planned Release: 2.4.2 = 2.4.2,2.5.0,2.6.0 Summary: Client segfault in fill_grid_sprite_array on server shutdown = Client segfault in fill_grid_sprite_array on server shutdown or player /remove ___ Follow-up Comment #4: Patches which clear up other player's maps when a player is removed. I haven't managed to reproduce a crash after applying these patches. (file #19557, file #19558) ___ Additional Item Attachment: File name: trunk-remove-player-map.patch Size:4 KB File name: S2_5-S2_4-remove-player-map.patch Size:4 KB ___ Reply to this item at: http://gna.org/bugs/?21384 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
