[Freeciv-Dev] [bug #21427] Nationset rule_name mandatory
Update of bug #21427 (project freeciv): Status:None = Ready For Test Assigned to:None = jtn ___ Follow-up Comment #3: Maybe this ticket could then be resolved by adding more comments to default/nationlist.ruleset about how the rule_name is being used How about this patch? (file #19664) ___ Additional Item Attachment: File name: trunk-nationsets-comments.patch Size:9 KB ___ Reply to this item at: http://gna.org/bugs/?21427 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21427] Nationset rule_name mandatory
Follow-up Comment #4, bug #21427 (project freeciv): How about this patch? Approved. ___ Reply to this item at: http://gna.org/bugs/?21427 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21427] Nationset rule_name mandatory
Follow-up Comment #1, bug #21427 (project freeciv): Hm. I'm not sure what I was thinking (it's been a long time) but I'm guessing that I wanted to encourage people providing nation sets to provide all of: 0 a short, machine-friendly name (all) to go in the setting (no spaces or apostrophes or other awkwardness) 0 a short friendly name (Extended) for the client UI 0 a long description for the client UI I think the potential persistence in settings and server scripts and direct user interaction is what makes this different from most other ruleset items with rule_names. However, since the nationset is compared case-insensitively, and spaces can be quoted, I suppose it wouldn't be a disaster to allow 1 and 2 to be the same by default. Looking at the minimal mandatory nation set spec in a ruleset is instructive. For alien we have [nset_all] name=_(All nations) rule_name=all The only place this shows up is /list nations: list nations List of nation sets available for 'nationset' option: -- all All nations (7 playable) -- If we got rid of the rule_name it would look like -- All nations All nations (7 playable) -- Bit ugly. We could just call it All, which leaves the minor cosmetic ugliness that it's got a leading uppercase letter whereas the default ruleset doesn't (the fix would be simple if I cared that much). None of this is a very strong argument for keeping rule_name mandatory. I also wanted to encourage that nationsets had conventional names across rulesets, so that if you speak English and always want all available nations, you can just set nationset=all and forget about it and expect it to Just Work with standard-shaped rulesets. ___ Reply to this item at: http://gna.org/bugs/?21427 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21427] Nationset rule_name mandatory
Update of bug #21427 (project freeciv): Planned Release: = 2.5.0,2.6.0 ___ Reply to this item at: http://gna.org/bugs/?21427 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21427] Nationset rule_name mandatory
Follow-up Comment #2, bug #21427 (project freeciv): the potential persistence in settings and server scripts and direct user interaction Ok, thanks for clarifying this. Maybe this ticket could then be resolved by adding more comments to default/nationlist.ruleset about how the rule_name is being used in user commands and listings (it's not invisible to end-user like other rule_names) to make it easier to pick good one (I'm off to change the one ruleset I updated last night to contain nation sets, and where I just copied name to rule_name to make set nationset more cumbersome than it should be) ___ Reply to this item at: http://gna.org/bugs/?21427 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21427] Nationset rule_name mandatory
URL: http://gna.org/bugs/?21427 Summary: Nationset rule_name mandatory Project: Freeciv Submitted by: cazfi Submitted on: Fri 03 Jan 2014 08:37:38 AM EET Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: It's at least inconsistent that rule_name is mandatory field in case of nationsets. In other places rule_name automatically defaults to 'name'. ___ Reply to this item at: http://gna.org/bugs/?21427 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
