[Freeciv-Dev] [bug #21443] Empty global_init_techs not saved

[Marko Lindqvist]

Update of bug #21443 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21443] Empty global_init_techs not saved

[Marko Lindqvist]

Follow-up Comment #2, bug #21443 (project freeciv):

- Fixed freeing of NULL building_list when one does not exist


(file #19764)
___

Additional Item Attachment:

File name: GlobalInitobjectsOptional-2.patch Size:2 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21443] Empty global_init_techs not saved

[Marko Lindqvist]

Update of bug #21443 (project freeciv):

  Status:None => Ready For Test 

___

Follow-up Comment #1:

> make the entry non-mandatory.

Attached patch makes both tech_lists and building_lists entries optional.
Since there's only one of each, I made it optional always instead of addign
parameter to list loading telling if the particular list is optional or
mandatory.

(file #19681)
___

Additional Item Attachment:

File name: GlobalInitobjectsOptional.patch Size:2 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21443] Empty global_init_techs not saved

[Marko Lindqvist]

URL:
  

 Summary: Empty global_init_techs not saved
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 05 Jan 2014 04:25:36 AM EET
Category: freeciv-ruledit
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.6.0

___

Details:

Freeciv-ruledit does not create empty options.global_init_techs entry to
game.ruleset if there's no such techs. Ruleset loading considers that entry
mandatory.

Forcing write of empty string vector to secfile would require changes to lower
level functionality (I haven't checked how hard that would be to implement),
so I'm more inclined to simply make the entry non-mandatory.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev