[Freeciv-Dev] [bug #21468] Edit start positions sent to detached connections

2014-07-23 Thread pepeto
Update of bug #21468 (project freeciv):

Category:None = editor 
  Status:None = Ready For Test 
 Assigned to:None = pepeto 
 Planned Release: = 2.4.3, 2.5.0-beta2, 2.6.0

___

Follow-up Comment #1:

Fix attached.


(file #21524)
___

Additional Item Attachment:

File name: can_conn_edit.patchSize:0 KB


___

Reply to this item at:

  http://gna.org/bugs/?21468

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #21468] Edit start positions sent to detached connections

2014-01-11 Thread Jacob Nevins
URL:
  http://gna.org/bugs/?21468

 Summary: Edit start positions sent to detached connections
 Project: Freeciv
Submitted by: jtn
Submitted on: Sat Jan 11 14:21:28 2014
Category: None
Severity: 2 - Minor
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: S2_4 r24096
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

While debugging bug #21279, I noticed that entering edit mode with a detached
client, the latter gives a string of


1: handle_edit_startpos(): invalid tile index 2494.


Root cause is similar to bug #21279 but much less severe:
edithand_send_initial_packets() sends stuff to detached connections. This is
unlikely to be much of a problem in practice as edit mode will generally only
be used in single-player games.

Not sure what the correct fix is. Connection list is currently guarded by
can_conn_edit() which is based on ALLOW_* and is true for my detached
connection. 




___

Reply to this item at:

  http://gna.org/bugs/?21468

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev