[Freeciv-Dev] [bug #21728] Ai hunter crash

[Marko Lindqvist]

Update of bug #21728 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21728] Ai hunter crash

[Marko Lindqvist]

Update of bug #21728 (project freeciv):

Priority:  5 - Normal => 9 - Immediate  
  Status: In Progress => Ready For Test 
 Assigned to:None => cazfi  

___

Follow-up Comment #2:

Fixes to be committed immediately.

- Consider can_unit_attack_tile() return value boolean which it is
- Rename can_unit_attack_...() that return unit_attack_result as
unit_attack_..._result()

(file #20203, file #20204)
___

Additional Item Attachment:

File name: UnitAttackResult.patch Size:15 KB
File name: UnitAttackResult-S2_4.patchSize:15 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21728] Ai hunter crash

[Marko Lindqvist]

Update of bug #21728 (project freeciv):

  Status:None => In Progress
 Planned Release: => 2.4.3, 2.5.0, 2.6.0

___

Follow-up Comment #1:

Crap, it's my fix of the fix going off the other way...

can_unit_attack_tile() return type still *is* boolean, so my fix to checking
return values of all the can_unit_attack_...() calls broke it.

Should also rename those functions that do *not* return boolean any more as
something else than can_...


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21728] Ai hunter crash

[Marko Lindqvist]

URL:
  

 Summary: Ai hunter crash
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 27 Feb 2014 08:00:25 AM EET
Category: ai
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

TRUNK r24572 + bug #21640 fix + attached autogame

(gdb) bt
#0  get_total_defense_power (attacker=attacker@entry=0x1326da0,
defender=defender@entry=0x0)
at common/combat.c:596
#1  0x0053ab35 in unit_win_chance (attacker=attacker@entry=0x1326da0,
defender=0x0)
at common/combat.c:375
#2  0x00518a76 in dai_hunter_manage (ait=ait@entry=0x9aa220
, pplayer=pplayer@entry=0x254d6d0, 
punit=punit@entry=0x1326da0) at ai/default/aihunt.c:499
#3  0x005195bf in eval_hunter_want (ait=ait@entry=0x9aa220 ,
pplayer=pplayer@entry=0x254d6d0, 
pcity=pcity@entry=0xff3130, choice=choice@entry=0xfce7e0,
best_type=0xb26cc0 , 
veteran=) at ai/default/aihunt.c:228
#4  0x005199e2 in dai_hunter_choice (ait=ait@entry=0x9aa220
, pplayer=pplayer@entry=0x254d6d0, 
pcity=pcity@entry=0xff3130, choice=choice@entry=0xfce7e0) at
ai/default/aihunt.c:267
#5  0x005050c7 in military_advisor_choose_build
(ait=ait@entry=0x9aa220 , 
pplayer=pplayer@entry=0x254d6d0, pcity=pcity@entry=0xff3130,
choice=choice@entry=0xfce7e0)
at ai/default/advmilitary.c:1576
#6  0x0050792d in dai_manage_cities (ait=ait@entry=0x9aa220
, pplayer=pplayer@entry=0x254d6d0)
at ai/default/aicity.c:743
#7  0x00515900 in dai_do_last_activities (ait=0x9aa220 ,
pplayer=)
at ai/default/aihand.c:762
#8  0x00435a1b in end_phase () at server/srv_main.c:1041
#9  0x004398cb in srv_running () at server/srv_main.c:2432
#10 srv_main () at server/srv_main.c:2893
#11 0x00431aae in main (argc=3, argv=0x7fffe2a8) at
server/civserver.c:454




___

File Attachments:


---
Date: Thu 27 Feb 2014 08:00:25 AM EET  Name: regression.serv  Size: 287B   By:
cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev